From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83FCC238159 for ; Wed, 3 Dec 2025 14:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764770611; cv=none; b=oSVyTzLoP/OftrwRUES1r5RHrEIUaEXlceZR4QqXQAoGhBl7hh4nEcaSid0ok0Rh4DYDllqemObmiucBj1K2f7Y40U9OmiMzqX/5NjI7d/ygoFKO0kTgT0pNamG+qxAM2n0DkmpkHztEQBIN0uOsFFVOlugrNt3hugKnxtVJ51Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764770611; c=relaxed/simple; bh=vqilaDFq7QMfW8MkOVgEv4SUxZeaRzQQ78fl47zNIKM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mpRFCrluHTXMFbqpp6DLToL3xcixLX6fYpDLZecfHTP3pdn+kn4O1tZ56/Ta4YVVF3yQmf4Yqho3oEzxHsQgxKlKfYcZuKF5xuNnWddK4N0FgxK9zK4K9EX+il81XsUs+VlEjYAfceVprvj+PEiOQfm4MfQW/eATeCoxBkUzaIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ddu3/wC6; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ddu3/wC6" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-37a5a3f6bc2so6900991fa.1 for ; Wed, 03 Dec 2025 06:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764770608; x=1765375408; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=xaodiixH7QwMZ6cHB6pQiSSb74/RAsiv51LwJjSi49k=; b=Ddu3/wC6y4oEy4W8gAPnXiPLBdd+JQsQ1p3v8ZRrc1VYjEnHd7ED6+oMNHNjJYpMMd hfBbxFZSVqr+2fw1JlB8ZubbbeggMts7qtISLCdD7Q0Nogb4li22Jq7pBQ+TikzxzZ1M Ryqk7FAw1+2XBDw7343WFga5avlYaQXXJt09a/+Qd2DGNIiJjD+DnWca3Wsseao0ENj3 XVs3D9u7JNzb89bH3v5zLqebQGf6CA7z2CcfPYANqrfHPEWRryW8jZUYAi4zpTm7hF4C yEJ4LNrYPMjmJN1Nw4YgnrnD0sGi+TwHIHuaE39hzrtAff+9IedJnGeA0c+GpDyd+GVD 1gzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764770608; x=1765375408; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xaodiixH7QwMZ6cHB6pQiSSb74/RAsiv51LwJjSi49k=; b=lRDN9vDt68BWZHNnB6MYZNKR/OPv7NcmidVXZy0zuhLaST6csdg6tOBQ+yF1Dawoyw xi9hofdVe0pRxkgsaNpoJQyIyM2YULa2bkMUnEjJja/0N43AYhsHWi3tacOKiNKhQAjw 7FhuK8JFPdHI2GUbHTYOKWWTWR4vbcyua8CTP2n9A0HWHIeh4J2NRYFIVlko7ILgOfR7 qQxgkeNAPQSn6RvAtIJA9LISIFZh0ElD8gv7ew2jBe4R6OalokrOZLHSimijm8wvvQEI +y30pZ4i6PZShj4EWZ5CbN3/X9zTKaTBCEeXVG3YozCAby0QrJ8v6Azm3TdInGUqFLFt 0xiw== X-Forwarded-Encrypted: i=1; AJvYcCXH9/2sPTgc0JW2Am3VDGYkV3bwTaL3lqTpELvwOLO8cDBaiKHu8uF+zHo+Q4ckBwDHGMRHCY/sDingktQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxaLIobUgfF3g3JnmQzMpYyiztKv2QPforEHStwjnAj6ZjJ1+XN 4ZZwyxiCJFpRQnCcwv7+GEagStYUJ/adUxdmOO1fiwUGTUIg5O5cjca04swKkhPbjfk= X-Gm-Gg: ASbGncuxmT9O8lzDNUq3OtDPCxlfpckoUHQuzbCBw8VqCd+Ma5ZIAmE6J9Sg5FdiZF1 z6vR3YDqCcX4Apidx8qKcUM55Uazrc4+3+N2AopcFFaDpeDfjez8/nSl+mI6eh7VafKVITajSVN 3RWtTaWI/xDiOSNXX5I8chLtlWlJalSJnz67ipaWmcEvTzFmCC+5UqA9Jk94ZIL7Flj+FujXB3K xcOfU6MwvAroKx9Fyr9u/nZtSxv5gCtuAoe+K3AYloCUT60WIGZhqc2j3zr0ShGihWyX56mYWFy uYgQGTmtWAmiIlbiMaEFjaUqX0xfQxq5p7GvxNm1DEWWw/cHjGKswFZelubQVgI2lHgRsqZlbEU 2E4MWckx8g27enL9t+1V9gPG3ESRde6fAa8ERD1bLTWXSSJJprjRyX2dGeQ66z8ozB/Pk3jfsNZ ZwVT5nJRxvZMTDhGOEJsQtRbjdxBBSiKluwxFR8pbZGwiJHbbULpcEPfhfVCKebdimdg== X-Google-Smtp-Source: AGHT+IHtc5YwnEGlAelBln5DgnT0yCYtU5cwvHJhsh5XAEa37+7mKlypE9Zho7J98x0QunVjtiXWtw== X-Received: by 2002:a2e:8a9c:0:b0:37a:4fb0:69a6 with SMTP id 38308e7fff4ca-37e66c0ad62mr3653081fa.2.1764770607481; Wed, 03 Dec 2025 06:03:27 -0800 (PST) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37d2369035dsm43222831fa.6.2025.12.03.06.03.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 06:03:27 -0800 (PST) Message-ID: <3e1d1dc4-7b94-47df-b4bd-f6ce4d7842dd@linaro.org> Date: Wed, 3 Dec 2025 16:03:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm8750: Add camera clock controller To: Taniya Das , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251203-sm8750_camcc_dt-v1-1-418e65e0e4e8@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20251203-sm8750_camcc_dt-v1-1-418e65e0e4e8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Taniya. On 12/3/25 12:32, Taniya Das wrote: > Add the camcc clock controller device node for SM8750 SoC. > > Signed-off-by: Taniya Das > --- > arch/arm64/boot/dts/qcom/sm8750.dtsi | 35 ++++++++++++++++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi > index 3f0b57f428bbb388521c27d9ae96bbef3d62b2e2..f09cec6358806f21827e68e365b492e563c0689a 100644 > --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi > @@ -2,7 +2,8 @@ > /* > * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. > */ > - > +#include > +#include > #include > #include > #include Please keep the list of included headers ordered. > @@ -2046,6 +2047,22 @@ aggre2_noc: interconnect@1700000 { > clocks = <&rpmhcc RPMH_IPA_CLK>; > }; > > + cambistmclkcc: clock-controller@1760000 { > + compatible = "qcom,sm8750-cambistmclkcc"; > + reg = <0x0 0x1760000 0x0 0x6000>; > + clocks = <&gcc GCC_CAM_BIST_MCLK_AHB_CLK> , > + <&bi_tcxo_div2>, > + <&bi_tcxo_ao_div2>, > + <&sleep_clk>; > + power-domains = <&rpmhpd RPMHPD_MMCX>, > + <&rpmhpd RPMHPD_MX>; > + required-opps = <&rpmhpd_opp_low_svs>, > + <&rpmhpd_opp_low_svs>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; I've briefly checked the recently sent driver, and I didn't find that this clock controller serves as a reset controller or a power domain controller. And if so, these properties shall be obviously removed. > + }; > + > mmss_noc: interconnect@1780000 { > compatible = "qcom,sm8750-mmss-noc"; > reg = <0x0 0x01780000 0x0 0x5b800>; > @@ -2740,6 +2757,22 @@ usb_dwc3_ss: endpoint { > }; > }; > > + camcc: clock-controller@ade0000 { > + compatible = "qcom,sm8750-camcc"; > + reg = <0x0 0xade0000 0x0 0x20000>; > + clocks = <&gcc GCC_CAMERA_AHB_CLK>, > + <&bi_tcxo_div2>, > + <&bi_tcxo_ao_div2>, > + <&sleep_clk>; > + power-domains = <&rpmhpd RPMHPD_MMCX>, > + <&rpmhpd RPMHPD_MXC>; > + required-opps = <&rpmhpd_opp_low_svs>, > + <&rpmhpd_opp_low_svs>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; > + > pdc: interrupt-controller@b220000 { > compatible = "qcom,sm8750-pdc", "qcom,pdc"; > reg = <0x0 0x0b220000 0x0 0x10000>, <0x0 0x164400f0 0x0 0x64>; > -- Best wishes, Vladimir