From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelvem-ot01.ext.ti.com (lelvem-ot01.ext.ti.com [198.47.23.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00B3532BF24; Tue, 9 Sep 2025 14:09:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.234 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757426985; cv=none; b=F80nC10XjLspi2elUbUG3t/lMQ8m3UGqdZdTGugZHBxzZ3s0/jMZg5AmNzWtcTBN2iqR7H9xoB8qRUxGKaWBJ7M4v/1+dkeEfSZGGOQ3eaHaIOtju023WYUHm7HZz7yJJ5vBTIMgUoUMiWxr4tyX4Lrj7Y3fPdEBqDfDIf7WzPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757426985; c=relaxed/simple; bh=kBwSso+fnsjwRZp4P34U2iuAXqsTbUTxcFnuiO+kFGY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=LbsqL4FFiK3Tc7S6tEih783SiQ5yczeoYK/hP8bXCjpEFOvdzdBGvQX7mqS6EsfVcOsBXjU/1vJnkNQI1eW986zJA/eJVLiUlzeREFJkkTgiwUxZGvaE/G5XJvdcl+MRR9J57pETwFQE8M61hgF4fHkuM7hJfMQ3Ii36L5UBg0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=OXE81EkK; arc=none smtp.client-ip=198.47.23.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="OXE81EkK" Received: from fllvem-sh04.itg.ti.com ([10.64.41.54]) by lelvem-ot01.ext.ti.com (8.15.2/8.15.2) with ESMTP id 589E8oIh4117177; Tue, 9 Sep 2025 09:08:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1757426930; bh=8nnIwcBQt92lCOlOOaGrqeudJML21vpTZzYbN2KUxng=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=OXE81EkKsvvu5bR4eko3/6126JOyjE86JMnyscYVwDS0qQ4uj1XejUHvw1WrWDJZ6 zTniqE9ktd2/BPkPDT4HDZtoW7ZzGFlrcIKBkJBqPP0/OZEGfo8lBGTwuNH6fkCjyj a7sfyl8sND/N8Rf4qOrDbAu8TscgPcrgbWEPOWJs= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by fllvem-sh04.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 589E8ovJ410472 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Tue, 9 Sep 2025 09:08:50 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Tue, 9 Sep 2025 09:08:49 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Tue, 9 Sep 2025 09:08:49 -0500 Received: from [10.249.130.74] ([10.249.130.74]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 589E8e5A2743053; Tue, 9 Sep 2025 09:08:40 -0500 Message-ID: <3e22a667-bdff-43db-9388-846b2b278d77@ti.com> Date: Tue, 9 Sep 2025 19:38:39 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 4/7] net: rpmsg-eth: Add netdev ops To: , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , References: <20250908090746.862407-1-danishanwar@ti.com> <20250908090746.862407-5-danishanwar@ti.com> <4a69e4f1-06b1-49a1-aab6-baef6c613f0b@microchip.com> Content-Language: en-US From: "Anwar, Md Danish" In-Reply-To: <4a69e4f1-06b1-49a1-aab6-baef6c613f0b@microchip.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Hi Parthiban On 9/9/2025 12:08 PM, Parthiban.Veerasooran@microchip.com wrote: > Hi, > > On 08/09/25 2:37 pm, MD Danish Anwar wrote: > >> +static int create_request(struct rpmsg_eth_common *common, >> + enum rpmsg_eth_rpmsg_type rpmsg_type) >> +{ >> + struct message *msg = &common->send_msg; >> + int ret = 0; >> + >> + msg->msg_hdr.src_id = common->port->port_id; >> + msg->req_msg.type = rpmsg_type; >> + >> + switch (rpmsg_type) { >> + case RPMSG_ETH_REQ_SHM_INFO: >> + msg->msg_hdr.msg_type = RPMSG_ETH_REQUEST_MSG; >> + break; >> + case RPMSG_ETH_REQ_SET_MAC_ADDR: >> + msg->msg_hdr.msg_type = RPMSG_ETH_REQUEST_MSG; >> + ether_addr_copy(msg->req_msg.mac_addr.addr, >> + common->port->ndev->dev_addr); >> + break; >> + case RPMSG_ETH_NOTIFY_PORT_UP: >> + case RPMSG_ETH_NOTIFY_PORT_DOWN: >> + msg->msg_hdr.msg_type = RPMSG_ETH_NOTIFY_MSG; >> + break; >> + default: >> + ret = -EINVAL; >> + dev_err(common->dev, "Invalid RPMSG request\n"); > I don't think you need 'ret' here instead directly return -EINVAL and > above 'ret' declaration can be removed. >> + } >> + return ret; > can be return 0; Sure. I will drop ret. >> +} >> + >> +static int rpmsg_eth_create_send_request(struct rpmsg_eth_common *common, >> + enum rpmsg_eth_rpmsg_type rpmsg_type, >> + bool wait) >> +{ >> + unsigned long flags; >> + int ret = 0; > No need to initialize. Sure. Will drop this. >> + >> + if (wait) >> + reinit_completion(&common->sync_msg); >> + >> + spin_lock_irqsave(&common->send_msg_lock, flags); >> + >> +static int rpmsg_eth_set_mac_address(struct net_device *ndev, void *addr) >> +{ >> + struct rpmsg_eth_common *common = rpmsg_eth_ndev_to_common(ndev); >> + int ret; >> + >> + ret = eth_mac_addr(ndev, addr); >> + >> + if (ret < 0) >> + return ret; >> + ret = rpmsg_eth_create_send_request(common, RPMSG_ETH_REQ_SET_MAC_ADDR, false); > You can directly return from here. Sure. >> + return ret; >> +} >> + > Best regards, > Parthiban V -- Thanks and Regards, Md Danish Anwar