Re: [PATCH] arm: dts: broadcom: Add missing required fields

[Stefan Wahren <wahrenst@gmx.net>]

Hi Karan,

Am 25.09.24 um 18:14 schrieb Karan Sanghavi:
> Added below mentioned required fields
>    1. interrupt-controller
>    2. #interrupt-cells
> in the bcm2711.dtsi file for the
> interrupt-controller@40000000 block as defined in the
> bindings/interrupt-controller/brcm,bcm2836-l1-intc.yaml.
> This issue was noticed while compiling the dtb file
> for broadcom/bcm2711-rpi-4-b.dts file.
> After including the above fields in the dtsi file
> interrupt-conntroller error was resolved.
looks like you made the same mistake like me [1]. This change breaks
boot of Raspberry Pi 4 [2].

There are a lot of DT schema warnings to fix, but this doesn't belong to
the trivial ones.

[1] -
https://lore.kernel.org/linux-arm-kernel/20240812200358.4061-5-wahrenst@gmx.net/
[2] -
https://lore.kernel.org/linux-arm-kernel/CA+G9fYuncv0fuBSC0A1z1G_UOv_XuMQz=DsrLZDK-Wc=10ghag@mail.gmail.com/
>
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> ---
>   arch/arm/boot/dts/broadcom/bcm2711.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711.dtsi b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> index e4e42af21ef3..313b1046d74f 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
> @@ -51,6 +51,8 @@ soc {
>   		local_intc: interrupt-controller@40000000 {
>   			compatible = "brcm,bcm2836-l1-intc";
>   			reg = <0x40000000 0x100>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
>   		};
>
>   		gicv2: interrupt-controller@40041000 {