From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47A7E21D3E2 for ; Thu, 7 May 2026 15:35:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168141; cv=none; b=s0WNVqbhjZcGw0vYz7DyCOmuX8QS1sy0VIb4CQA77fL1Sj6GHc3rSux/K1BD7jAiZXSUN4bvl7zKjPzxrTkS7SxTwU8XBMjWdLzX7oj6AnW6qBX6V5wBJKIKdocJyQBUlmpRi2vk66SjulURhxCBYJF74daWQ4acz4erK7uKWDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168141; c=relaxed/simple; bh=m8M9TFUDAcjhkX2bd21OSbzoYzvd75yKpOtde5SJ6DE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=h7kqkkAyMTriHq04eBxecQ6zMZBPSbmgTOJci/3EfPAazI0vzzU8C9SRX58Vab64kGOQRVI7CIN1LFDXjysXh5xUBpdNAgEB4agwG2b1DWaBK7LkRF6HNLT7jnrJEANYcNdOvHG4RIIXkrFggjNZKYesuOdcJUa5XLf06sVIZlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vu8/jRjz; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vu8/jRjz" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48d146705b4so12545085e9.3 for ; Thu, 07 May 2026 08:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168138; x=1778772938; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=48EgchF5dtmC/4scZDvcW2a4RnHCw/qdBUIKinwh0Wk=; b=vu8/jRjzl3lLkvsrcADAtapZRFmQtl5xx8BP7m1RquElGq+Xssykm2nRsAXk3Kiqe6 fqKaGNMmeDyUX0GgPUFATSv4RfLBd0Wmzm5oKREHPRnSHR2ixYaDmW9Mtc1UUAhgWBi0 nosObDYTGQxuep57vncxVtaCqEjQ4LXrnWqPtprybdTsZ/Xtemj1IXDXdoNP3fn5pi9N RHsCydcwkUwpNNytDGzZuTVT9L4ZSbXGCq9PPdX62YarZgK1+0gTlpFKxFLeX/P+m1qu no0dJ70DJMMUJCwKaXx3xZIu9HSpZ05MUJla8eciglgbG6PPhXGBwfe33DDnSe5qTeZm qegg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168138; x=1778772938; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=48EgchF5dtmC/4scZDvcW2a4RnHCw/qdBUIKinwh0Wk=; b=nIv9vPPjNjUIQUU58awzeQK1Q4N0gQNqzhQGQc4/VTRX3DwkG++0lVzYZHFofARUTA tUliZo/xmRZqQg/x7ILQpB/owJrr/jeHoU9c7QNk1gbewCefRYzTvabRwql71DE0oBCp K3NSscvXNEFa17rdMSyHJC6e4AdQpJWRZ1ZN1ST4XO5YAiEgyUs5m+2S+zt3Uteh09pI xtkFrJFwNOYQV4rCDeEuOZLby9t4bpZF+Zjl7Cl/2LGHDR5277UFuYRIC+vpS4ghzmNn pQOJC+qrv+87tLCrylQl5ecQ5Tvpuo70G4H72vN2DwdZFOIm2ygvgMj3aoAb1zeRGxI6 y8qw== X-Forwarded-Encrypted: i=1; AFNElJ/qgQEM6kzM7NTcMyli4GHcvApVyB6C5CBByzQPxL1nxfYvP8OtUXTmM6Pwp+ZDtYGaLNAWL15LGYqybt8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5kb8OruSl/Wd5hURFAnLirwwvwd0w42VCfMI2t9QZxp9LwviB C50SR6Ds5r3LfMrrMm5nO4BckSFCKDbnDC5yF8jpoFGnQbtxcKzsURYxoLECKB6wonI= X-Gm-Gg: AeBDieuqEhG7PF9+p3MSY7xvQhgtXAMdfCoWuRJmS6fkaiRSy2Ib8f46dY78kn6kHyb 6wqysFXxRyi51vmL0tIbx32+MgBzyggBo2rrQSJtZT9weopiIWa1MZCmN541i/LUljwkAIwp8kj H7FWV0oJFML38M9jrPpkiBOBqXuxL3fVTBLwcVqvkhtv+40UOYpLXArCnJB/V+6IhQ3uYw5AbKQ xrHkmZnC4YNfx9eW98aJMFZ/LF9G6p9FETIeo/hdJ+w8blgV10F5WbnUOlYXBJW9Wp16F8dMN7h Mi5tvLW22fChm+PqYFUnctBUpRIN355euxBo2zxMndqh8sJIpglSIU9gIR9texyF/ieRjyFh6Zq YYB9uDkr884mGNFmFsgnpPsyDpfSqN8PILiMKGpTOqxBiualOAopmAsd9y5nBubvSfTD22UIKiT 3L4APZ5rA8B4jnar7Hau049r/bIqFCslUq4dmEs3t5Bog+/Tx7rFeZk9eGd/5MX0TpGWHAKy0P9 I7CsFjEE2vbyvmfwA== X-Received: by 2002:a05:600c:8908:b0:48a:7a10:4f17 with SMTP id 5b1f17b1804b1-48e51f21e0cmr94559425e9.6.1778168138248; Thu, 07 May 2026 08:35:38 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e53116a9fsm63026735e9.8.2026.05.07.08.35.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:35:37 -0700 (PDT) Message-ID: <3e306cdc-ebc9-4aa5-b820-d73808072945@linaro.org> Date: Thu, 7 May 2026 17:35:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 04/10] drm/panel/lxd-m9189a: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-4-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-4-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:53, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-lxd-m9189a.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-lxd-m9189a.c b/drivers/gpu/drm/panel/panel-lxd-m9189a.c > index 68019e1e43a96..baaf170779e03 100644 > --- a/drivers/gpu/drm/panel/panel-lxd-m9189a.c > +++ b/drivers/gpu/drm/panel/panel-lxd-m9189a.c > @@ -165,9 +165,12 @@ static int lxd_m9189_probe(struct mipi_dsi_device *dsi) > struct m9189_panel *m9189; > int ret; > > - m9189 = devm_kzalloc(dev, sizeof(*m9189), GFP_KERNEL); > - if (!m9189) > - return -ENOMEM; > + m9189 = devm_drm_panel_alloc(dev, __typeof(*m9189), panel, > + &m9189_panel_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + if (IS_ERR(m9189)) > + return PTR_ERR(m9189); > > m9189->supply = devm_regulator_get(dev, "power"); > if (IS_ERR(m9189->supply)) > @@ -191,8 +194,6 @@ static int lxd_m9189_probe(struct mipi_dsi_device *dsi) > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST; > > - drm_panel_init(&m9189->panel, dev, &m9189_panel_funcs, > - DRM_MODE_CONNECTOR_DSI); > m9189->panel.prepare_prev_first = true; > > ret = drm_panel_of_backlight(&m9189->panel); > Reviewed-by: Neil Armstrong Thanks, Neil