From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB2F6329E5C for ; Tue, 27 Jan 2026 06:12:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769494329; cv=none; b=BBBkAhZOvqSYtXPS4ps0d0HYPYQ86k5KJ3xpRe6aPYaV/c4JLQ/+S5pbKs8g+C8UYFV6fTiVune1SAPmmpbBR6SrtzqXJW/2cedPZ0iRBI+i7km/vZDG3HvPlvySwtCknp7iL5tZXQOofkRry1JTceijrWlK5QtZXDHYTu7nUYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769494329; c=relaxed/simple; bh=cJTtKHdavxmzXsgCYPEa0JmZDtdBVQcCxIpGRpBzASc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FKX0+6kpaEmyPDf4mk5D0MafBheW6ioyI2UiYuF+kb6e54hVB15aH2GJw14nOb8sGrBR4D4l2VZawqqqK3vQphY1swLOW+/R9btBKyaskWcwJ1x6UiuzTvA71v7x42rzx5mCgq8SvA1QJ0dyAR4DSIgXB7uytUwRQiz3buXl2eA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U+uGxUXc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B5VBf3pN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U+uGxUXc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B5VBf3pN" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60R4UFfm3714753 for ; Tue, 27 Jan 2026 06:12:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Gmev3uvCguIZxvsHqRmRj2OkGS4cXvr16nK23VjL4g0=; b=U+uGxUXcRqmCDNZH I6/GdR3OvQFg2RTo3mU5sBJrabaqQ3ac+wBWsyP35sdcXldyFx2IhuOijN9UKQfY vEVJW2zG5lq7qsU07si0k/9aOXDdJQgcn5ZWPd6F/wuhzqPl2LZW3cu98OLR+ocB 5VfEAc1A8XVWCfOuSHMJh9cnRboxF8hi11KEjepbRH9OmDog2PrV/UxYChLEv3c1 kN5AgkqOqIspi3LDNSIpmuTfWKWfiXSeU0xILuI7Xe2StKhFru1qARSpWjrDBqO+ jfVqM0cxXTEhdLLiapv0HL1TqvsVYepT9SPAhKO9JddUlpmWpaqHLvYBOq0WHVdz a0Qi1A== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxdv09pxf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 06:12:06 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c613426e8dcso8245633a12.1 for ; Mon, 26 Jan 2026 22:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769494325; x=1770099125; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gmev3uvCguIZxvsHqRmRj2OkGS4cXvr16nK23VjL4g0=; b=B5VBf3pNdoBz6cW0lKJEoSBDi6JtFoP8qK+3/VvDv0p0n++8+5bMEPuUvm2z1eGNSu eD1HbArFQMHmsZ1Xqov1qZFDgBQzt9PETnQMhC2g1JmT0xOw4n3CJ10odtZKrCa5uRIJ h7LRE9XCnU36oNqiIL/6aGCJYdrhZ2D2fm5xiHl2EtpYEwdthb8hieYpOFN3cilxrojw 5PwI7fWbf1CG2sqg5hhK65DZgEYKYtHXxGHdhGrYaQ5nVXOOWPusxXMEalth+FZtRgcs xyCkPMsWB2KgLzBYJOqqVm0N+0k9VTZY31bQxgmXdqT1Kr8PZRyz1Fa6WBQcIkX3ZSJP nlVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769494326; x=1770099126; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gmev3uvCguIZxvsHqRmRj2OkGS4cXvr16nK23VjL4g0=; b=l9mkhDeesRVfUVaL42RAupg+YxVeLTcwt5KxWdxcUAykEYHvppOgI9Z0+YcKAdA082 6WYVPHNJluyqe7Hd4u788BhAY9GjRAnnJ+EisEvwjaswfcsMFW7Tfp4/T80r0UJE12+c F6ZgyAOsVj3KufzFb7uyYYTLhdUQV/2jTKEEuc+GWmy6lziV+mZxCNvEzcVNnuG+0+IS +ZFmh9dwJZLlV1iaGY3gTPaHfCfRNWhNWNrqCGF1AsQfPXPhNqFYRoN92+bSrgk1XK2b 9uT1yz4iD/PFXqDDAhMuAZ8z71KV4gyXc53oKC3M+EIaVTV4FjQHCmicJBYVV03IjVyv QbqA== X-Forwarded-Encrypted: i=1; AJvYcCWnlFHsR8Ogvys3S7+4KETinIQKxUfSFcY8eZ5IeXlzGvRbkUaAdtF6P1QtqQfAZNeWXdlmP3zmkgoDa1c=@vger.kernel.org X-Gm-Message-State: AOJu0YxJWmZiMj8iX400HhH5Pg9FAwVktpQz/2/s+G8qgKzpj7n5jov8 wTkRIesqbMQxOLxijdXHYR9SemQJ9Sq/5H2q2CcXOg3fDAA6iIFvLq533pgE7248LK95nkjdxf/ oZGpHajdXRJfsrvoGN5L9XAPOhYmTn4jd0S+GLlPGq8ai0XxX4BJnUujxnKJesZEPqn8= X-Gm-Gg: AZuq6aIx7UsR6uyn0TfsXb4K2vKpw69VXAMPTG+kWS/C+NXxl8dCK7CkKSD4G+AZ6cr WfUXDCG1mH1oiSKaXKUwpGFp8IjYMaRcqI8bYudpeS8jMjf1fqAdxDHQEuJKN17In+EFXGd3zSn D6GcrNsHIEJ3oHDfACFsA1UDeE1O9Tyhp66jAYRFgyi2Vu91TGClY9IyTc9KskOQOVCxz2uLzlA zrvfHstgPKmhlqhcOZvcNy0N4O0qp+byUxYrXQ5VqNYID/QnZ8eWSz0z0Nm2VYhPtZe22Q9+2qq 6fXhbFvxNLAasfBR09cDYFaqoTfqNR5XxxGMGIkfFUvBu2cv86/05BC3ukiDzpE9rqpxQVnJQcR coqYTLY2bZ5BPk4kvm51JcUwhlDu6WEIYwB1Lyw== X-Received: by 2002:a05:6a21:b85:b0:364:1361:a8a7 with SMTP id adf61e73a8af0-38ec6246ebemr509947637.10.1769494325513; Mon, 26 Jan 2026 22:12:05 -0800 (PST) X-Received: by 2002:a05:6a21:b85:b0:364:1361:a8a7 with SMTP id adf61e73a8af0-38ec6246ebemr509918637.10.1769494325054; Mon, 26 Jan 2026 22:12:05 -0800 (PST) Received: from [10.217.217.147] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c635a13080bsm9674559a12.2.2026.01.26.22.12.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 22:12:04 -0800 (PST) Message-ID: <3e381303-da09-4224-8929-8f47793d6bae@oss.qualcomm.com> Date: Tue, 27 Jan 2026 11:41:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] clk: qcom: videocc-glymur: Add video clock controller driver for Glymur To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jagadeesh Kona , Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260124-glymur_videocc-v1-0-668f8b9c63be@oss.qualcomm.com> <20260124-glymur_videocc-v1-2-668f8b9c63be@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: s6d-Q-M6Wl1Yw8C7XBz72YXQokgMGEuN X-Authority-Analysis: v=2.4 cv=SvedKfO0 c=1 sm=1 tr=0 ts=69785736 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=-SW487GPSND6qsctmCwA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: s6d-Q-M6Wl1Yw8C7XBz72YXQokgMGEuN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDA0OCBTYWx0ZWRfX069cMsxJTlDD jl3K4ozTmO9URfBdyR2d7xrbOOLSn9HSw3eGIliYV3wANFMPDQ8OVriAcig6Ja0cikld01Dmv9K yyt5LXE7fB37Qw+Ef1vPV5DLx3z937nj7SbW1zQFPS+tH+1D7hdCHX2epHKR/dcO3dqS/B7gQcx Y/wYcXudEDE6xhtGQ5qAxK2iNU3ymKTo8vWil1Nu21VCbzhegehRdIT52ygL8YG9vyIfqiBjuSa k5XRwTUnPKEPgoSKIYRp0nfnXtc1Bf6UjwksLeSC3h8+KcD5E2ZRt5Yls+pf/ZYFmVHuff7BmT1 DpTT+NJxt1WptxA+LPkNdmyT/5x9HCunwxPrccGQ0IXUWQOTPlURxTbc4Z5kksdLqp/2i1bbpTz JqHWqtYDFyfAduDcFiEpnSDjDnowG5RMwRqtSBluFneAU22V3O1/pCQzTriZ65w8/gbTeU38gJC eBGMKRT47lHVmSbW+Rw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-27_01,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270048 On 1/25/2026 1:52 AM, Dmitry Baryshkov wrote: > On Sat, Jan 24, 2026 at 11:05:03PM +0530, Taniya Das wrote: >> Add support for the video clock controller for video clients to be able >> to request for videocc clocks on Glymur platform. >> >> Signed-off-by: Taniya Das >> --- >> drivers/clk/qcom/Kconfig | 9 + >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/gcc-glymur.c | 1 + >> drivers/clk/qcom/videocc-glymur.c | 526 ++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 537 insertions(+) >> >> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig >> index a8a86ea6bb7445e396048a5bba23fce8d719281f..20af4340b08f98773eadcc4a97b1669f51277eb8 100644 >> --- a/drivers/clk/qcom/Kconfig >> +++ b/drivers/clk/qcom/Kconfig >> @@ -46,6 +46,15 @@ config CLK_GLYMUR_TCSRCC >> Support for the TCSR clock controller on GLYMUR devices. >> Say Y if you want to use peripheral devices such as USB/PCIe/EDP. >> >> +config CLK_GLYMUR_VIDEOCC >> + tristate "Glymur Video Clock Controller" >> + depends on ARM64 || COMPILE_TEST >> + select CLK_GLYMUR_GCC >> + help >> + Support for the video clock controller on Glymur devices. >> + Say Y if you want to support video devices and functionality such as >> + video encode and decode. >> + >> config CLK_KAANAPALI_CAMCC >> tristate "Kaanapali Camera Clock Controller" >> depends on ARM64 || COMPILE_TEST >> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile >> index 6b0ad8832b55f1914079f15323b8cdd1608ad4c0..a71dfd0ddf5122d91b5ab4427a9e36cdd57f7bbd 100644 >> --- a/drivers/clk/qcom/Makefile >> +++ b/drivers/clk/qcom/Makefile >> @@ -24,6 +24,7 @@ obj-$(CONFIG_CLK_GFM_LPASS_SM8250) += lpass-gfm-sm8250.o >> obj-$(CONFIG_CLK_GLYMUR_DISPCC) += dispcc-glymur.o >> obj-$(CONFIG_CLK_GLYMUR_GCC) += gcc-glymur.o >> obj-$(CONFIG_CLK_GLYMUR_TCSRCC) += tcsrcc-glymur.o >> +obj-$(CONFIG_CLK_GLYMUR_VIDEOCC) += videocc-glymur.o >> obj-$(CONFIG_CLK_KAANAPALI_CAMCC) += cambistmclkcc-kaanapali.o camcc-kaanapali.o >> obj-$(CONFIG_CLK_KAANAPALI_DISPCC) += dispcc-kaanapali.o >> obj-$(CONFIG_CLK_KAANAPALI_GCC) += gcc-kaanapali.o >> diff --git a/drivers/clk/qcom/gcc-glymur.c b/drivers/clk/qcom/gcc-glymur.c >> index 238e205735ed594618b8526651968a4f73b1104e..cd11470a75f3fec67c1c0cb7fb2b54a814cfaf65 100644 >> --- a/drivers/clk/qcom/gcc-glymur.c >> +++ b/drivers/clk/qcom/gcc-glymur.c >> @@ -8507,6 +8507,7 @@ static const struct qcom_reset_map gcc_glymur_resets[] = { >> [GCC_VIDEO_AXI0_CLK_ARES] = { 0x3201c, 2 }, >> [GCC_VIDEO_AXI1_CLK_ARES] = { 0x32044, 2 }, >> [GCC_VIDEO_BCR] = { 0x32000 }, >> + [GCC_VIDEO_AXI0C_CLK_ARES] = { 0x32030, 2 }, > > Separate commit, description, Fixes, etc. > Sure, will split and add the fixes tag as required in the next patch. >> }; >> >> static const struct clk_rcg_dfs_data gcc_dfs_clocks[] = { >> diff --git a/drivers/clk/qcom/videocc-glymur.c b/drivers/clk/qcom/videocc-glymur.c >> new file mode 100644 >> index 0000000000000000000000000000000000000000..a5045866982554ea46a9d75033537e7771df8fd9 >> --- /dev/null >> +++ b/drivers/clk/qcom/videocc-glymur.c > > This one LGTM. > -- Thanks, Taniya Das