From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "Daniel Golle" <daniel@makrotopia.org>,
netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Russell King" <linux@armlinux.org.uk>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Mark Lee" <Mark-MC.Lee@mediatek.com>,
"John Crispin" <john@phrozen.org>, "Felix Fietkau" <nbd@nbd.name>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>, "Bjørn Mork" <bjorn@mork.no>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Alexander Couzens" <lynxis@fe80.eu>
Subject: Re: [PATCH net-next v13 11/16] net: dsa: mt7530: use external PCS driver
Date: Tue, 14 Mar 2023 23:59:40 +0300 [thread overview]
Message-ID: <3e3e6a1e-61ba-a6e8-5503-258fb8e949bb@arinc9.com> (raw)
In-Reply-To: <20230314195322.tsciinumrxtw64o5@skbuf>
On 14/03/2023 22:53, Vladimir Oltean wrote:
> On Tue, Mar 14, 2023 at 09:21:40PM +0300, Arınç ÜNAL wrote:
>> I was going to send a mail to netdev mailing list to ask for opinions
>> whether we should rename the mt7530 DSA driver to mt753x and rename these
>> functions you mentioned to mt753x so it's crystal clear what code is for
>> what hardware. Now that we glossed over it here, I guess I can ask it here
>> instead.
>
> My 2 cents - make your first 100 useful commits on this driver, which at
> the very least produce a change in the compiled output, and then go on a
> renaming spree as much as you want.
Look, I don't ask for renaming just for the sake of renaming things. I
see a benefit which would make things clearer.
If you rather mean to, know the driver very well, by saying do 100
useful commits on the driver beforehand, that makes sense. But I think
I'm capable of managing this. I've got the time and energy.
Arınç
next prev parent reply other threads:[~2023-03-14 21:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 10:54 [PATCH net-next v13 00/16] net: ethernet: mtk_eth_soc: various enhancements Daniel Golle
2023-03-09 10:54 ` [PATCH net-next v13 01/16] net: ethernet: mtk_eth_soc: add support for MT7981 SoC Daniel Golle
2023-03-09 10:55 ` [PATCH net-next v13 02/16] dt-bindings: net: mediatek,net: add mt7981-eth binding Daniel Golle
2023-03-09 10:55 ` [PATCH net-next v13 03/16] dt-bindings: arm: mediatek: sgmiisys: Convert to DT schema Daniel Golle
2023-03-09 10:55 ` [PATCH net-next v13 04/16] dt-bindings: arm: mediatek: sgmiisys: add MT7981 SoC Daniel Golle
2023-03-09 10:56 ` [PATCH net-next v13 05/16] net: ethernet: mtk_eth_soc: set MDIO bus clock frequency Daniel Golle
2023-03-09 10:56 ` [PATCH net-next v13 06/16] net: ethernet: mtk_eth_soc: reset PCS state Daniel Golle
2023-03-09 10:56 ` [PATCH net-next v13 07/16] net: ethernet: mtk_eth_soc: only write values if needed Daniel Golle
2023-03-09 10:56 ` [PATCH net-next v13 08/16] net: ethernet: mtk_eth_soc: ppe: add support for flow accounting Daniel Golle
2023-03-09 10:57 ` [PATCH net-next v13 09/16] net: pcs: add driver for MediaTek SGMII PCS Daniel Golle
2023-03-09 10:57 ` [PATCH net-next v13 10/16] net: ethernet: mtk_eth_soc: switch to external PCS driver Daniel Golle
2023-03-10 11:10 ` Aw: " Frank Wunderlich
2023-03-09 10:57 ` [PATCH net-next v13 11/16] net: dsa: mt7530: use " Daniel Golle
2023-03-10 11:08 ` Aw: " Frank Wunderlich
2023-03-14 17:16 ` Arınç ÜNAL
2023-03-14 17:45 ` Daniel Golle
2023-03-14 18:21 ` Arınç ÜNAL
2023-03-14 19:53 ` Vladimir Oltean
2023-03-14 20:59 ` Arınç ÜNAL [this message]
2023-03-14 22:34 ` Vladimir Oltean
2023-03-14 23:11 ` Russell King (Oracle)
2023-03-15 9:31 ` Arınç ÜNAL
2023-03-09 10:58 ` [PATCH net-next v13 12/16] net: ethernet: mtk_eth_soc: add MTK_NETSYS_V1 capability bit Daniel Golle
2023-03-09 10:58 ` [PATCH net-next v13 13/16] net: ethernet: mtk_eth_soc: move MAX_DEVS in mtk_soc_data Daniel Golle
2023-03-09 10:58 ` [PATCH net-next v13 14/16] net: ethernet: mtk_eth_soc: rely on num_devs and remove MTK_MAC_COUNT Daniel Golle
2023-03-09 10:58 ` [PATCH net-next v13 15/16] net: ethernet: mtk_eth_soc: add MTK_NETSYS_V3 capability bit Daniel Golle
2023-03-09 10:58 ` [PATCH net-next v13 16/16] net: ethernet: mtk_eth_soc: convert caps in mtk_soc_data struct to u64 Daniel Golle
2023-03-13 23:53 ` Jakub Kicinski
2023-03-13 23:51 ` [PATCH net-next v13 00/16] net: ethernet: mtk_eth_soc: various enhancements Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e3e6a1e-61ba-a6e8-5503-258fb8e949bb@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=Landen.Chao@mediatek.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bjorn@mork.no \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=lynxis@fe80.eu \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®