From: Bart Van Assche <bvanassche@acm.org>
To: Yu Kuai <yukuai1@huaweicloud.com>,
axboe@kernel.dk, akpm@linux-foundation.org, yang.yang@vivo.com,
ming.lei@redhat.com, yukuai3@huawei.com, osandov@fb.com,
paolo.valente@linaro.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH RFC 3/3] lib/sbitmap: fix shallow_depth tag allocation
Date: Mon, 9 Dec 2024 10:11:54 -0800 [thread overview]
Message-ID: <3e401555-e971-44c2-b9a4-5c746baaca8a@acm.org> (raw)
In-Reply-To: <20241209115522.3741093-4-yukuai1@huaweicloud.com>
On 12/9/24 7:55 PM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Currently, shallow_depth is used by bfq, kyber and mq-deadline, they both
> pass in the value for the whole sbitmap, while sbitmap treate the value
> for just one word. Which means, shallow_depth never work as expected,
> and there really is no such functional tests to covert it.
treate -> treats
The above text is incorrect. I have verified that shallow_depth
restricts the queue depth of asynchronous requests for mq-deadline if it
is reduced from its default value. The function dd_word_to_depth() in
mq-deadline converts the value written into the sysfs attribute into a
value that is appropriate for the sbitmap implementation.
That being said, it seems like a good idea to me to modify how the
sbitmap code interprets 'shallow_depth'.
Thanks,
Bart.
next prev parent reply other threads:[~2024-12-09 18:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 11:55 [PATCH RFC 0/3] " Yu Kuai
2024-12-09 11:55 ` [PATCH RFC 1/3] block/mq-deadline: Revert "block/mq-deadline: Fix the tag reservation code" Yu Kuai
2024-12-09 18:02 ` Bart Van Assche
2024-12-10 1:23 ` Yu Kuai
2024-12-10 1:50 ` Yu Kuai
2024-12-10 6:22 ` Yu Kuai
2024-12-10 20:33 ` Bart Van Assche
2024-12-11 2:38 ` Zhiguo Niu
2024-12-11 2:57 ` Yu Kuai
2024-12-11 3:03 ` Zhiguo Niu
2024-12-11 3:00 ` Yu Kuai
2024-12-14 2:44 ` Yu Kuai
2024-12-09 11:55 ` [PATCH RFC 2/3] lib/sbitmap: don't export sbitmap_get_shallow() Yu Kuai
2024-12-09 18:05 ` Bart Van Assche
2024-12-10 2:54 ` Yu Kuai
2024-12-09 11:55 ` [PATCH RFC 3/3] lib/sbitmap: fix shallow_depth tag allocation Yu Kuai
2024-12-09 18:11 ` Bart Van Assche [this message]
2024-12-10 1:28 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e401555-e971-44c2-b9a4-5c746baaca8a@acm.org \
--to=bvanassche@acm.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=paolo.valente@linaro.org \
--cc=yang.yang@vivo.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®