From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D102B23505E for ; Mon, 18 May 2026 08:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779091836; cv=none; b=gIHtDO6YbALxxPO7bYlVRBL3dPJg9/x+jyurbkQxy3LrtXpehpOzKCqBNeDsM9YCUiKDfulsoqQqt5EDhJ9oLLdICoYoc7/LcTagTMFCcqrmx+5Gf+8dF08ndGqP6wRv9Mr0jv+pKpuSvl6thrpIilhkMVckyukmyaoP5QyJNfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779091836; c=relaxed/simple; bh=TypP23aGH9V87ApxQ62dgrSHP9D4WbUjbUT6akzCSrg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m7cTPCpXUr0o4of9RtUazfvN0DvFm3wuVioQCCEwdmAEBbZxZWN9ZPvkg1wLNL/vvMo5xCDXlxRv6nAZ/x3G5pedFaNEB8vVt+UXz5wDYDAO6dYQ8+Cn1EGjIuqWFnSMCX/ol3UTSvyi6uH2YH9CgagoT/ASpzOs9j2UM0vSyPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Igy1keKt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ud+AI2LY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Igy1keKt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ud+AI2LY" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I4tCrG3512430 for ; Mon, 18 May 2026 08:10:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= u16NnZfYSFY4xkfpv5Zf9NfzaJ8H7jvZjFQscSXeWSk=; b=Igy1keKt4o6Utssk BveJW0y7FQVkgiKMTVlHNX/6EWf50fxqbjOVFU4KfWZAcNCKESvv82AX9oVPb/tF Q7wURzp+lr4/av7HG4KoTyGLwsVJWBsI7Z4/8+ZC8N1mmktcD6CXg+t5Tq747f1J FhZ9CvmBz63tPLl57qL4ea9hK2PPauFvPFcZF3K+uWFgckyP+y2qiWLwrEId7cjs avwecQ5xWUx4nQFMhxGSekWuB8dokjI8CrOfG8EOE4W1NmgX86V6SBG3ioBgqLLG iEByiNTTd3UzbJdFOkDwSPZuHnNGiVmhQvNFyuPckzezQlQLPaiP9O9WwidLZz3K 4sUVGw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e6gx6wcfq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 08:10:34 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50e576143baso7125281cf.2 for ; Mon, 18 May 2026 01:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779091833; x=1779696633; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u16NnZfYSFY4xkfpv5Zf9NfzaJ8H7jvZjFQscSXeWSk=; b=Ud+AI2LYymLiUncWTJCdkFtFu3JSh0qj6n+lhEB83fvzLHYRGOnZMz5Cpv+GMjY5bY zRgiV7SAjM66sgCiqWm7Zmhb2W8rZCgRYW+LdQwf4HrsfJ34c64bxCBxw/eYSBiVKpj9 fyfWHaQLBBWeGetdv7sQ7fSKk2px56zaLtqbwkNAr4JSo1n7Iuur3aBOZ34YZ7JH9uDJ zPPpWPFVdIyuJgeXtHDJheBFOIofRlL6CSGLpu+H6eETUQ6IHil5srMXqQSeCxImzVG4 jaST2We1gBfu3+k1M7QKeeIUxC9/2kXUPwt+GjaHan7qmA2gsvDbnCqMj2X5AV+qTkLO 7YCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779091833; x=1779696633; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u16NnZfYSFY4xkfpv5Zf9NfzaJ8H7jvZjFQscSXeWSk=; b=qs1YPnpnGdKZ7T1o7VjWxV03eGtrWbNJDEVDuF7L5U6WKH3X8DhkwwD2P2ubZ/sjwB KUEE0g9blO91IAVn98x0WwI4z6WpWu/wFHAybKuHy3L2t7tKEbWAOSuk3Vy6Kzfk85MV 3Z76iT40WihBMsOtFwC2B08lkeYS+aotrU083zYKcIFJeWG2bG9rG8oWWnCx8SLdnTVw mFs69mNIY+kAETIJWSRPsxzAFcN6ZftxNE6inhm1rbIsHztnlKvk7lMIWbJkzfYBY3FI T9wgbX6QiHXrEjepWUIPaATvanr9yO65SaTHrS7OU1RtSIgIhYoMNjutLU9imGSlTc/Y TIHw== X-Forwarded-Encrypted: i=1; AFNElJ/VGOUSEioiif+JCzsyjHp7HqdZ2HZacky9uxou/bOJBMc1ZTDn+SqMufSj5fQmN83gnNa7NA8WgTbNmRs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyyx3swPhYbaCjwDRqk1XCzAu648+gFuDoK9u2cn3azeC/RFqFi YMP2ZbxK4bG8bSvKmNrT/uSlCobafWWqUIj1iyi9ntwkb53TRy4eg+ji3rPBzE13mICiNaE9V3j xiEJZreeZjymZ4JZyfj6yF6XGvHd7cHwGAVflOgTyLmThY4CpbMlHcDLDk9r6VdP7n9g= X-Gm-Gg: Acq92OFsE+0BVx5YQobD4O30YOH9ktuZiexU5Z+Sd1CSqgXd8K9szSQtLlt/1E9pv1L CqTj+wHHXBinVx45Oo2K8fPGwPEKtRUsduRs0b0oV35Cvwpr9mfpJiALaqUM2FAySnar3N0omz8 jTaWqr/Jj33B36Qxx5PWG66fAMds8hu0c1SPuSM+DaM0RSTK8Ui7gEl6HukZcOEoE5m9xQEExda inAh18Fv30uuakIVLy1VMD7bq8adsVlsecWixVTBrjS7Lzirz8zu5KPD/AugRkirYIoscfj112d ECjIBkAJLmfAfmNm3bYk0O6URqLxI5fmbQVjLvNtD/fXFtNyeZLqpMubMPtvkaZEYi9BIQd+dT0 JIhRouq1zdQW8cZAYw+RWu2MoZqrxXNYifTwkRcL/OQC//cxfQQ5fG3RTQJGgiUuWrp0+5oM0sx f2fH4= X-Received: by 2002:a05:622a:1b05:b0:509:39b5:a977 with SMTP id d75a77b69052e-5165a2030f6mr119721741cf.5.1779091833071; Mon, 18 May 2026 01:10:33 -0700 (PDT) X-Received: by 2002:a05:622a:1b05:b0:509:39b5:a977 with SMTP id d75a77b69052e-5165a2030f6mr119721561cf.5.1779091832587; Mon, 18 May 2026 01:10:32 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68311879413sm5037581a12.25.2026.05.18.01.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 01:10:31 -0700 (PDT) Message-ID: <3e40ef5e-0a8c-40a6-9422-6086be8cde1d@oss.qualcomm.com> Date: Mon, 18 May 2026 10:10:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] drm/msm/a6xx: Enable CLX feature on A840 To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260516-a8xx-clx-support-v1-0-62508bf651ac@oss.qualcomm.com> <20260516-a8xx-clx-support-v1-2-62508bf651ac@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260516-a8xx-clx-support-v1-2-62508bf651ac@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: fEGGJnPjePg7uuU9zm64RLZLPPa_fQyD X-Authority-Analysis: v=2.4 cv=f614wuyM c=1 sm=1 tr=0 ts=6a0ac97a cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=RZPte_UQLmBFeyYnhWcA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: fEGGJnPjePg7uuU9zm64RLZLPPa_fQyD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA3NyBTYWx0ZWRfX98zs7voTBkVi dJufusT7J0jkFueFH0eqb6jI1or9tvOiyzceFRFGitWdaXyvvqFcRcA6fgIzWaDz5y+XNzEyBE8 sNx1Em+VqU0GUqBIDI+IUfcCjjoQAd7Ht6lwFTc0N/Sek4ULVyAgRTWATl0gL0lEvk/4/yPw9sI 317TZJmTJnvz1kVOjlkfas/Pfp9U8LGWMYDNDRTMTXv9yg/bO547H4EQwRzhd1ASeMYJHrJH+Th U96sTHL6rsNTDYOUaHTpzALzgRXsMGMRShoUYxyhBZd7Xn9hYqO8zoUVH/ggGzow9wHOYqJ0i0N LOzHOdd/GjTms51nw9qbzc37AqUvjdcT54+vjAp4025tIu/mAI8wHJkIl9dc3bq3PI4oYAUtzJc DaFEjHrjj3Ug6sApMEKph2QOVms2pNXBGSrDV6m11BDzD/2M1LhjhRyFrURBGBlmawzB0gAkyDV n9uvKn8XB1mIuvctoJw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180077 On 5/15/26 10:07 PM, Akhil P Oommen wrote: > Add the A840 CLX domain table and the IFF/PCLX limits table to the > catalog. With the HFI plumbing in place, this enables the Current Limit > Extension (CLX) feature on Adreno 840. > > Signed-off-by: Akhil P Oommen > --- > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 86 +++++++++++++++++++++++++++++++ > 1 file changed, 86 insertions(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c > index 550ff3a9b82e..c503912a61c7 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c > @@ -2108,6 +2108,90 @@ static const struct adreno_reglist_pipe a840_dyn_pwrup_reglist_regs[] = { > }; > DECLARE_ADRENO_REGLIST_PIPE_LIST(a840_dyn_pwrup_reglist); > > +static const struct a6xx_hfi_clx_table_v2_cmd a840_clx_tbl = { > + .version = (2 << 16) | 1, Is that major/minor or major=2 minor=0 patch=1? Please add a define otherwise Reviewed-by: Konrad Dybcio Konrad