From: Paolo Bonzini <pbonzini@redhat.com>
To: Liang Li <liang.z.li@intel.com>, mst@redhat.com
Cc: linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org,
akpm@linux-foundation.org, dgilbert@redhat.com,
amit.shah@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process
Date: Fri, 20 May 2016 13:19:51 +0200 [thread overview]
Message-ID: <3e47bf87-3e9d-f836-021b-8a90919f9002@redhat.com> (raw)
In-Reply-To: <1463738386-30868-1-git-send-email-liang.z.li@intel.com>
On 20/05/2016 11:59, Liang Li wrote:
> +
> + sg_init_table(sg, 5);
> + sg_set_buf(&sg[0], &flags, sizeof(flags));
> + sg_set_buf(&sg[1], &start_pfn, sizeof(start_pfn));
> + sg_set_buf(&sg[2], &page_shift, sizeof(page_shift));
> + sg_set_buf(&sg[3], &bmap_len, sizeof(bmap_len));
These four should probably be placed in a single struct and therefore a
single sg entry. It might even be faster to place it together with the
bitmap, thus avoiding the use of indirect descriptors.
You should also test ballooning of a 64GB guest after filling in the
page cache, not just ballooning of a freshly booted 4GB guest. This
will give you a much more sparse bitmap. Still, the improvement in
sending PFNs to the host are impressive.
Thanks,
Paolo
> + sg_set_buf(&sg[4], vb->page_bitmap +
> + (start_pfn / BITS_PER_LONG), bmap_len);
> + virtqueue_add_outbuf(vq, sg, 5, vb, GFP_KERNEL);
next prev parent reply other threads:[~2016-05-20 11:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 9:59 Liang Li
2016-05-20 10:32 ` Cornelia Huck
2016-05-24 7:48 ` Li, Liang Z
2016-05-20 11:19 ` Paolo Bonzini [this message]
2016-05-24 7:51 ` Li, Liang Z
2016-05-20 12:00 ` Michael S. Tsirkin
2016-05-24 9:51 ` Li, Liang Z
2016-05-24 9:55 ` Li, Liang Z
2016-05-24 10:08 ` Michael S. Tsirkin
2016-05-24 10:38 ` Li, Liang Z
2016-05-24 11:11 ` Michael S. Tsirkin
2016-05-24 14:36 ` Li, Liang Z
2016-05-24 15:12 ` Michael S. Tsirkin
2016-05-25 0:52 ` Li, Liang Z
2016-05-25 1:00 ` Li, Liang Z
2016-05-25 8:35 ` Michael S. Tsirkin
2016-05-25 8:48 ` Li, Liang Z
2016-05-25 8:57 ` Michael S. Tsirkin
2016-05-25 9:28 ` Li, Liang Z
2016-05-25 9:40 ` Michael S. Tsirkin
2016-05-25 10:10 ` Li, Liang Z
2016-05-25 10:37 ` Michael S. Tsirkin
2016-05-25 14:29 ` Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e47bf87-3e9d-f836-021b-8a90919f9002@redhat.com \
--to=pbonzini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liang.z.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®