From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: power: supply: Document Mitsumi MM8013 fuel gauge
Date: Thu, 22 Jun 2023 08:24:01 +0200 [thread overview]
Message-ID: <3e4840e0-adb6-010b-8186-0b3e38b4a374@linaro.org> (raw)
In-Reply-To: <dc5ffed0-555b-18e5-cf96-d6a4263357af@linaro.org>
On 22/06/2023 02:51, Konrad Dybcio wrote:
> On 21.06.2023 18:38, Krzysztof Kozlowski wrote:
>> On 21/06/2023 17:39, Konrad Dybcio wrote:
>>> The Mitsumie MM8013 is an I2C fuel gauge for Li-Ion cells. The partial
>>
>> Mitsumi
...
>>
>>
>> I think you miss several properties: three power supplies (although not
>> all might be needed) and most likely monitored-battery. One regulator
>> output and output GPIO probably can be skipped.
> Looking at the example circuit, it seems like the chip's power lines are
> hardwired to the battery cell.
>
> monitored-battery does not seem useful today, as we don't have any
> information about writing values onto the chip :/ And I'm not w
OK. With the typo in commit msg:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-22 6:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:39 [PATCH 0/3] MM8013 fg driver Konrad Dybcio
2023-06-21 15:39 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Mitsumi Electric Co., Ltd Konrad Dybcio
2023-06-21 16:32 ` Krzysztof Kozlowski
2023-06-21 15:39 ` [PATCH 2/3] dt-bindings: power: supply: Document Mitsumi MM8013 fuel gauge Konrad Dybcio
2023-06-21 16:38 ` Krzysztof Kozlowski
2023-06-22 0:51 ` Konrad Dybcio
2023-06-22 6:24 ` Krzysztof Kozlowski [this message]
2023-06-21 15:39 ` [PATCH 3/3] power: supply: Introduce MM8013 fuel gauge driver Konrad Dybcio
2023-06-21 16:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e4840e0-adb6-010b-8186-0b3e38b4a374@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®