From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43422C6778F for ; Thu, 26 Jul 2018 04:56:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF5DF20846 for ; Thu, 26 Jul 2018 04:56:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="IyJ8o/lY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF5DF20846 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728905AbeGZGLd (ORCPT ); Thu, 26 Jul 2018 02:11:33 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:51528 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728593AbeGZGLc (ORCPT ); Thu, 26 Jul 2018 02:11:32 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w6Q4t5pl080985; Thu, 26 Jul 2018 04:56:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=hejV6Njn6HII2+a4aAILn0fQU/lTZ1vF4MZ+wwktmb0=; b=IyJ8o/lYY0iU4jqI89UATZAIpvsZ9MJLTvA23coa2fml28onmNUOUJwD2JYFry188fXf 7FJRoH2EKJ47S3+o4PdGZa6K1CBzW4Yd311Ry4jTL8bgwzy21vp61Ma+SgmiD+7FBLLg lxj8BQWT9+C/hb5ETF1Yz/NnPeRnfOvllt4rK/tMTtIp3OKZM79qak9MrAhGFa7OzCNM OaydktIpEyQiftDNFfrJksxvW0UbhonCGGRLdSgvB2Cus+eAlaft7Lsjj0Lrq3nGzSeW nJyXXBTJRwxj5F8wRzaMy6SpGKPvvMDm1DuNWNkPoXh62jx/EXsNYM6OGy4QqsLp3XM2 WQ== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2kbvsp1bh6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Jul 2018 04:56:29 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w6Q4uS19029158 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Jul 2018 04:56:28 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w6Q4uS18023396; Thu, 26 Jul 2018 04:56:28 GMT Received: from [10.159.211.29] (/10.159.211.29) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 25 Jul 2018 21:56:27 -0700 Subject: Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6 To: Santosh Shilimkar , Anders Roxell Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org References: <20180725222008.32186-1-anders.roxell@linaro.org> From: Ka-Cheong Poon Organization: Oracle Corporation Message-ID: <3e4b4c29-40f8-211b-62e3-c9411b2c0013@oracle.com> Date: Thu, 26 Jul 2018 12:56:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8965 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807260051 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/26/2018 06:36 AM, Santosh Shilimkar wrote: > On 7/25/2018 3:20 PM, Anders Roxell wrote: >> Build error, implicit declaration of function __inet6_ehashfn shows up >> When RDS is enabled but not IPV6. >> net/rds/connection.c: In function ‘rds_conn_bucket’: >> net/rds/connection.c:67:9: error: implicit declaration of function >> ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’? >> [-Werror=implicit-function-declaration] >>    hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret); >>           ^~~~~~~~~~~~~~~ >>           __inet_ehashfn >> >> Current code adds IPV6 as a depends on in config RDS. >> >> Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation >> to struct in6_addr") >> Signed-off-by: Anders Roxell >> --- >>   net/rds/Kconfig | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/rds/Kconfig b/net/rds/Kconfig >> index 41f75563b54b..607128f10bcd 100644 >> --- a/net/rds/Kconfig >> +++ b/net/rds/Kconfig >> @@ -1,7 +1,7 @@ >>   config RDS >>       tristate "The RDS Protocol" >> -    depends on INET >> +    depends on INET && CONFIG_IPV6 > This should build without CONFIG_IPV6 too. > > Hi Ka-cheong, > Can you please loot at it ? I know you modified > lookup function to take always in6_addr now, but > probably hashing with '__inet_ehashfn' should > work too for non IPV6 address(s). I guess for now, let's add this dependency first. I will do a follow up patch to remove this dependency. Thanks. -- K. Poon ka-cheong.poon@oracle.com