From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C4B72DEA76 for ; Mon, 13 Oct 2025 09:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760347533; cv=none; b=aopw8oopz0V8p3GI7/VxVZxLjUwRlg0FT8vDFIP5gN/9FFSqrRKrtAil+ZEhvvfY4rR4Xjsj72ouAjJCykY8yRJZBNUAZaAAmAGksNnX/tfVnDg6hUieFFEyVclSjDcQrC78UYlizr4AOCTov6/xHN40CzUvOWz3O9nYdkS3DC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760347533; c=relaxed/simple; bh=Ob2d9io577xcnAqVuhKaNBwuYz2xbznkyYqNTpDewf4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YyEpKPAGv27a0Y9Z5khu9y7IDbUK4s5X24m5EJRAiKDO9g2kw8F+tQzYZ6EYWKhdyd/OhuCJIrhzm014SXsJy8Yw4A2efLtf7vS3BItCSBTrevEoio12xkSZniNy7cNORo1dDrmoaUqjvgrYx2pSoiTJTpXHsEAjmhkcWlbm2Cg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=S0ij7b++; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S0ij7b++" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760347530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=45f1b0mXkQ/bXJiKQOO3KwWzxkP9Zc+3arM6UV73Zeg=; b=S0ij7b++GrKYD/OFjigALGJzqK52R9uGwGYNTz7rBXNLEqV4wYFqKexkuMaIkoQVg9Mg24 lany2uy4H6B7imPvaiGyGDTIQtIjVgS8iWaj/DtbEmohE+eHSZEGaLTqkxWX8HtcQT3SdV /2kU6ESYtqlvXsSs/V4tfTxRrCM3eC4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-gtK1NNtLPauBOCrwBTLrIw-1; Mon, 13 Oct 2025 05:25:28 -0400 X-MC-Unique: gtK1NNtLPauBOCrwBTLrIw-1 X-Mimecast-MFC-AGG-ID: gtK1NNtLPauBOCrwBTLrIw_1760347527 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3ece0fd841cso3248251f8f.0 for ; Mon, 13 Oct 2025 02:25:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760347527; x=1760952327; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=45f1b0mXkQ/bXJiKQOO3KwWzxkP9Zc+3arM6UV73Zeg=; b=dRGixa3NYqiOvmA4/X3LXmwGIfQnkrGa4s06LdbTPLr9KmefG49ZZsYDDUQHlmQJVf Z8Z4KQyFsiHCUgYzZIE85tXHgsj9nAEsEnz1oUMj5mCXyCK8Y6hA94kM6NXNlVGqF1JL 4RvNt7ihKr1O1Lr3L0TdACtXpKV/cHsASku/8bZ58CVeQvW0gJrVvu5pWDLqsftOyLSu nfJURtNBHL7JpNNPEmIxNMQG4If+unDuAp96uGlFakr0MGFzCSTFXTKgorVbHLo4iQd7 8Tybs+QFuSzfhsLU/9yh0bZxTo4QmsH8E94kJePHZ88FdQfK/y5pIDtDFCp1ka7vIGdM qTNQ== X-Forwarded-Encrypted: i=1; AJvYcCXQsKy1NP1frPKDXh5d8CA7EzZETaD3ARGJQzTBIqBQigihZcrGZViBrEHEVyfl1b02DcOBHdrK630QmTI=@vger.kernel.org X-Gm-Message-State: AOJu0YwpiPTFUEGluV/+u+V0M7j8yjuqBCehNu3qBr1EzrtObwN7EGm/ 83CxwxaaYMGoqNnsptwKGtU+Hns/Oc8yiCfdBBcYuBK2RqN8K6yMntTX4OejwtWnJ2pnmgaHe4D IvOC8Bus4kMv4OaPDNR12Mev1KniNuGFJ+QVZmTjHl2Uk/dx/NAZuj6sP95MdTKSp1g== X-Gm-Gg: ASbGncshMA8K7l4FgT3DUOulF/cXjZqFKxhwNph/FqwfWLSlEJimvI6j13Anx5/OOAf zz5zc0knHn/mBUg6gnAF2lOSggad2wWgrV+gzvQr8AsVkVj161bz5b/w0A2MeP88wyme4g26qB9 41AB3ujOM5LNZMrlNTsj2rMpAU+qQtIY7tyrV4O8KFOWafNEyFAS1rMhzkmbjd8tNdnYDLPoN6x UMHoi7BxijM0PY0H1ZJ1PGRVXwfRmb0liEdJYnCyiwnD/DQ6q7EaZWIiUzy8iYTS5ae1Ms+HOGQ tJFhkelcF0dp4hry0c4cqqKEwfuRBqadv6B/dgB7HpJSyVbirT9lvMiCFtflbpuBoThNksfAXz1 B+rs= X-Received: by 2002:a5d:5f54:0:b0:3ee:1586:6c73 with SMTP id ffacd0b85a97d-42667177de1mr12847264f8f.19.1760347527116; Mon, 13 Oct 2025 02:25:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFYg9XjYPSU7V3J15wqS0ZRoHv9WaUOniN3wcI031rVOGGwlPRCDH+RKYRnwAJfJ5gFX+HfUg== X-Received: by 2002:a5d:5f54:0:b0:3ee:1586:6c73 with SMTP id ffacd0b85a97d-42667177de1mr12847240f8f.19.1760347526728; Mon, 13 Oct 2025 02:25:26 -0700 (PDT) Received: from [192.168.3.141] (tmo-083-189.customers.d1-online.com. [80.187.83.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fb492e6ddsm194397015e9.0.2025.10.13.02.25.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Oct 2025 02:25:26 -0700 (PDT) Message-ID: <3e6500dc-723f-4682-9e37-b28bc78a2bdb@redhat.com> Date: Mon, 13 Oct 2025 11:25:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/1] mm/ksm: Add recovery mechanism for memory failures To: Lance Yang Cc: Longlong Xia , nao.horiguchi@gmail.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, xu.xin16@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Longlong Xia , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, Miaohe Lin , qiuxu.zhuo@intel.com References: <20251009070045.2011920-1-xialonglong2025@163.com> <20251009070045.2011920-2-xialonglong2025@163.com> <55370eb6-9798-0f46-2301-d5f66528411b@huawei.com> <077882e3-f69f-44f3-aa74-b325721beb42@linux.dev> <839b72b8-55dc-4f4e-b1da-6f24ecf9446f@huawei.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13.10.25 11:15, Lance Yang wrote: > @David > > Cc: MM CORE folks > > On 2025/10/13 12:42, Lance Yang wrote: > [...] > > Cool. Hardware error injection with EINJ was the way to go! > > I just ran some tests on the shared zero page (both regular and huge), and > found a tricky behavior: > > 1) When a hardware error is injected into the zeropage, the process that > attempts to read from a mapping backed by it is correctly killed with a > SIGBUS. > > 2) However, even after the error is detected, the kernel continues to > install > the known-poisoned zeropage for new anonymous mappings ... > > > For the shared zeropage: > ``` > [Mon Oct 13 16:29:02 2025] mce: Uncorrected hardware memory error in > user-access at 29b8cf5000 > [Mon Oct 13 16:29:02 2025] Memory failure: 0x29b8cf5: Sending SIGBUS to > read_zeropage:13767 due to hardware memory corruption > [Mon Oct 13 16:29:02 2025] Memory failure: 0x29b8cf5: recovery action > for already poisoned page: Failed > ``` > And for the shared huge zeropage: > ``` > [Mon Oct 13 16:35:34 2025] mce: Uncorrected hardware memory error in > user-access at 1e1e00000 > [Mon Oct 13 16:35:34 2025] Memory failure: 0x1e1e00: Sending SIGBUS to > read_huge_zerop:13891 due to hardware memory corruption > [Mon Oct 13 16:35:34 2025] Memory failure: 0x1e1e00: recovery action for > already poisoned page: Failed > ``` > > Since we've identified an uncorrectable hardware error on such a critical, > singleton page, should we be doing something more? I mean, regarding the shared zeropage, we could try walking all page tables of all processes and replace it be a fresh shared zeropage. But then, the page might also be used for other things (I/O etc), the shared zeropage is allocated by the architecture, we'd have to make is_zero_pfn() succeed on the old+new page etc ... So a lot of work for little benefit I guess? The question is how often we would see that in practice. I'd assume we'd see it happen on random kernel memory more frequently where we can really just bring down the whole machine. -- Cheers David / dhildenb