From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C423EC43441 for ; Mon, 19 Nov 2018 07:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E28C2086A for ; Mon, 19 Nov 2018 07:33:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="AMtApCI/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E28C2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726450AbeKSRzq (ORCPT ); Mon, 19 Nov 2018 12:55:46 -0500 Received: from mail-eopbgr720052.outbound.protection.outlook.com ([40.107.72.52]:3086 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726240AbeKSRzq (ORCPT ); Mon, 19 Nov 2018 12:55:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SSUACHOS5HTT+JIIkUvfSS0KW6gmHu30aTpX52U9Bi0=; b=AMtApCI/0X9MCThE8jI92L1c4G+XQ5nPULYRpRXqvlVbskuBwSHSN5v6Z5mGvP/Bp1qQa3YU4EfKHufssAnQE8HVkLi7mWUAljgIjqbQ+9z6N0iZIsubeuQoFXz6+8rHfm8NFTXJUTQfaApRUF5B4qlMnthij5uJznlVeX/idzI= Received: from BN6PR02CA0033.namprd02.prod.outlook.com (2603:10b6:404:5f::19) by SN4PR0201MB3519.namprd02.prod.outlook.com (2603:10b6:803:44::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.30; Mon, 19 Nov 2018 07:32:55 +0000 Received: from CY1NAM02FT010.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::205) by BN6PR02CA0033.outlook.office365.com (2603:10b6:404:5f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1339.23 via Frontend Transport; Mon, 19 Nov 2018 07:32:55 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT010.mail.protection.outlook.com (10.152.75.50) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.1339.15 via Frontend Transport; Mon, 19 Nov 2018 07:32:54 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:44301 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1gOe3B-0004KI-V0; Sun, 18 Nov 2018 23:32:53 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1gOe36-0006Bg-Rl; Sun, 18 Nov 2018 23:32:48 -0800 Received: from [172.30.17.111] by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1gOe2w-00069F-3D; Sun, 18 Nov 2018 23:32:38 -0800 Subject: Re: [PATCH] pinctrl: zynq: Use define directive for PIN_CONFIG_IO_STANDARD To: Nathan Chancellor , Michal Simek CC: Nick Desaulniers , Linus Walleij , , Linux ARM , LKML References: <20181101005724.9622-1-natechancellor@gmail.com> <68ae935a-aec3-915c-bfe6-d69bfb93d702@xilinx.com> <20181107085503.GA31517@flashbox> <9d52cd84-440f-9a40-d0ec-1397abb24c98@xilinx.com> <20181108150116.GA2830@flashbox> <40a17c3e-6c81-6f59-cff6-003a91e10b29@xilinx.com> <20181109153626.GA6494@flashbox> <20181117015651.GA28503@flashbox> From: Michal Simek Message-ID: <3e65ea20-f850-b66c-b4f8-0a846d4317cc@xilinx.com> Date: Mon, 19 Nov 2018 08:32:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181117015651.GA28503@flashbox> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(396003)(376002)(39860400002)(346002)(2980300002)(438002)(189003)(199004)(8936002)(53546011)(65806001)(47776003)(81166006)(81156014)(65956001)(106466001)(336012)(36756003)(93886005)(478600001)(36386004)(26005)(305945005)(186003)(63266004)(77096007)(575784001)(31696002)(64126003)(230700001)(8676002)(50466002)(31686004)(966005)(476003)(6306002)(126002)(229853002)(76176011)(356004)(2906002)(23676004)(106002)(14444005)(6246003)(2486003)(110136005)(486006)(44832011)(5660300001)(316002)(426003)(65826007)(54906003)(9786002)(11346002)(446003)(4326008)(39060400002)(58126008)(2616005)(2004002)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN4PR0201MB3519;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;LANG:en;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT010;1:knYfr9kZhBfTsDGI07o3+zV5Fx6Aqo8KfsEbnn4xeizLn6o6bS3W+xaRDpInEfMrkKVjZ6CA6TpvVNovp/5UfiID2IK0vGDel2nI774qS7mUlRTSGg6QFnYkrbAZyyDX X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f3915833-7ded-4603-6740-08d64df13873 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:SN4PR0201MB3519; X-Microsoft-Exchange-Diagnostics: 1;SN4PR0201MB3519;3:n1/ujFuvk9xnGa5vHTQHP5uSXHkaY20rFXb2Zd/7x7pT8TD2p/N68nADOmWoLvWcDli0N9UpIxZ7DwL3jzZKK/Mji8VC0PW+/8xOarp9ez9M/vvvnOsi/FYHDZnro1auU7NxBkTk6R2ds6VZEJpfAz+gsE2oVVqNEzICRScMWrPEnx9qSbiUDxdEAWgWpz7YrC0X8WmVfhT5ulmyTZI4Vsa7bvNxt+CjsFBthDitO2WDVorJyXlI+JotH9SbKXF+CXKuuPEBjLt/CuD+auT2AClcR8VZuaGr8xk7IINuPPhDk5XdZF+COk2SvbnlD4xERjFkDWoaSrm/Yg7ECSWvV39eCL8Pc/Z5Jg1+WDZjv6I=;25:9BWot2QyMFhhJICzTuJro3iLmHWi3PmJI6zYetGDXmlWmXdRGluklR1alonL689KOegzvrBpoc7pwiszBPkoPYdiWwTWvBKmcqzcwOweEuODsLsZ5j8Yb2mzV6FLtUzzwqs4DXXuh74yxG3fvVDcwqPXwNFdlrVAQrb3BXEo/JZnxYPqCtKW8W8tVxN6gAnNXBh+HQFGdEge+OG7eOCGLN0Tn7YHbe60vzlw69Fv+e7LtyqlXF6AAoe3B3VnKz6ptk01bHU/aoMKr2w5y3x+Wh6TprFGPJkKfmhgjCddxYw3o96Npieb4GUNXhFY27+hvhqaxyHiaoF+RCc3zD29sg== X-MS-TrafficTypeDiagnostic: SN4PR0201MB3519: X-Microsoft-Exchange-Diagnostics: 1;SN4PR0201MB3519;31:zH+hz8xxgbkUcelO+bCIutqvIKTJpGxAfqxvwyJY233feUzJyEUM54ntZotB2QRnVz43h53kX2QY8lEyCKzpniFBBeb1dg2Rr6izMxQrvwB2qd8fXNLRl8qpi4vj7IfucMve2EWW68k+rh/ScJPNwa4RYmjILudMsxmF4TOmA/283ev3R9Hvc2l/68MauVgZlT80Lgpcn6D1X4gvlX0vuFc41liesjnF7fL0mM8qwmU=;20:uBAIFMjQPSS3fq+kWSiyALgZtYZEoQ4EnokZluhZh7AcKn5Q1EGVkyjWF85YQe46sdoWA7Qs359aLx6FuqVVZUN7b8OYxDoL5AodhpkuBN/UUBloprxZU185KQDeL27LDfc2w2jbCSRUwTCbalbRqhoA5K6CcGjokLMCuxEyCrdoyZzayLgJW3I/xGO8LpVtLaZp3NoMw+C2nWqpahyrGfh+BmGZfRfAPXlPQlVCbvpUyzFfJ9NXzALRcKGrYGRqPWAJOjo1Jzrado0P5McBffDjFmHYBqbvQFjeLhoUSV4nCoIHQ2AWKbjWuMwUpZoJTkYaewaFr+gwYYZGrRjPG6W/OYjc3YelH+iyytDb4lszC+8L13La6YWjZqlIIrfB4dhkHO7y1VmLXNOn6JwSIyKgpajFsjkvMZFKBZUUFPgk2TsYbpyeZcHKeWsnfjP+klqxWYpm1/IRMvdtZfCVsCBy+ELzO1CL0U8F2EobaFjikXeRidRiA7yCqEPv2aKU X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592)(84791874153150)(262104967686372)(166708455590820); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93004095)(10201501046)(3002001)(3231415)(944501410)(4982022)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095);SRVR:SN4PR0201MB3519;BCL:0;PCL:0;RULEID:;SRVR:SN4PR0201MB3519; X-Microsoft-Exchange-Diagnostics: 1;SN4PR0201MB3519;4:RByKhmaKfJcawLZB7sGIqRXAhoBcIaCh9YIuFO44SJO0gWp8aD0E62pQEOu5rhuT3p+uN/XjcArxvEBXI2gelMUmsegwNB++RKecVzTbi8tAnVM+dyHtXXzAy9pqeGjMKL3frtMbFCTbmRiW5IdqXF4vu7r/3yhVduETE+7DASgJxPiR+FUdIqgNXx6T4343GiUL/qrd2/lPo0ITE+9bNh/RsvhNNSsVyrJFq/0XpTULEv902o4PpR+vDlAMb+cZaFqvfr0KYbQ6Y1qgOSe64yqUO9FElIdazd3wKpXBzoKZGmtRXoExoJQTeDAutLw7xdqIPltuzTZ9uG9ZmpvxkL/yCNYUUIpSvBdv7OoYxF0H0idh6PqPQDLZiFBRJAClRLxLyUYUrmfpmbeGgqV0wgfFuYvLNFiD7cs2MswMc4Q= X-Forefront-PRVS: 08617F610C X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjRQUjAyMDFNQjM1MTk7MjM6RTZrZ0NRTHBOTTdleGo1a082NmdRNXNr?= =?utf-8?B?cHk4am92WWFrQTlTU3lDZDI5OUZpK3dacUZKcWRiTVZ6TFN1Z0R3Z2drM1g2?= =?utf-8?B?N1AvZ2w4ckpkSm50YlpBVEJ4dzdreWExS0N6eVFsaGoycHloVnZwdjBNRGtQ?= =?utf-8?B?aUNZVk9WQmlKY3U2SlNadmtLbis2dVNUVkg2MDdsU0ZwYW5YbUhUbUhybXlr?= =?utf-8?B?WllvdzQ5a3hHVnhld09IQ1g5TUV0bGhibWN2VHM0K29YYlFpVURwMVl3NTNu?= =?utf-8?B?UjZpM1dBVkJrT1Nsa2s2WUlEOWZlWThoWnlWTEJkcHZlVHRQK1Q1QXhONVN3?= =?utf-8?B?ZXIvNTZPZFVzR3NsSWtTbkwwY3N5Z09FeUNDbFF1UFNXTXBCUW9PcXZZZjlv?= =?utf-8?B?eTlLTVZrS1hlSUxtRm5Jd1FJZHlTejRlVUR1NkpKMjRoalZYd2hXZGVvbStZ?= =?utf-8?B?eTBpSDYzNndiUDB3ZnhBQVBaUk5PMFpTV00yREtqZGY4a1FUS3dTS0hOT29G?= =?utf-8?B?S0Z4MzZzSkJyWHkzdWVVZSs0ODZkYnFhQVlobHcxZXd3UnZzRkh5SEFZMTZt?= =?utf-8?B?bEVRS2FkUjU4cm5kZW1teGY0RkJwbmlRRmptOGwrdE9XaCtaKzZlVHArWTJy?= =?utf-8?B?NXA1QXp2SWZ2OGk4ZEdRY2ZVSmdVeG1rb1ErdzlVZ0gxeGMxSnVSZ0h2b1Rm?= =?utf-8?B?azdoUndVTWVFeHVodGJ4V2syUmdaUUo5NkRmNE1nOVFTKy9qTkFaaE8rUUwx?= =?utf-8?B?YmVwdEc2WE5rWHJWRHZ5MjMyVWltK0xJL3J6R0FmMVJHR0Racjl2ZEpqTEU4?= =?utf-8?B?ZFFkV3hwcnQrYW0rcXl3S0EzSW5FZXJxYzlKUjd5bjVaUHJDRmFsRktLOVhR?= =?utf-8?B?S1E5ajcxN1hYTlg1Q0ZTTUdkMnc1YS9YbHVCdXRCcFcyaExWallwbXF6dmZv?= =?utf-8?B?bGEyRTZubTZvOHJNbDZUYTQyVVRlZlpiVXVlOHZiaDJjeVlLeU85VEFCREZD?= =?utf-8?B?bXFKVzNtaDdsQ0V6SU0ydyt4L3VuTXNsTVZnWHpTTXNKdGkrQ1dUM3NGcmk2?= =?utf-8?B?Rmw2djlwNTZnT2pZenNLRXB6T1ZGM3p4dXQxbkZNWngxVVhuUTZubU5vaTBs?= =?utf-8?B?TEhaZmRPL0FrS1RTcXE5VmNvWkZGcVByVnNHZC9lTmZxclRLTWtHR3RnNkRh?= =?utf-8?B?QnltZ2VRR3BlODlDTm16RUVkcHZpTUowK2hrWUQ5blRLY05PSUczSGNIK3gw?= =?utf-8?B?RmlUMEJXL0FIQlJ4Qkl4L1dwRm9ReEhLN3ljSE8rQlZWRU81dWE4M3h6Rkpx?= =?utf-8?B?eDFOT3BOWHFieGd6VW1wa3doMmFZRnJDMmtwMnB6dllacG9kWFNaYjRGajNO?= =?utf-8?B?WFpVcnBvcmRaZUF1Znhka0xZaG5HenlWMUxtbGdpSFp3bVpZYzhYYS9YT3NT?= =?utf-8?B?aDdQOGlKaDRjaGplczlxSWpTMldvclFrRkk2Z1pMYkJLNnIvd05DSStoNUl2?= =?utf-8?B?RmpubEQzRkF4bjU1dEdPbUdUT0pVV3dzWlR2d3VmU1liMEY0ODFvYmVZQ0Ev?= =?utf-8?B?RmpnbmZqdmwrTXlDdEhnblo3amJRQmhlbzc3M2VDTnFPQ1k2bjhpb2k1eEJx?= =?utf-8?B?dUFTd044eVQ0MXFPc3IzdGR5WWtmUXhmUXVUMjViWnp3U1RRTFpvbzlseUVK?= =?utf-8?B?M3gzcTg0dGRuRnBiZlg4SVFoVzJ5aGtSRyt6NklCOTRFZlpHWmtyUk9RK2lt?= =?utf-8?B?U0JYTWtwTHA2dEVCN285L1REdmdIVmFwMFlhbG5DQitqKzRLWHpUVmp3Rmg1?= =?utf-8?B?N0ZKYU4xOFdISEYvY3RWMWd6VGtnR05jVlNPa0IydXlWOG9BODVkM1hNWEdM?= =?utf-8?B?aXhFbGRaYzZaaGgrR2lIMHp2Tlk4VHdzelkxL09KZnM5eUFYUm5YR0dSSytG?= =?utf-8?Q?pCWNuULvnMw1cgZu35SjOqI8e7EVZE+I=3D?= X-Microsoft-Antispam-Message-Info: 6APWM6Em/p25v6728nKcoDsv/MA3c6PVj6MFKDCcimObebEoMo4slA/QmPF3lvaufG6vMVteZz3xk0HsvYyvfI0TF/Ky7oT8Vcn4qRPwax5JRnodjPh8HvF/esijlKDE69lOuxrWXWPSbub8oKVFiebSHv9/7mKO/wvlAJX8Q2Y7o7XhBWfp5fW0DOkRMb36FRPuJJWErXYrmREFLvEiHBnvOqqeIZyT5mh6WJFfLnbzBU2ZP4DPUN3ivxqg6AREn9ruhMrEEceCTMey5ydPBsWhhyV34ntJumok45rLq+C0wo/bX9cOruU4SP+HtX/ZvWypAHcFQhworrR2LQdlUh3+Qs+XtlkmdiyK0odKarY= X-Microsoft-Exchange-Diagnostics: 1;SN4PR0201MB3519;6:dgIdfO/ysnHexmsrP5sg+eCsWRrXJhjcRwpTIkVLlQILJ4pBSye6YjTWMGaS2aesk4Xb3tFSjHFrMHuWQtMi8NzDMWGKGtnbx4F91rLHfUQiuEjLO9K7csFzbH2cEbyJWI6oiKZfBoxMRXDCLRzLoKGKpZqWOqPTheYjaPNd0bBSQmVEhKAsyvmBWLVopAV1Y+61RmiwK+P4/4G4fh2qZ86wjDWN3+YNynLp2s0GbTZBC8+utcYlNGmYoW7At8zQwHAvmA9maOgjXP1llhHsU0mj2VbaIymPWTNMHYF+vtkkLx3EjRJBZPFhEu0DI3C2LpaCtnFnx7lhf20Lv4yjMZYU4HAlM/htS1JIUWk1PyZwpxcL6zklARiLODFnsP1lhz28oRzrqWSc5MzjojGrFAW73yQOb9XfxszwxXtVtYoFJi9dAbMw9NZIemQklVv9qrvYNEOQN1NJDnazyfx8YA==;5:YTbvy2lh3KXhvqjFbTiJ3aj8AFMm75X0STHF0R9jDZCzRIxVX+Ko+0RqXk5ypwZwwg7KRQ5cyg29iac3UfTaqXG8r41eulRbuakmYmEtxOknW8/kysdeBkf0A5/PbEJ/vlWu1v6sanxBESVaR8RGLI3LbmkkFVyj6lnodC6qkrQ=;7:cFRlAnOGhATU3v4/ggA1RRSfn29XMTPeCka5g2MKP8h7Ua9r6nyR5L1D5gyVfoSc9kunsN2YzRIRGI9kBwfl8HZ4TBL2sY1MSfmxvy7EYkWgzS5nJ+enEmWIb0YxifwUWMOTk9wSkS0MzXOVesQJXg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2018 07:32:54.4360 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3915833-7ded-4603-6740-08d64df13873 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0201MB3519 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17. 11. 18 2:56, Nathan Chancellor wrote: > On Fri, Nov 16, 2018 at 09:40:45AM +0100, Michal Simek wrote: >> On 09. 11. 18 16:36, Nathan Chancellor wrote: >>> On Fri, Nov 09, 2018 at 10:33:00AM +0100, Michal Simek wrote: >>>> On 08. 11. 18 16:01, Nathan Chancellor wrote: >>>>> On Thu, Nov 08, 2018 at 07:45:42AM +0100, Michal Simek wrote: >>>>>> On 07. 11. 18 18:48, Nick Desaulniers wrote: >>>>>>> On Wed, Nov 7, 2018 at 1:01 AM Michal Simek wrote: >>>>>>>> >>>>>>>> On 07. 11. 18 9:55, Nathan Chancellor wrote: >>>>>>>>> On Wed, Nov 07, 2018 at 09:46:12AM +0100, Michal Simek wrote: >>>>>>>>>> On 01. 11. 18 1:57, Nathan Chancellor wrote: >>>>>>>>>>> Clang warns when one enumerated type is implicitly converted to another: >>>>>>>>>>> >>>>>>>>>>> drivers/pinctrl/pinctrl-zynq.c:985:18: warning: implicit conversion from >>>>>>>>>>> enumeration type 'enum zynq_pin_config_param' to different enumeration >>>>>>>>>>> type 'enum pin_config_param' [-Wenum-conversion] >>>>>>>>>>> {"io-standard", PIN_CONFIG_IOSTANDARD, zynq_iostd_lvcmos18}, >>>>>>>>>>> ~ ^~~~~~~~~~~~~~~~~~~~~ >>>>>>>>>>> drivers/pinctrl/pinctrl-zynq.c:990:16: warning: implicit conversion from >>>>>>>>>>> enumeration type 'enum zynq_pin_config_param' to different enumeration >>>>>>>>>>> type 'enum pin_config_param' [-Wenum-conversion] >>>>>>>>>>> = { PCONFDUMP(PIN_CONFIG_IOSTANDARD, "IO-standard", NULL, true), >>>>>>>>>>> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>>>>>>>> ./include/linux/pinctrl/pinconf-generic.h:163:11: note: expanded from >>>>>>>>>>> macro 'PCONFDUMP' >>>>>>>>>>> .param = a, .display = b, .format = c, .has_arg = d \ >>>>>>>>>>> ^ >>>>>>>>>>> 2 warnings generated. >>>>>>>>>> >>>>>>>>>> This is interesting. I have never tried to use llvm for building the >>>>>>>>>> kernel. Do you have any description how this can be done? >>>>>>>>>> >>>>>>>>> >>>>>>>>> Depending on what version of Clang you have access to, it is usually just as >>>>>>>>> simple as running 'make ARCH=arm CC=clang CROSS_COMPILE=arm-linux-gnueabi-'. >>>>>>>>> >>>>>>>>> Clang 7.0+ is recommended but 6.0 might work too. >>>>>>>> >>>>>>>> TBH I would expect to download container and run this there to make sure >>>>>>>> that I don't break anything else. >>>>>>> >>>>>>> This is the first request we've had for a container in order to test a >>>>>>> patch. If it comes up again from other folks, I think it makes sense >>>>>>> to create one. Until then, its nice to have. It's definitely >>>>>>> overkill for this patch. >>>>>> >>>>>> I have played with it to see that error and here are some steps I did. >>>>>> >>>>>> docker run --name test-clang -it --rm debian:latest bash >>>>>> apt-get update >>>>>> apt-get install gcc-arm-linux-gnueabi gcc-aarch64-linux-gnu clang git bc >>>>>> build-essential bison flex make llvm vim libssl-dev sparse >>>>>> >>>>>> git clone >>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git --depth 1 >>>>>> cd linux >>>>>> >>>>>> export ARCH=arm64 >>>>>> export CROSS_COMPILE=aarch64-linux-gnu- >>>>>> >>>>>> make defconfig >>>>> >>>>> This should also have 'CC=clang' because compiler detection happens in >>>>> Kconfig now so compiler flags get properly set. Other than that, looks >>>>> good and I was able to build pinctrl-zynq.o without any issues with >>>>> those commands. >>>> >>>> For arm32 I am still getting compilation issue (arm64 is fine) >>>> Below are my steps and version I use. Do you know what could be the >>>> problem? >>>> >>>> Thanks, >>>> Michal >>>> >>>> root@1e15921e6d15:~/linux# arm-linux-gnueabi-gcc --version >>>> arm-linux-gnueabi-gcc (Debian 6.3.0-18) 6.3.0 20170516 >>>> Copyright (C) 2016 Free Software Foundation, Inc. >>>> This is free software; see the source for copying conditions. There is NO >>>> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. >>>> >>>> root@1e15921e6d15:~/linux# clang --version >>>> clang version 3.8.1-24 (tags/RELEASE_381/final) >>>> Target: x86_64-pc-linux-gnu >>>> Thread model: posix >>>> InstalledDir: /usr/bin >>>> >>>> >>>> export ARCH=arm >>>> export CROSS_COMPILE=arm-linux-gnuaebi- >>>> make CC=clang defconfig >>>> make CC=clang drivers/pinctrl/pinctrl-zynq.o >>>> >>>> and I get >>>> clang: error: unsupported argument '-W' to option 'Wa,' >>>> scripts/Makefile.build:305: recipe for target 'scripts/mod/empty.o' failed >>>> make[2]: *** [scripts/mod/empty.o] Error 1 >>>> scripts/Makefile.build:546: recipe for target 'scripts/mod' failed >>>> >>> >>> Ah because Debian's regular Clang is ancient. >>> >>> For testing, we use the builds from apt.llvm.org. Commands assuming >>> you're using the normal Debian image: >>> >>> curl https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - >>> echo "deb http://apt.llvm.org/stretch/ llvm-toolchain-stretch main" | tee -a /etc/apt/sources.list >>> apt-get update -qq && apt-get install -y clang-8 >>> >>> Then use `CC=clang-8' instead of 'CC=clang' for all make invocations. >>> >> >> Still I see some issues. Log below. >> >> Thanks, >> Michal >> >> root@1e15921e6d15:~/linux# git reset --hard v4.20-rc2 >> HEAD is now at ccda4af0f4b9 Linux 4.20-rc2 >> root@1e15921e6d15:~/linux# >> root@1e15921e6d15:~/linux# >> root@1e15921e6d15:~/linux# export ARCH=arm >> root@1e15921e6d15:~/linux# export CROSS_COMPILE=arm-linux-gnuaebi- >> root@1e15921e6d15:~/linux# export CC=clang-8 >> root@1e15921e6d15:~/linux# make CC=clang-8 defconfig >> HOSTCC scripts/kconfig/conf.o >> HOSTLD scripts/kconfig/conf >> *** Default configuration is based on 'multi_v7_defconfig' >> # >> # configuration written to .config >> # >> root@1e15921e6d15:~/linux# make CC=clang-8 >> scripts/kconfig/conf --syncconfig Kconfig >> SYSHDR arch/arm/include/generated/uapi/asm/unistd-common.h >> SYSHDR arch/arm/include/generated/uapi/asm/unistd-oabi.h >> SYSHDR arch/arm/include/generated/uapi/asm/unistd-eabi.h >> UPD include/config/kernel.release >> UPD include/generated/uapi/linux/version.h >> UPD include/generated/utsrelease.h >> SYSNR arch/arm/include/generated/asm/unistd-nr.h >> SYSTBL arch/arm/include/generated/calls-oabi.S >> SYSTBL arch/arm/include/generated/calls-eabi.S >> CC kernel/bounds.s >> clang: warning: argument unused during compilation: '-Wa,-W' >> [-Wunused-command-line-argument] >> clang: warning: argument unused during compilation: '-Wa,-march=armv7-a' >> [-Wunused-command-line-argument] >> UPD include/generated/bounds.h >> CC arch/arm/kernel/asm-offsets.s >> clang: warning: argument unused during compilation: '-Wa,-W' >> [-Wunused-command-line-argument] >> clang: warning: argument unused during compilation: '-Wa,-march=armv7-a' >> [-Wunused-command-line-argument] >> UPD include/generated/asm-offsets.h >> CALL scripts/checksyscalls.sh >> clang: warning: argument unused during compilation: '-Wa,-W' >> [-Wunused-command-line-argument] >> clang: warning: argument unused during compilation: '-Wa,-march=armv7-a' >> [-Wunused-command-line-argument] >> CC scripts/mod/empty.o >> clang: error: unsupported argument '-W' to option 'Wa,' >> scripts/Makefile.build:293: recipe for target 'scripts/mod/empty.o' failed >> make[2]: *** [scripts/mod/empty.o] Error 1 >> scripts/Makefile.build:518: recipe for target 'scripts/mod' failed >> make[1]: *** [scripts/mod] Error 2 >> Makefile:1075: recipe for target 'scripts' failed >> make: *** [scripts] Error 2 >> root@1e15921e6d15:~/linux# clang-8 --version >> clang version 8.0.0-svn345496-1~exp1+0~20181029105533.852~1.gbpf10f36 >> (trunk) >> Target: x86_64-pc-linux-gnu >> Thread model: posix >> InstalledDir: /usr/bin >> root@1e15921e6d15:~/linux# arm-linux-gnueabi-gcc --version >> arm-linux-gnueabi-gcc (Debian 6.3.0-18) 6.3.0 20170516 >> Copyright (C) 2016 Free Software Foundation, Inc. >> This is free software; see the source for copying conditions. There is NO >> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. >> >> > > I think it's the 'export CC=clang-8'; without it, I can get past that > point without any issues. Our continuous integration setup provides CC > to make on the same line, without an export. > > https://github.com/ClangBuiltLinux/continuous-integration/blob/master/driver.sh > > https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/159007956 ok - Nice links. You use docker already which is exactly what I was looking for. I found where the issue was. I did a typo export CROSS_COMPILE=arm-linux-gnuaebi- it should be export CROSS_COMPILE=arm-linux-gnueabi- Thanks for help to resolve this. Thanks, Michal