From: Hans Zhang <18255117159@163.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, bwawrzyn@cisco.com,
thomas.richard@bootlin.com,
wojciech.jasko-EXT@continental-corporation.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v2] PCI: cadence: Add configuration space capability search API
Date: Sun, 9 Mar 2025 11:18:21 +0800 [thread overview]
Message-ID: <3e6645a8-6de9-4125-8444-fa1a4f526881@163.com> (raw)
In-Reply-To: <20250309023839.2cakdpmsbzn6pm7g@uda0492258>
On 2025/3/9 10:38, Siddharth Vadapalli wrote:
> On Sat, Mar 08, 2025 at 09:39:03PM +0800, Hans Zhang wrote:
>> Add configuration space capability search API using struct cdns_pcie*
>> pointer.
>>
>> The offset address of capability or extended capability designed by
>> different SOC design companies may not be the same. Therefore, a flexible
>> public API is required to find the offset address of a capability or
>> extended capability in the configuration space.
>>
>> Signed-off-by: Hans Zhang <18255117159@163.com>
>> ---
>> Changes since v1:
>> https://lore.kernel.org/linux-pci/20250123070935.1810110-1-18255117159@163.com
>>
>> - Added calling the new API in PCI-Cadence ep.c.
>> - Add a commit message reason for adding the API.
>
> In reply to your v1 patch, you have mentioned the following:
> "Our controller driver currently has no plans for upstream and needs to
> wait for notification from the boss."
> at:
> https://lore.kernel.org/linux-pci/fcfd4827-4d9e-4bcd-b1d0-8f9e349a6be7@163.com/
>
> Since you have posted this patch, does it mean that you will be
> upstreaming your driver as well? If not, we still end up in the same
> situation as earlier where the Upstream Linux has APIs to support a
> Downstream driver.
>
> Bjorn indicated the above already at:
> https://lore.kernel.org/linux-pci/20250123170831.GA1226684@bhelgaas/
> and you did agree to do so. But this patch has no reference to the
> upstream driver series which shall be making use of the APIs in this
> patch.
Hi Siddharth,
Bjorn:
If/when you upstream code that needs this interface, include this
patch as part of the series. As Siddharth pointed out, we avoid
merging code that has no upstream users.
Hans: This user is: pcie-cadence-ep.c. I think this is an optimization
of Cadence common code. I think this is an optimization of Cadence
common code. Siddharth, what do you think?
Best regards,
Hans
next prev parent reply other threads:[~2025-03-09 3:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 13:39 Hans Zhang
2025-03-09 2:38 ` Siddharth Vadapalli
2025-03-09 3:18 ` Hans Zhang [this message]
2025-03-09 5:48 ` Siddharth Vadapalli
2025-03-09 9:49 ` Hans Zhang
2025-03-09 10:02 ` Siddharth Vadapalli
2025-03-10 15:09 ` Hans Zhang
2025-03-14 13:05 ` Manivannan Sadhasivam
2025-03-14 20:31 ` Bjorn Helgaas
2025-03-15 0:06 ` Hans Zhang
2025-03-20 21:28 ` Bjorn Helgaas
2025-03-21 1:09 ` Hans Zhang
2025-03-15 0:05 ` Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e6645a8-6de9-4125-8444-fa1a4f526881@163.com \
--to=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=bwawrzyn@cisco.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=thomas.richard@bootlin.com \
--cc=wojciech.jasko-EXT@continental-corporation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®