mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: linux-kernel@vger.kernel.org, mhiramat@kernel.org,
	akpm@linux-foundation.org, gregkh@linuxfoundation.org,
	Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH] hung_task: Migrate hung_task_detect_count to sysfs
Date: Sun, 30 Nov 2025 13:43:51 +0800	[thread overview]
Message-ID: <3e672e64-c03d-4129-ac13-13a45135b0f1@linux.dev> (raw)
In-Reply-To: <20251129235159.1227977-1-atomlin@atomlin.com>

Hi Aaron,

Thanks for the patch.

On 2025/11/30 07:51, Aaron Tomlin wrote:
> The hung_task_detect_count metric, which tracks the cumulative number of
> tasks detected as hung since boot, is currently exposed via the legacy
> /proc/sys/kernel/hung_task_detect_count sysctl file.
> 
> Migrate this metric to a read-only file in the /sys/kernel/ hierarchy:
> /sys/kernel/hung_task_detect_count. The sysctl file is removed, and the
> metric is now controlled by the CONFIG_SYSFS Kconfig option.

Emm, I don't think we should do this :)

Removing the sysctl file is going to break userspace tools that
currently read it ...

And, yeah, while moving read-only stats to sysfs makes sense on
paper, is it really worth the churn? Since we'd likely have to
keep the old sysctl file anyway for backward compatibility, we'd
just end up maintaining two interfaces fo the exact same counter :)

[...]

Thanks anyway,
Lance

  reply	other threads:[~2025-11-30  5:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-29 23:51 Aaron Tomlin
2025-11-30  5:43 ` Lance Yang [this message]
2025-11-30  8:30   ` Greg KH
2025-11-30 17:11   ` Aaron Tomlin
2025-12-01  3:08     ` Lance Yang
2025-12-01 22:57       ` Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e672e64-c03d-4129-ac13-13a45135b0f1@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®