From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbdIOJJq (ORCPT ); Fri, 15 Sep 2017 05:09:46 -0400 Received: from mail-wr0-f169.google.com ([209.85.128.169]:52991 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbdIOJJp (ORCPT ); Fri, 15 Sep 2017 05:09:45 -0400 X-Google-Smtp-Source: ADKCNb5BEEe2+UCVWFpKvx2/hfxqhmOJGzta0gernpT38BIOVjuc812KwKolU1MpLqd5ePHQ4Ym1iA== Subject: Re: [PATCH] remoteproc: qcom: select QCOM_SMP2P for all qcom pils To: Bjorn Andersson Cc: Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170913160405.17855-1-srinivas.kandagatla@linaro.org> <20170914165751.GN2016@tuxbook> From: Srinivas Kandagatla Message-ID: <3e72fa15-7c56-3b15-2532-cd3ae03b4631@linaro.org> Date: Fri, 15 Sep 2017 10:09:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170914165751.GN2016@tuxbook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/09/17 17:57, Bjorn Andersson wrote: > On Wed 13 Sep 09:04 PDT 2017, srinivas.kandagatla@linaro.org wrote: > >> From: Srinivas Kandagatla >> >> All Qualcomm PIL drivers require SMP2P module to get a functional PIL, >> Currently user has to explicitly select SMP2P module, after looking >> at failure logs. >> >> Fix this by selecting SMP2P as part of dependency of pil kconfig itself. >> > > The Kconfig should describe dependencies needed by the code, not by the > system. I partially agree with this! As I did not realize that that there are more than one SMEM_STATE drivers. The driver bindings clearly marks "qcom,smem-states" and "qcom,smem-state-names" as required properties, so it makes the driver dependent on SMEM_STATE. But SMEM_STATE is only selected from SMP2P Kconfig. Indirectly/directly the driver is dependent on the SMEM_STATE drivers. > > I agree with you that this leads to wasted time trying figure out if > we're missing drivers/modules in the kernel, but I think that needs to > be solved in a more generic way. > >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/remoteproc/Kconfig | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig >> index 8891a8e50f12..052c9e20abb6 100644 >> --- a/drivers/remoteproc/Kconfig >> +++ b/drivers/remoteproc/Kconfig >> @@ -87,6 +87,7 @@ config QCOM_ADSP_PIL >> select QCOM_MDT_LOADER >> select QCOM_RPROC_COMMON >> select QCOM_SCM >> + select QCOM_SMP2P I agree, instead of select, we should mark these configs with a depends on QCOM_SMEM_STATE so that the final pil kconfigs are only selected with right dependencies are in place. Does that sound okay? thanks, srini > > NB. QCOM_SMP2P is a user-selectable config option, so you are not > allowed to "select" it, only "depends on" it. > > Regards, > Bjorn >