From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F27F1C433E7 for ; Tue, 20 Oct 2020 01:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9664D2244C for ; Tue, 20 Oct 2020 01:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389920AbgJTBUO (ORCPT ); Mon, 19 Oct 2020 21:20:14 -0400 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:54895 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389908AbgJTBUO (ORCPT ); Mon, 19 Oct 2020 21:20:14 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0UCbBlp1_1603156810; Received: from JosephdeMacBook-Pro.local(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0UCbBlp1_1603156810) by smtp.aliyun-inc.com(127.0.0.1); Tue, 20 Oct 2020 09:20:10 +0800 Subject: Re: [PATCH] fs: ocfs2 remove unneeded break To: trix@redhat.com, mark@fasheh.com, jlbec@evilplan.org, davem@davemloft.net, akpm@linux-foundation.org, willy@infradead.org, alex.shi@linux.alibaba.com Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org References: <20201019175216.2329-1-trix@redhat.com> From: Joseph Qi Message-ID: <3e773fac-6403-560a-45d6-af949deef453@linux.alibaba.com> Date: Tue, 20 Oct 2020 09:20:10 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201019175216.2329-1-trix@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/10/20 01:52, trix@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a goto > > Signed-off-by: Tom Rix Acked-by: Joseph Qi > --- > fs/ocfs2/cluster/tcp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c > index 79a231719460..3bd8119bed5e 100644 > --- a/fs/ocfs2/cluster/tcp.c > +++ b/fs/ocfs2/cluster/tcp.c > @@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc, > msglog(hdr, "bad magic\n"); > ret = -EINVAL; > goto out; > - break; > } > > /* find a handler for it */ >