From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7410C7EE24 for ; Tue, 9 May 2023 10:28:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235021AbjEIK2b (ORCPT ); Tue, 9 May 2023 06:28:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234503AbjEIK21 (ORCPT ); Tue, 9 May 2023 06:28:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C269BDC62 for ; Tue, 9 May 2023 03:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683628058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uwJ3DY9RdcSd+YOIHggeltEqU051lT22jrjPoxOONus=; b=S19gNRw6CeB9mvSl7AlV7Y8uhMOpnC8rCnQYSUld7s4aJc0YS8Ktjt4NCxlpZfYeTwa+bl DVuESs49q/iDaQyVwwK2qEy62k/1a5snpQHdF4fSkaRv5cVkJQnGqaJdaI3CY9xZ+/m18+ qsQSycUfFhljjYQZd7Z/LzLFuI4dxu0= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-iJ6atyQoPymTy9NsVZBi2Q-1; Tue, 09 May 2023 06:27:37 -0400 X-MC-Unique: iJ6atyQoPymTy9NsVZBi2Q-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-969c36898d4so101548666b.3 for ; Tue, 09 May 2023 03:27:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683628056; x=1686220056; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uwJ3DY9RdcSd+YOIHggeltEqU051lT22jrjPoxOONus=; b=DjAmIFTsXZt6ffb1y3S10sKrQTE3d1kBYzmZ6VkBsB9ma9yd06CYV+0hvFD5Qz2s9W oec6i0G2V8Yit0xEgCw9bjYX82Uz7htb5dTbrVVICXLRF3HgsGNqFFSsVsVSaKvCBngA 91B9aGtDKiKk9d5qgmJK8JhGFxzT4HR2DO1HY74XRnoZ8C/6zR78zy0FjPRjGlx5+MXt ylvps//2f2V+dpYo9LWcbw+D0P2dwt/eMxFhFFTGV763MlrOvCNMOjLk5/J81BhtEqkS GQOLDSFwIPX1v7rIZkf2EwUejWor90Q7/EbL0HvlBrQOe+zQPbYOmU3HmOJ9O60GlURS /fzA== X-Gm-Message-State: AC+VfDwqIX/ofI8bMo3zPGeua+iSzYw64xzG6HZ5o8YRO+rdXKgKu1Bs Lac4ymkFvhzZFk+brhGrEh643md84moxfF/t0mTXEVnImhpuxpgKr8y2lxrADDugIvh76k5/TQ7 nzf1d4Gz6RXE+z+8qHOfQ6SRV X-Received: by 2002:a17:907:7d9e:b0:969:f54c:dee2 with SMTP id oz30-20020a1709077d9e00b00969f54cdee2mr1339918ejc.26.1683628055926; Tue, 09 May 2023 03:27:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7dBcF0PeeSSPZxUvJ2br+FqbE5k+D1T5jX/3UjFICYV5HGVZEnqvbF6oMuzkxkJk9L157EPQ== X-Received: by 2002:a17:907:7d9e:b0:969:f54c:dee2 with SMTP id oz30-20020a1709077d9e00b00969f54cdee2mr1339892ejc.26.1683628055613; Tue, 09 May 2023 03:27:35 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id mc27-20020a170906eb5b00b00966330021e9sm1146359ejb.47.2023.05.09.03.27.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 03:27:35 -0700 (PDT) Message-ID: <3e87dd49-b2c0-c6a9-5385-c075e5264de1@redhat.com> Date: Tue, 9 May 2023 12:27:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] wifi: brcmfmac: wcc: Add debug messages Content-Language: en-US, nl To: matthias.bgg@kernel.org, Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , Paolo Abeni Cc: brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, SHA-cyfmac-dev-list@infineon.com, Pieter-Paul Giesberts , Matthias Brugger , "David S. Miller" , Eric Dumazet , Jakub Kicinski References: <20230509100420.26094-1-matthias.bgg@kernel.org> From: Hans de Goede In-Reply-To: <20230509100420.26094-1-matthias.bgg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/9/23 12:04, matthias.bgg@kernel.org wrote: > From: Matthias Brugger > > The message is attach and detach function are merly for debugging, > change them from pr_err to pr_debug. > > Signed-off-by: Matthias Brugger Thank you, I had writing this same patch on my own TODO list :) Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c > index 02de99818efa..5573a47766ad 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c > @@ -12,13 +12,13 @@ > > static int brcmf_wcc_attach(struct brcmf_pub *drvr) > { > - pr_err("%s: executing\n", __func__); > + pr_debug("%s: executing\n", __func__); > return 0; > } > > static void brcmf_wcc_detach(struct brcmf_pub *drvr) > { > - pr_err("%s: executing\n", __func__); > + pr_debug("%s: executing\n", __func__); > } > > const struct brcmf_fwvid_ops brcmf_wcc_ops = {