From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C8B278B60 for ; Mon, 26 Aug 2024 06:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724654116; cv=none; b=pMZKTTGjrffpGbNoHqwIaZLPeNSSNTIoAjcRAt8dvorIzuME0Np3RYo9K8VuE8VCE+2vI0GntslMsKfsLWhpkU2PoeCINIYIF20FMqY9iSBZoZfO9w3V0fzpKzngOLK3GW24hXb48x5ngJrEZdtg9tbCiV7A5WG7mtvhCROpKnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724654116; c=relaxed/simple; bh=7uCfogWozfSUBGu8eSvZfW7G5RH9TzGbFrL2UlBMd78=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JfkWTXzamqf2rAfQGSSi6NN4G/c9XAdsyyNVfPoynxMeT+noQiJfR21RRGgo+wF+x06N3G66JS+Qf5T1LP5hWmTDVqNC2kwp6G4hXgucdU16KVd5QkWgGR1HxHPgiM9f+c3G/8kiM1+DAehTUGBam3jRLbHUDfJzrdxyv/aH4lU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=avTvD9wE; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="avTvD9wE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724654114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Io4rHxduQz7KVgfK4myMUjM2AwxJ/v33VowE2i/ueMg=; b=avTvD9wEkNddadDc1Hwrgh2CbbTfjqBz4d/ALgpAmlkkzXixNFx1EPyIO1rJBUGnRAemy4 Dyt3q1RBZocylhSH1Q7/nGXZ1QxsZobDpGNGRZvv/734xNL/tUDjaQaqiQdCAYqwx678X9 AangeFGWlHiVnHM7AwCvxNLI1qvWDwI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-6EDZ-uXoO4SB3VZMZjwW9Q-1; Mon, 26 Aug 2024 02:35:12 -0400 X-MC-Unique: 6EDZ-uXoO4SB3VZMZjwW9Q-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42820c29a76so39725015e9.2 for ; Sun, 25 Aug 2024 23:35:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724654111; x=1725258911; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Io4rHxduQz7KVgfK4myMUjM2AwxJ/v33VowE2i/ueMg=; b=FpUCakftTkPpPNTbk735vzfq4FxrX1YE6XA3ZtOPLABdQF7jJ4j3Gfx2W8vZpESASo a+0synElMaFlObFucLeR7gD8tY2ePaKFGCm7D7QpxiGip3WSKSZJFroic/lT/A8mg2c+ TZhVNF7zRP4BGJ7cttL9MYpRwoeesajwbC9C8dIUDm8ixBJdhum1w6LNrTW1SXDo+cYn 4cX1uJ/iNyQhwA+yBKKzBwwLuWXjlKada+9vXIwg6xtfKnuS5hfOzA9WXgyKUIjQ+PH1 S3F0rrfPeZIoRs1f/8M0WlCm3DZzRtnjCNqsB6cDcGs6f8pG9b4u1MEtfa5sBx0FSKuk imIg== X-Forwarded-Encrypted: i=1; AJvYcCXnrNc8s0hjjNmtBF4ldIZLvyGlqBBEzBn/7uByc/my7owbHiUr/tt4rpSkpTe/r5r0wP+HETpUlJWr0js=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9oQ0FoF8nv5JdDMfCGaUmGVAMYONEPILPQHCM0WJtHFbnqv5M IxxT+gcIQ4AaXq/C+FL+yD61wtEa9b3XzKd39v9cL3/32XdKmnfosHIr9QYeP2OnqMjld8SFhmZ fEL5uAEz1eAMwz/wXvZsKw5kH6lTtV9pC4i8yMMxSjhlFeFv427ZVqgjRfNgS/A== X-Received: by 2002:a05:600c:4fc6:b0:425:7974:2266 with SMTP id 5b1f17b1804b1-42acc90052amr65305765e9.24.1724654111370; Sun, 25 Aug 2024 23:35:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGD1UPOcNbemD8nX9kQpa7huIkZU0EulurEZhvyHQc1BNhaddTsoqhL6utBKUXaetrMV1u9zg== X-Received: by 2002:a05:600c:4fc6:b0:425:7974:2266 with SMTP id 5b1f17b1804b1-42acc90052amr65305385e9.24.1724654110375; Sun, 25 Aug 2024 23:35:10 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:c800:cf71:2042:6051:e26? (p200300d82f12c800cf71204260510e26.dip0.t-ipconnect.de. [2003:d8:2f12:c800:cf71:2042:6051:e26]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ac5162505sm142233335e9.28.2024.08.25.23.35.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Aug 2024 23:35:09 -0700 (PDT) Message-ID: <3e8add35-e26b-443b-8a04-1078f4bc78f6@redhat.com> Date: Mon, 26 Aug 2024 08:35:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] mm: count the number of anonymous THPs per size To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, ioworker0@gmail.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, usamaarif642@gmail.com, v-songbaohua@oppo.com, yuanshuai@oppo.com, ziy@nvidia.com References: <20240824010441.21308-1-21cnbao@gmail.com> <20240824010441.21308-2-21cnbao@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240824010441.21308-2-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24.08.24 03:04, Barry Song wrote: > From: Barry Song > > Let's track for each anonymous THP size, how many of them are currently > allocated. We'll track the complete lifespan of an anon THP, starting > when it becomes an anon THP ("large anon folio") (->mapping gets set), > until it gets freed (->mapping gets cleared). > > Introduce a new "nr_anon" counter per THP size and adjust the > corresponding counter in the following cases: > * We allocate a new THP and call folio_add_new_anon_rmap() to map > it the first time and turn it into an anon THP. > * We split an anon THP into multiple smaller ones. > * We migrate an anon THP, when we prepare the destination. > * We free an anon THP back to the buddy. > > Note that AnonPages in /proc/meminfo currently tracks the total number > of *mapped* anonymous *pages*, and therefore has slightly different > semantics. In the future, we might also want to track "nr_anon_mapped" > for each THP size, which might be helpful when comparing it to the > number of allocated anon THPs (long-term pinning, stuck in swapcache, > memory leaks, ...). > > Further note that for now, we only track anon THPs after they got their > ->mapping set, for example via folio_add_new_anon_rmap(). If we would > allocate some in the swapcache, they will only show up in the statistics > for now after they have been mapped to user space the first time, where > we call folio_add_new_anon_rmap(). > > Signed-off-by: Barry Song > Acked-by: David Hildenbrand > --- > Documentation/admin-guide/mm/transhuge.rst | 5 +++++ > include/linux/huge_mm.h | 15 +++++++++++++-- > mm/huge_memory.c | 13 ++++++++++--- > mm/migrate.c | 4 ++++ > mm/page_alloc.c | 5 ++++- > mm/rmap.c | 1 + > 6 files changed, 37 insertions(+), 6 deletions(-) > > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst > index 79435c537e21..b78f2148b242 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -551,6 +551,11 @@ split_deferred > it would free up some memory. Pages on split queue are going to > be split under memory pressure, if splitting is possible. > In light of documentation of patch #2, small nits: > +nr_anon > + the number of transparent anon huge pages we have in the whole system. s/transparent anon huge pages/anonymous THP/ > + These huge pages could be entirely mapped or have partially s/huge pages/THPs/ s/could be/might be currently/ Maybe Andrew can just fix it up if there are no other comments. Thanks! -- Cheers, David / dhildenb