From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: smtp.codeaurora.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QVssKFGU" DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A310C6070B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932614AbeFFJux (ORCPT + 25 others); Wed, 6 Jun 2018 05:50:53 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:43599 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932351AbeFFJuv (ORCPT ); Wed, 6 Jun 2018 05:50:51 -0400 X-Google-Smtp-Source: ADUXVKKZlbmZT/XlipVkCiGd1PSjWRsgM1PK5oG7Fblhs8GUmyiY3eA2ESqm8Qg8LVnwRa6P5Vgl3A== Subject: Re: [PATCH v4 08/12] mfd: da9063: Add custom regmap for DA9063L To: Lee Jones Cc: linux-kernel@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , Mark Brown , Steve Twiss , Wolfram Sang , linux-renesas-soc@vger.kernel.org References: <20180605231013.1803-1-marek.vasut+renesas@gmail.com> <20180605231013.1803-8-marek.vasut+renesas@gmail.com> <20180606063936.GY21163@dell> From: Marek Vasut Message-ID: <3e90824b-08d7-015f-9264-4fe4edd05418@gmail.com> Date: Wed, 6 Jun 2018 11:47:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180606063936.GY21163@dell> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2018 08:39 AM, Lee Jones wrote: > On Wed, 06 Jun 2018, Marek Vasut wrote: > >> The DA9063L does not have an RTC. Add custom regmap for DA9063L to >> prevent access into that register block. >> >> Signed-off-by: Marek Vasut >> Cc: Geert Uytterhoeven >> Cc: Lee Jones >> Cc: Mark Brown >> Cc: Steve Twiss >> Cc: Wolfram Sang >> Cc: linux-renesas-soc@vger.kernel.org >> --- >> V3: New patch >> V4: Drop mention of buggy datasheet in the commit message >> --- >> drivers/mfd/da9063-i2c.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 91 insertions(+) >> >> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c >> index 048ce55ebc5b..f0d92a37df6b 100644 >> --- a/drivers/mfd/da9063-i2c.c >> +++ b/drivers/mfd/da9063-i2c.c >> @@ -208,6 +208,93 @@ static const struct regmap_access_table da9063_bb_volatile_table = { >> .n_yes_ranges = ARRAY_SIZE(da9063_bb_volatile_ranges), >> }; >> >> +static const struct regmap_range da9063l_bb_readable_ranges[] = { >> + { >> + .range_min = DA9063_REG_PAGE_CON, >> + .range_max = DA9063_REG_MON_A10_RES, >> + }, { >> + .range_min = DA9063_REG_SEQ, >> + .range_max = DA9063_REG_ID_32_31, >> + }, { >> + .range_min = DA9063_REG_SEQ_A, >> + .range_max = DA9063_REG_AUTO3_LOW, >> + }, { >> + .range_min = DA9063_REG_T_OFFSET, >> + .range_max = DA9063_BB_REG_GP_ID_19, >> + }, { >> + .range_min = DA9063_REG_CHIP_ID, >> + .range_max = DA9063_REG_CHIP_VARIANT, >> + }, >> +}; >> + >> +static const struct regmap_range da9063l_bb_writeable_ranges[] = { >> + { >> + .range_min = DA9063_REG_PAGE_CON, >> + .range_max = DA9063_REG_PAGE_CON, >> + }, { >> + .range_min = DA9063_REG_FAULT_LOG, >> + .range_max = DA9063_REG_VSYS_MON, >> + }, { >> + .range_min = DA9063_REG_SEQ, >> + .range_max = DA9063_REG_ID_32_31, >> + }, { >> + .range_min = DA9063_REG_SEQ_A, >> + .range_max = DA9063_REG_AUTO3_LOW, >> + }, { >> + .range_min = DA9063_REG_CONFIG_I, >> + .range_max = DA9063_BB_REG_MON_REG_4, >> + }, { >> + .range_min = DA9063_BB_REG_GP_ID_0, >> + .range_max = DA9063_BB_REG_GP_ID_19, >> + }, >> +}; >> + >> +static const struct regmap_range da9063l_bb_volatile_ranges[] = { >> + { >> + .range_min = DA9063_REG_PAGE_CON, >> + .range_max = DA9063_REG_EVENT_D, >> + }, { >> + .range_min = DA9063_REG_CONTROL_A, >> + .range_max = DA9063_REG_CONTROL_B, >> + }, { >> + .range_min = DA9063_REG_CONTROL_E, >> + .range_max = DA9063_REG_CONTROL_F, >> + }, { >> + .range_min = DA9063_REG_BCORE2_CONT, >> + .range_max = DA9063_REG_LDO11_CONT, >> + }, { >> + .range_min = DA9063_REG_DVC_1, >> + .range_max = DA9063_REG_ADC_MAN, >> + }, { >> + .range_min = DA9063_REG_ADC_RES_L, >> + .range_max = DA9063_REG_MON_A10_RES, >> + }, { >> + .range_min = DA9063_REG_SEQ, >> + .range_max = DA9063_REG_SEQ, >> + }, { >> + .range_min = DA9063_REG_EN_32K, >> + .range_max = DA9063_REG_EN_32K, >> + }, { >> + .range_min = DA9063_BB_REG_MON_REG_5, >> + .range_max = DA9063_BB_REG_MON_REG_6, >> + }, >> +}; > > Not sure why the regmap_reg_range() MACRO is lower case, but still, > please make use of it to save a few lines. Ha, OK > Once changed, please add my: > > For my own reference: > Acked-for-MFD-by: Lee Jones > -- Best regards, Marek Vasut