From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932334AbdJWP7X (ORCPT ); Mon, 23 Oct 2017 11:59:23 -0400 Received: from mga03.intel.com ([134.134.136.65]:21778 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbdJWP7W (ORCPT ); Mon, 23 Oct 2017 11:59:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,423,1503385200"; d="scan'208";a="1209020109" Subject: Re: [PATCH] dmaengine: ioat: Use common error handling code in ioat_xor_val_self_test() To: Dan Carpenter , SF Markus Elfring Cc: "dmaengine@vger.kernel.org" , Arvind Yadav , "Williams, Dan J" , Geliang Tang , Krister Johansen , Pan Bian , "Koul, Vinod" , LKML , "kernel-janitors@vger.kernel.org" References: <20171023072745.nh2mrwez2to6nst4@mwanda> From: Dave Jiang Message-ID: <3e96d66a-de9c-5b2b-5646-84037a3935f7@intel.com> Date: Mon, 23 Oct 2017 08:59:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171023072745.nh2mrwez2to6nst4@mwanda> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2017 12:27 AM, Dan Carpenter wrote: > These patches hurt readability. > > regards, > dan carpenter > I agree with Dan. I'm ok with not accepting this patch.