From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F5BC433EF for ; Mon, 30 May 2022 08:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233963AbiE3IhC (ORCPT ); Mon, 30 May 2022 04:37:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233448AbiE3Ig4 (ORCPT ); Mon, 30 May 2022 04:36:56 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C945963DF; Mon, 30 May 2022 01:36:55 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 1421C1F426C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1653899814; bh=QXMptDFhVLDAZ07/57pWnVM0NdwQo1qtAyHj2BDt4F8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n0xiApnA0e8UvIxSWTqERaumNNNm8/b06GVD7/p9fWcUcapEn+C63xTjDfz8KAnnG LhNUq94LFyG1Rdr2NKCc4I8nh4Sg2V9I4RFWDkcRx0AGvFHzSg5IJgOgtr2WP8wc2G sE1JP6y2pP9vzshKi48iKYWcwJ8ubqyUe+pdIzPatXHI9qH1pSdk6GYu5pnkwzmuXQ /RLJPZbsiSDjdvAB1FMiA8mwchMaK5uKf2rIM7LlOdSriZP/CI3qDXVEsobQAxGmX8 0sw9ZETCj736BXuidmBCvjFMiT123esoVNO7yOoMEGSvbnm3D945Gkq6FVHbHwkjuq stq1W0osDjqCA== Message-ID: <3e977bb3-7d4d-8d11-8779-62ae72d2c117@collabora.com> Date: Mon, 30 May 2022 10:36:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v1 2/2] dt-bindings: pinctrl: mt8192: Use generic bias instead of pull-*-adv Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Linus Walleij Cc: kernel@collabora.com, Krzysztof Kozlowski , Matthias Brugger , Rob Herring , Sean Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220525155714.1837360-1-nfraprado@collabora.com> <20220525155714.1837360-3-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220525155714.1837360-3-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 25/05/22 17:57, Nícolas F. R. A. Prado ha scritto: > Commit cafe19db7751 ("pinctrl: mediatek: Backward compatible to previous > Mediatek's bias-pull usage") allowed the bias-pull-up and bias-pull-down > properties to be used for setting PUPD/R1/R0 type bias on mtk-paris > based SoC's, which was previously only supported by the custom > mediatek,pull-up-adv and mediatek,pull-down-adv properties. > > Since the bias-pull-{up,down} properties already have defines associated > thus being more descriptive and is more universal on MediaTek platforms, > and given that there are no mediatek,pull-{up,down}-adv users on mt8192 > yet, remove the custom adv properties in favor of the generic ones. > > Note that only mediatek,pull-up-adv was merged in the binding, but not > its down counterpart. > > Fixes: edbacb36ea50 ("dt-bindings: pinctrl: mt8192: Add mediatek,pull-up-adv property") > Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno