From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Dimitri Fedrau <dimitri.fedrau@liebherr.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: dp83822: Add support for GPIO2 clock output
Date: Wed, 11 Dec 2024 14:40:51 +0100 [thread overview]
Message-ID: <3e99f80a-a051-4b8a-b086-ff8d949b5417@kernel.org> (raw)
In-Reply-To: <20241211105100.GA4424@debian>
On 11/12/2024 11:51, Dimitri Fedrau wrote:
>>> +
>>> +/* IO_MUX_GPIO_CTRL - Clock source selection */
>>> +#define DP83822_CLK_SRC_MAC_IF 0x0
>>> +#define DP83822_CLK_SRC_XI 0x1
>>> +#define DP83822_CLK_SRC_INT_REF 0x2
>>> +#define DP83822_CLK_SRC_RMII_MASTER_MODE_REF 0x4
>>> +#define DP83822_CLK_SRC_FREE_RUNNING 0x6
>>> +#define DP83822_CLK_SRC_RECOVERED 0x7
>>
>> These are not really bindings but some register values. Hex numbers
>> indicate that. Don't store register values as bindings, because this
>> is neither necessary nor helping.
>>
> Ok, got it. Have seen similar in <dt-bindings/net/ti-dp83867.h> or
> <dt-bindings/net/ti-dp83869.h>, is it wrong there ?
Yes, it is. Rules were much more relaxed 10 years ago but these were not
even sent for DT review and did not receive any ack/review.
>
> Best regards,
> Dimitri Fedrau
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-11 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 8:04 [PATCH net-next v2 0/2] net: phy: " Dimitri Fedrau via B4 Relay
2024-12-11 8:04 ` [PATCH net-next v2 1/2] dt-bindings: net: " Dimitri Fedrau via B4 Relay
2024-12-11 9:43 ` Krzysztof Kozlowski
2024-12-11 10:51 ` Dimitri Fedrau
2024-12-11 13:40 ` Krzysztof Kozlowski [this message]
2024-12-11 8:04 ` [PATCH net-next v2 2/2] net: phy: " Dimitri Fedrau via B4 Relay
2024-12-11 9:45 ` Krzysztof Kozlowski
2024-12-11 10:52 ` Dimitri Fedrau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e99f80a-a051-4b8a-b086-ff8d949b5417@kernel.org \
--to=krzk@kernel.org \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®