From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E4EC7EE2F for ; Sat, 6 May 2023 15:25:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232901AbjEFPZM convert rfc822-to-8bit (ORCPT ); Sat, 6 May 2023 11:25:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232526AbjEFPZK (ORCPT ); Sat, 6 May 2023 11:25:10 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0404BA26F; Sat, 6 May 2023 08:25:08 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pvJmQ-003JEH-Gg; Sat, 06 May 2023 17:25:02 +0200 Received: from p57bd9cee.dip0.t-ipconnect.de ([87.189.156.238] helo=suse-laptop.fritz.box) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1pvJmQ-0011hr-6G; Sat, 06 May 2023 17:25:02 +0200 Message-ID: <3e9c027dd90ca9d4a02ba06714960ddcdae5fd2c.camel@physik.fu-berlin.de> Subject: Re: [PATCH 0/2] SH7709 DMA fixes From: John Paul Adrian Glaubitz To: Artur Rojek , Yoshinori Sato , Rich Felker Cc: Rafael Ignacio Zurita , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 06 May 2023 17:25:01 +0200 In-Reply-To: <20230506141703.65605-1-contact@artur-rojek.eu> References: <20230506141703.65605-1-contact@artur-rojek.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.1 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.156.238 X-ZEDAT-Hint: PO Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Artur! Thanks a lot for your patches! On Sat, 2023-05-06 at 16:17 +0200, Artur Rojek wrote: > this series provides fixes to the SH7709 DMA controller, allowing the HP > Jornada 680 palmtop to boot Linux again. To my knowledge, this is the > first time in ~14 years someone tests upstream Linux on this device. And > with the included patches applied, I'm happy to announce that it still > works like a charm. Wow, that sounds great! I will be happy to review your patches. > PS. What might be of interest to the sh-linux community, there's further > work towards this platform in my pipeline. E.g. I've added support for > the HD6446x PCMCIA controller, allowing Jornada 680 to use Ethernet and > Wi-Fi cards. However, what prevents proper upstream of such a driver is > the crude and antiquated code of the underlying platform base. For > example, the HD6446x bridge (`cchips/hd6446x/hd64461.c`) lacks the > concept of clocks, preventing the PCMCIA driver from hardware agnostic > clock gating. So what I'm looking into next is the cleanup of existing > platform code base, bringing it up-to-date with modern kernel APIs. > Hopefully it's not trying to bite more than I can chew, but eventually > ending up with Device Tree support would be really nice :) Yes, there is still a lot of modernization work to be done for SuperH! Device tree has actually been worked on in the past and there is a patch set by Yoshinori Sato to add support for device tree that got never merged, see [1]. Geert and I are planning to have another look at these patches and see whether we can get them into a shape where they can be merged. Maybe you can help us with that effort. I might not have the time for your patches today, but certainly next week starting Monday. Very much looking forward to reviewing and merging them into my SuperH tree [2]. Adrian > [1] https://lore.kernel.org/all/1467564402-2649-1-git-send-email-ysato@users.sourceforge.jp/ > [2] https://git.kernel.org/pub/scm/linux/kernel/git/glaubitz/sh-linux.git/ -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913