From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0832F285CB6 for ; Sun, 29 Mar 2026 05:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774760405; cv=none; b=ljscG//5Dm9VcsT0nsz+19L5jJsoG594Z2fTYC43VPdyL6BmPHoDUS7TXozI5myh9blkXlJGQvXJmVx3hbpex756V2RfNRO0WZyAkN2mTxIgZ85xi0Y2VjXD74LkuzhNUs3zj4JFBkYDIuNVDxEeUXRcpbULH6jvoAiyU8H8JNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774760405; c=relaxed/simple; bh=LOtH3S8qYAKpoSp7FFj6apFYxHA7wWRgd48/9/MpHjA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TGsxlIMoSl3969uwD/K8wX8XZow3mJh+e6RCHhcRGZy8s7YKMFLLBQkLWnIpGX6/jRRHUr8timpTAA0hWISQM/HQQyt+W0tCEGG28ag03YEE3CuI8Qd+KI92wuXZr2qcjccQwUrTi0jk2Hk8sOViVI7DxAlh+jkrkdpozZrjFew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d4dDySjW; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d4dDySjW" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b2429f98d0so5711895ad.2 for ; Sat, 28 Mar 2026 22:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774760403; x=1775365203; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FlCtCV3bo5lFe242o6uj0fTlU+XxEfIY7TYvULOn41o=; b=d4dDySjW8f+9xq8Md5HUMSTLiIG+x+7fiKGJC4VJl4qTKl+ONuyYEWJVHbQN+euNPL gTHHc+Ojgx1STqu2/TkeVKI4LK4Y1nTjFOBNEIT09tmqHsmMCmVd4nuniyfNf0Gxpgts nxTUMLZeUffA1KdWyIzD0Ui6DUqNRmk4DGIfqJOLEKOQTr/F5KlziasZhn1ZEP2sO7Z9 bSoPDrDdYJwAAoPN+Okq5AzNAmnYIlCIKBJ/IHHaylzTUzIv7Jjsy4qxgmHUl2ReNUuR rtt6/t125C+KHT0DSTRLPtJE43bMQXickAFxgKSZYFf9B9eLUUt/5Ylwrnd7dyeWLDzG ehxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774760403; x=1775365203; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FlCtCV3bo5lFe242o6uj0fTlU+XxEfIY7TYvULOn41o=; b=KYk01eDa7wUUJFC2nNbCD1S9ABra+FWVfBbmxrrXkBR7dfr9v23FjIS9viSDwWJ4st TWhKOw63M1IwqktdY7h8KTHN05gE+7C5rR5XV6rB3fcEWip1pf5Bqxh15BVyMyrl3bJg S1Qod0MGiLzdLAG5kewF1Xs+nhaGhTpc/qjDesj3xFylZzOXKfuHJVUf/28I3JQVI+N/ nI2heoJqpoFXOXYG2GD4POpCHhnwGBNyoD3Ml9/KHVva0sVdkTB9BR6MOcMbV21dOpFH 5YvQMr97BdW9DManWwRKKFagZXGomdT1DjvfJHLWYqflX7p86psXiYuojOq7c7DDR00H JloA== X-Forwarded-Encrypted: i=1; AJvYcCWuz+Z9NYr7BdW52S4zgJBsur02rEoi3S0NkTARkwz0sct74wk+Xc6psfqq+XZmwpBMcwo1Dzf0+iQv6Gw=@vger.kernel.org X-Gm-Message-State: AOJu0YyvEb5wTlnCaz4i3fymPiRKdKNRJAjLhh9NxZGUTauEsM1LIhOi sSYXcEH1EEwSIY+C5qjlS0pbu/WpjzVhK4OVp02RyYN8wKiBvD70I3ez X-Gm-Gg: ATEYQzz6XmgL5xZSxy4MIvpjGWRffFoctry+zDwdOaASMh26rjioq4jyxdPhAsuhqdU 37Y7qdTMGgHJDdERnZdTw/IE/T8S3t/5qJ4Z5PsHh8nahB4mpr1kxH1kssLJdP7E+VerVi6WlBL SHQB0nDWlLPIgZ7QHdQ5rej0UD6UxxLfkIKHHYq5WkNhQaA7jloHZwKzuex8HUqVok8g8Thkae5 +vm7OVGTecV6KXSkenoTC4aNQsEK11rs5Cqf2ug+AzgMX2KjxRS/o+OhvYDZGtmryW9Q2/+UR1I fDyPA4XnIpCeuEDUbH38FHnJ5gEmiYiTDoVVJHuk/gCNVMqeDOHCbmyCiMvU/tZVxTEXiZmlnaj SagaoH36laogeNBO9PNwmyTrZ90FEw3tA6FFadqdYnRl/p3/PPohLnKzEOgghY+XKGZBlygcsUb 3DwGYnNntAC5WYrCWGJCZ1Ke+u0LliZF3LuivMSVVhj8OCV5Sb9cWSDmTce4PsL4nxHqmH6H6zG 3NPECDotiU= X-Received: by 2002:a17:903:1a2f:b0:2b0:6a3d:36e9 with SMTP id d9443c01a7336-2b0cdcb73d7mr82282055ad.33.1774760403187; Sat, 28 Mar 2026 22:00:03 -0700 (PDT) Received: from [192.168.0.5] (124-218-201-66.cm.dynamic.apol.com.tw. [124.218.201.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24276689asm38292635ad.38.2026.03.28.22.00.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Mar 2026 22:00:02 -0700 (PDT) Message-ID: <3ea0140a-4805-4fd1-a311-695f38d8bdef@gmail.com> Date: Sun, 29 Mar 2026 12:59:58 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net: phy: air_en8811h: add AN8811HB MCU assert/deassert support To: Eric Woudstra , andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn@mork.no Cc: frank-w@public-files.de, daniel@makrotopia.org, lucien.jheng@airoha.com References: <20260326153518.8387-1-lucienzx159@gmail.com> Content-Language: en-US From: "Lucien.Jheng" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Eric Woudstra 於 2026/3/27 上午 04:00 寫道: > > On 3/26/26 4:35 PM, Lucien.Jheng wrote: >> AN8811HB needs a MCU soft-reset cycle before firmware loading begins. >> Assert the MCU (hold it in reset) and immediately deassert (release) >> via a dedicated PBUS register pair (0x5cf9f8 / 0x5cf9fc), accessed >> through the PHY-addr+8 MDIO bus node rather than the BUCKPBUS indirect >> path. This clears the MCU state before the firmware loading sequence >> starts. > Perhapse you can register this extra device in the probe() function: > > struct mdio_device *mdiodev; > > mdiodev = mdio_device_create(phydev->mdio.bus, > phydev->mdio.addr + EN8811H_PBUS_ADDR_OFFS); > if (IS_ERR(mdiodev)) > return PTR_ERR(mdiodev); > > ret = mdio_device_register(mdiodev); > if (ret) { > mdio_device_free(mdiodev); > return ret; > } > > priv->pbusdev = mdiodev; > > In the define part add: > > #define EN8811H_PBUS_ADDR_OFFS 8 > > Add to struct en8811h_priv: > > struct mdio_device *pbusdev; > > And in the remove function: > > mdio_device_remove(priv->pbusdev); > mdio_device_free(priv->pbusdev); > > Then you can use the device: > > ret = en8811hb_some_neat_function(priv->pbusdev); Thank you for the feedback I will handle the registration of this extra device within the probe function in the next version. >> Add __air_pbus_reg_write() as a low-level helper for this access, then >> implement an8811hb_mcu_assert() / _deassert() on top of it. Wire both >> into an8811hb_load_firmware() and en8811h_restart_mcu() so every >> firmware load or MCU restart on AN8811HB correctly sequences the reset >> control registers. >> >> Fixes: 0a55766b7711 ("net: phy: air_en8811h: add Airoha AN8811HB support") >> Signed-off-by: Lucien Jheng >> --- >> Changes in v2: >> - Rewrite commit message: The previous wording was ambiguous, >> as it suggested the MCU remains asserted during the entire >> firmware loading process, rather than a quick reset cycle >> before it starts. >> Clarify that assert and deassert is an immediate soft-reset >> cycle to clear MCU state before firmware loading begins. >> - Add Fixes: 0a55766b7711 ("net: phy: air_en8811h: add Airoha AN8811HB >> support"). >> - Change phydev_info() to phydev_dbg() in an8811hb_mcu_assert() and >> an8811hb_mcu_deassert() to avoid noise during normal boot. >> >> drivers/net/phy/air_en8811h.c | 105 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 105 insertions(+) >> >> diff --git a/drivers/net/phy/air_en8811h.c b/drivers/net/phy/air_en8811h.c >> index 29ae73e65caa..01fce1b93618 100644 >> --- a/drivers/net/phy/air_en8811h.c >> +++ b/drivers/net/phy/air_en8811h.c >> @@ -170,6 +170,16 @@ >> #define AN8811HB_CLK_DRV_CKO_LDPWD BIT(13) >> #define AN8811HB_CLK_DRV_CKO_LPPWD BIT(14) >> >> +#define AN8811HB_MCU_SW_RST 0x5cf9f8 >> +#define AN8811HB_MCU_SW_RST_HOLD BIT(16) >> +#define AN8811HB_MCU_SW_RST_RUN (BIT(16) | BIT(0)) >> +#define AN8811HB_MCU_SW_START 0x5cf9fc >> +#define AN8811HB_MCU_SW_START_EN BIT(16) >> + >> +/* MII register constants for PBUS access (PHY addr + 8) */ >> +#define AIR_PBUS_ADDR_HIGH 0x1c >> +#define AIR_PBUS_DATA_HIGH 0x10 >> + >> /* Led definitions */ >> #define EN8811H_LED_COUNT 3 >> >> @@ -254,6 +264,36 @@ static int air_phy_write_page(struct phy_device *phydev, int page) >> return __phy_write(phydev, AIR_EXT_PAGE_ACCESS, page); >> } >> >> +static int __air_pbus_reg_write(struct phy_device *phydev, >> + u32 pbus_reg, u32 pbus_data) >> +{ >> + struct mii_bus *bus = phydev->mdio.bus; >> + int pbus_addr = phydev->mdio.addr + 8; >> + int ret; >> + >> + ret = __mdiobus_write(bus, pbus_addr, AIR_EXT_PAGE_ACCESS, >> + upper_16_bits(pbus_reg)); >> + if (ret < 0) >> + return ret; >> + >> + ret = __mdiobus_write(bus, pbus_addr, AIR_PBUS_ADDR_HIGH, >> + (pbus_reg & GENMASK(15, 6)) >> 6); >> + if (ret < 0) >> + return ret; >> + >> + ret = __mdiobus_write(bus, pbus_addr, (pbus_reg & GENMASK(5, 2)) >> 2, >> + lower_16_bits(pbus_data)); >> + if (ret < 0) >> + return ret; >> + >> + ret = __mdiobus_write(bus, pbus_addr, AIR_PBUS_DATA_HIGH, >> + upper_16_bits(pbus_data)); >> + if (ret < 0) >> + return ret; >> + >> + return 0; >> +} >> + >> static int __air_buckpbus_reg_write(struct phy_device *phydev, >> u32 pbus_address, u32 pbus_data) >> { >> @@ -570,10 +610,65 @@ static int an8811hb_load_file(struct phy_device *phydev, const char *name, >> return ret; >> } >> >> +static int an8811hb_mcu_assert(struct phy_device *phydev) >> +{ >> + int ret; >> + >> + phy_lock_mdio_bus(phydev); >> + >> + ret = __air_pbus_reg_write(phydev, AN8811HB_MCU_SW_RST, >> + AN8811HB_MCU_SW_RST_HOLD); >> + if (ret < 0) >> + goto unlock; >> + >> + ret = __air_pbus_reg_write(phydev, AN8811HB_MCU_SW_START, 0); >> + if (ret < 0) >> + goto unlock; >> + >> + msleep(50); >> + phydev_dbg(phydev, "MCU asserted\n"); >> + >> +unlock: >> + phy_unlock_mdio_bus(phydev); >> + return ret; >> +} >> + >> +static int an8811hb_mcu_deassert(struct phy_device *phydev) >> +{ >> + int ret; >> + >> + phy_lock_mdio_bus(phydev); >> + >> + ret = __air_pbus_reg_write(phydev, AN8811HB_MCU_SW_START, >> + AN8811HB_MCU_SW_START_EN); >> + if (ret < 0) >> + goto unlock; >> + >> + ret = __air_pbus_reg_write(phydev, AN8811HB_MCU_SW_RST, >> + AN8811HB_MCU_SW_RST_RUN); >> + if (ret < 0) >> + goto unlock; >> + >> + msleep(50); >> + phydev_dbg(phydev, "MCU deasserted\n"); >> + >> +unlock: >> + phy_unlock_mdio_bus(phydev); >> + return ret; >> +} >> + >> static int an8811hb_load_firmware(struct phy_device *phydev) >> { >> int ret; >> >> + ret = an8811hb_mcu_assert(phydev); >> + if (ret < 0) >> + return ret; >> + >> + ret = an8811hb_mcu_deassert(phydev); >> + if (ret < 0) >> + return ret; >> + >> ret = air_buckpbus_reg_write(phydev, EN8811H_FW_CTRL_1, >> EN8811H_FW_CTRL_1_START); >> if (ret < 0) >> @@ -662,6 +757,16 @@ static int en8811h_restart_mcu(struct phy_device *phydev) >> { >> int ret; >> >> + if (phy_id_compare_model(phydev->phy_id, AN8811HB_PHY_ID)) { >> + ret = an8811hb_mcu_assert(phydev); >> + if (ret < 0) >> + return ret; >> + >> + ret = an8811hb_mcu_deassert(phydev); >> + if (ret < 0) >> + return ret; >> + } >> + >> ret = air_buckpbus_reg_write(phydev, EN8811H_FW_CTRL_1, >> EN8811H_FW_CTRL_1_START); >> if (ret < 0) >> -- >> 2.34.1 >>