From: Bart Van Assche <bvanassche@acm.org>
To: Asutosh Das <quic_asutoshd@quicinc.com>,
quic_nguyenb@quicinc.com, quic_xiaosenh@quicinc.com,
stanley.chu@mediatek.com, adrian.hunter@intel.com,
avri.altman@wdc.com, mani@kernel.org, quic_cang@quicinc.com,
beanhuo@micron.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v3 4/4] ufs: host: qcom: Add MCQ support
Date: Thu, 8 Sep 2022 15:30:27 -0700 [thread overview]
Message-ID: <3ea54f9b-896d-c70b-9024-4dc4f99ec2d4@acm.org> (raw)
In-Reply-To: <260533ec3a80442b73d3999727bf0a9861462eba.1662157846.git.quic_asutoshd@quicinc.com>
On 9/2/22 15:41, Asutosh Das wrote:
> +static int ufs_qcom_get_hba_mac(struct ufs_hba *hba)
> +{
> + return MAX_SUPP_MAC;
> +}
The above implementation is not sufficient to convince me that the
get_hba_mac vop is useful. Please remove this vop and use MAX_SUPP_MAC
directly where ufshcd_mcq_vops_get_hba_mac() is called.
Thanks,
Bart.
next prev parent reply other threads:[~2022-09-08 22:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1662157846.git.quic_asutoshd@quicinc.com>
2022-09-02 22:41 ` [RFC PATCH v3 1/4] ufs: core: prepare ufs for multi circular queue support Asutosh Das
2022-09-05 12:26 ` Bean Huo
2022-09-08 3:00 ` Asutosh Das (asd)
2022-09-08 8:23 ` Bean Huo
2022-09-08 21:58 ` Bart Van Assche
2022-09-09 22:48 ` Asutosh Das (asd)
2022-09-09 23:38 ` Bart Van Assche
2022-09-12 18:18 ` Asutosh Das (asd)
2022-09-02 22:41 ` [RFC PATCH v3 2/4] ufs: core: mcq: Adds Multi-Circular Queue support Asutosh Das
2022-09-05 13:48 ` Bean Huo
2022-09-08 3:01 ` Asutosh Das (asd)
2022-09-05 14:19 ` Bean Huo
2022-09-05 16:27 ` Bean Huo
2022-09-08 3:01 ` Asutosh Das (asd)
2022-09-08 22:02 ` Bart Van Assche
2022-09-08 23:21 ` Bart Van Assche
2022-09-02 22:41 ` [RFC PATCH v3 3/4] ufs: core: Add Event Specific Interrupt configuration vendor specific ops Asutosh Das
2022-09-02 22:41 ` [RFC PATCH v3 4/4] ufs: host: qcom: Add MCQ support Asutosh Das
2022-09-08 22:30 ` Bart Van Assche [this message]
2022-09-09 22:43 ` Asutosh Das (asd)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ea54f9b-896d-c70b-9024-4dc4f99ec2d4@acm.org \
--to=bvanassche@acm.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bjorn.andersson@linaro.org \
--cc=jejb@linux.ibm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_xiaosenh@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®