From: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
Arnd Bergmann <arnd@arndb.de>, Heiko Stuebner <heiko@sntech.de>,
Eric Biggers <ebiggers@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Luca Weiss <luca.weiss@fairphone.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: linux-kernel@vger.kernel.org,
mohammad.rafi.shaik@oss.qualcomm.com,
ravi.hothi@oss.qualcomm.com
Subject: Re: [PATCH v1] arm64: defconfig: enable WCD937X codec driver as module
Date: Fri, 9 Jan 2026 13:03:58 +0530 [thread overview]
Message-ID: <3ea79961-7cc8-48be-a2fe-84303a570fb7@oss.qualcomm.com> (raw)
In-Reply-To: <dc514735-c1a9-4901-865c-052aef9ed12f@kernel.org>
On 1/8/2026 1:12 PM, Krzysztof Kozlowski wrote:
> On 08/01/2026 08:41, Krzysztof Kozlowski wrote:
>> On 08/01/2026 08:34, Ajay Kumar Nandam wrote:
>>> Enable the Qualcomm WCD937X SoundWire codec driver as a
>>> loadable module in the arm64 defconfig. This is required for
>>> audio support on platforms using the WCD937X codec over the
>>> SoundWire interface.
>>
>> Not a good reason. You wrote four lines of which all are redundant,
>> because you still did not prove we need to have support for WCD937x
>> Soundwire interface.
Ack, I will rework the commit message accordingly.
>>
>>>
>>> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
>>> ---
>>
>>
>> Look incomplete.
>>
>> https://lore.kernel.org/all/20240916052352.1819088-1-quic_mohs@quicinc.com/
>> https://lore.kernel.org/all/20241010052646.2597418-1-quic_mohs@quicinc.com/
>> https://lore.kernel.org/all/20241007082312.2136358-1-quic_mohs@quicinc.com/
>>
>> https://lore.kernel.org/all/?q=CONFIG_SND_SOC_WCD937X_SDW
>>
>> But anyway, you did the same as all patches before, so it won't be
>> applied. There is really no point in sending the same three four times.
>> Nothing will change, no one will apply it, unless you finally fix the
>> address list.
>>
>> You also Cc-ed here completely random addresses... E.g. why is this
>> relevant to Xilinx?
ack,
will resend an updated version with the correct maintainer and mailing
list CCs added using get_maintainer.pl for the relevant SoC.
Previously, I ran get_maintainer.pl on the arm64 defconfig instead of on
the SoC‑specific, which resulted in an incomplete and incorrect address
list. I will ensure this is done correctly going forward.
Thanks
Ajay kumar Nandam
>
>
> And I already said all this so you could have build on previous feedback
> instead of repeating exactly same two mistakes.
>
> https://lore.kernel.org/all/638a44fc-c693-4270-8643-7cd75a3c6ba6@linaro.org/
>
> Best regards,
> Krzysztof
prev parent reply other threads:[~2026-01-09 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 7:34 Ajay Kumar Nandam
2026-01-08 7:41 ` Krzysztof Kozlowski
2026-01-08 7:42 ` Krzysztof Kozlowski
2026-01-09 7:33 ` Ajay Kumar Nandam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ea79961-7cc8-48be-a2fe-84303a570fb7@oss.qualcomm.com \
--to=ajay.nandam@oss.qualcomm.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=ebiggers@kernel.org \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=krzk@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=michal.simek@amd.com \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ravi.hothi@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®