From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751364AbdJEGxr (ORCPT ); Thu, 5 Oct 2017 02:53:47 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:22447 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbdJEGxq (ORCPT ); Thu, 5 Oct 2017 02:53:46 -0400 Subject: Re: [PATCH 00/12] of: overlay: clean up device tree overlay code To: Rob Herring , Frank Rowand , Jyri Sarha CC: Pantelis Antoniou , David Airlie , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Rutland , dri-devel References: <1507002826-16393-1-git-send-email-frowand.list@gmail.com> From: Tomi Valkeinen Message-ID: <3eac16b0-fdd9-fd6c-e1ca-e0de49ce27cb@ti.com> Date: Thu, 5 Oct 2017 09:53:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v956rrVh001582  Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 04/10/17 17:56, Rob Herring wrote: > On Mon, Oct 2, 2017 at 10:53 PM, wrote: >> From: Frank Rowand >> >> I have found the device tree overlay code to be difficult to read and >> maintain. This patch series attempts to improve that situation. >> >> The cleanup includes some changes visible to users of overlays. The >> only in kernel user of overlays is fixed up for those changes. The >> in kernel user is: >> >> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c > > At what point can we remove this? I'm assuming at some point users > will need to update their dtb's for other reasons and this becomes > obsolete. To be honest, I have no idea, or how to find that out. Do we need to get rid of it? Afaik, we haven't do much (or any?) maintenance on tilcdc_slave_compat.c since it was written, so from our perspective it's been a minimal burden. Is it creating burden for others? Is the approach done with tilcdc_slave_compat.c something that's not recommended? I'm sure similar situations happen with other drivers too, and I think it's a good idea to have a recommended way of keeping compatibility. Tomi