From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A31350285 for ; Tue, 13 Jan 2026 19:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768332684; cv=none; b=t0fPWt67iF243JXODLXA4CR+YuKGutPWwazTnCOSHvIQTPhS3XdXLJ2gCLrTKWXPZQa8apx9cbWwjKaT3O4VEbn8dfyvInsZeGD/izrT/HINge2zK7l7v++BFZjeni5R3VhW+8Cle8AWaNAbZG+/G+6a/Z30AknAyIP4HPt5p1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768332684; c=relaxed/simple; bh=wzmMnNWWT6BfV1epUm9llBn9KAdtDYsf/ppiReTh1EY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qWlEZ6sU25Ctl4PgfSGGFyLCHLwTYomdYGkYS5fl81Cda6QpmfaBjAMsxdOTI/DvBYPyg3HWMh37ECGdICcQU4ha3/Jdzjyx1ivNFHIdE/1mA1wJmMV0fK0I0b3OV8M5z3bToBlY8LsHsFZtSYt4Tb17A/5e9792AVJHl+8bj7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=AeJg0F59; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="AeJg0F59" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so54126565e9.2 for ; Tue, 13 Jan 2026 11:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1768332681; x=1768937481; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=mZ+/SSm8Yk1STJqtuMveMdb2USAPK03seI/OasqORyI=; b=AeJg0F59PJmA20XDlgPDnX0Gj7Q5w5g3TQfJe756gDVYWawZ+7DysuoDyJ5oIAu/ne X/yyT/k/xKJRhMqJgFHw/hLJobXHsi+j9/omOIJCw+LEP0ByinmDqTHQh510nZ/+Jxbb 2rL5iFEegprUf8NUemUG3iM7msrGTzIZJ+JCwbMiEl68hE/h1oCkAWdkEs0f2KdoTR7X IASuRQmrpPH6Bi6YOUa6jXyP7A452Wn9XfK6Qoj+lvpvYlcm8IuWvf1SZYJXpldCVK4J GqzAIk8aRHZOUW4XwFfEzz68CEfzLiB1eme/ojQp50SFrV6NCIh4bjZNkgcZzwDrkQHL 2NJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768332681; x=1768937481; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mZ+/SSm8Yk1STJqtuMveMdb2USAPK03seI/OasqORyI=; b=R8UNBZwGVZqDYgos32vx6nZ0hrwBfZz/l4ShKNCSpN3rsCvmySi7M4Sa8fzndMcIlG ta6UknvzxAj5FgBKp56YyH+T4PTAE2nGA0KdsUQeqWKRk4hakwLKJVtKm6mE2qi3CFm5 XqpoPTGiijLcUns/lE9cg1z7JLNRHFDuKyjPDXwBjrkPsSFHKvsqbhB+/8M5w3tnReRz ieD2W8kQ81WNs1Jvu0xvzQdnTYUuxkhmJx9Bku4PtUw8lwAqNnPminWpJCzvQ+MZVZq6 dUWRS/ga/w6K3PJeVwNdcYaPmjzQePBuv4l0S+1y6x/pNzblJRPGRriy0w4DrryoU1Ha /98A== X-Forwarded-Encrypted: i=1; AJvYcCUgSEyyw0JaXxe20rJPvbjAz5PKvzI8racameUAJetc6lEWwpGjTfDfDcud656xAnTwo6wj0qxWyZqqrzw=@vger.kernel.org X-Gm-Message-State: AOJu0YxUGZcQi9JRgpur8qFhpULu9qEQ7eGdxxcorWg/U9HC8DZ73515 sA9ywpI0/GGtbz5XuUaDqp3FYLOVsKvHNuxg5g5myO9KXXlOyN88pHETpjgsnDfzumo= X-Gm-Gg: AY/fxX7/qlwZVOhJQuO2eAgkKPcHlxwBlVZesGmb7+XiGtmwk0TVUkHwxosR3wnVIOX D1UeMjLewmNIgySZk0DDyHeyKYaWWqjbb8w5hbS2qYbfjig3i/Dr4CUZhBbnV7VPZ4FPdfcQWIY Xv+btgjNptCFrfSSXp0hNFnwgG7CVXQ/q+yy1MWIPd9FgJmct9HtJbT3Cy5WogkpEosr5bE7S8K FUqq/4PYQe9zmyn4kqzaZEiR4ZIk7PEJHfX63Y4beeeMri9JJjReuQpUY9BJqkE5SMzPWMTK3eN wCWQnYTXBSSoAukyQjnGSYpEtKvKaoEDIVSyuDhxMfg2/9c18wItZV2Oc2wozIv11CzZe5+lBKT omRf6DLf30DMtiIsivdC4vYbmoVq50vi8tkbBejYRhHLBlm2R23oQVCMjOwiT5MGBQSGd250+qy 0k+X9OEUDMJeXnAzyD9mSl7UPkPTUn7pTTPp6AH/sVesgagjs= X-Received: by 2002:a05:600c:3acb:b0:45d:d97c:236c with SMTP id 5b1f17b1804b1-47ee3353e2emr3522635e9.21.1768332681559; Tue, 13 Jan 2026 11:31:21 -0800 (PST) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [85.187.217.240]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f7035f2sm402672305e9.12.2026.01.13.11.31.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 11:31:21 -0800 (PST) Message-ID: <3eaf01db-6f51-4125-a4bd-bc54c6576e28@suse.com> Date: Tue, 13 Jan 2026 21:31:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOetlOWkjTog562U5aSNOiDnrZTlpI06IFvlpJbpg6jpgq7ku7Zd?= =?UTF-8?Q?_Re=3A_=5BPATCH=5D_x86/mce=3A_Fix_timer_interval_adjustment_after?= =?UTF-8?Q?_logging_a_MCE_event?= To: "Luck, Tony" , Borislav Petkov , "Li, Rongqing" Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Yazen Ghannam , "Zhuo, Qiuxu" , Avadhut Naik , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" References: <20260112082747.2842-1-lirongqing@baidu.com> <36b42ced-f1e8-4eb0-b6f8-2a9434d5d26c@suse.com> <56d12335986e41da81581ef724742319@baidu.com> <20260112095118.GAaWTEFkUFHMlu0W-A@fat_crate.local> <268e2f0512db435685af987a2ba6893c@baidu.com> <20260113095111.GHaWYVj4Crd2z8oLp-@fat_crate.local> <39cfb093256f4da78fe0bc9e814ce5d0@baidu.com> <20260113124837.GHaWY_JVdFi53mh6oO@fat_crate.local> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13.01.26 г. 20:53 ч., Luck, Tony wrote: >>> The comment in mce_timer_fn says to adjust the polling interval, but >>> I notice the kernel log always shows an MCE log every 5 minutes. Is this >>> normal? >> >> Use git annotate to figure out which patch added this comment and in context >> of what and that'll tell you why. >> >> As to the 5 minutes, look at how the check interval gets established. > > Once upon a time the polling interval started out at 5 minutes, but the > interval was halved each time an error was found (so interval went > 150s, 75s, 37s, ... down to 1s). If no error was found, then the interval > was doubled (going back up to 300s). > > This is described in the comment: > > /* > * Alert userspace if needed. If we logged an MCE, reduce the polling > * interval, otherwise increase the polling interval. > */ > > It seems that the kernel isn't doing that today. Polling at a fixed 300 seconds > event though errors are being found and logged. Interesting that the timestamps > are 327.68 seconds apart, rather than 300 and change. So there is some strange > stuff going on. I think Li Rongqing patch does exactly that, since it predicates the halving/doubling of the interval based on whether an error was found and not whether it was reported to user space (what mce_notify_irq() ) does. Both concepts seems to be independent and the former being the core one we care about w.r.t to the decision how to adjust the interval, no ?