From: Shuah Khan <shuahkh@osg.samsung.com>
To: Timur Tabi <timur@codeaurora.org>,
corbet@lwn.net, richardcochran@gmail.com, wim@iguana.be,
linux@roeck-us.net, nab@linux-iscsi.org,
maheshkhanwalkar@gmail.com, arnd@arndb.de, ghackmann@google.com,
ben@decadent.org.uk, thuth@redhat.com,
christopher.s.hall@intel.com, john.stultz@linaro.org,
sergei.shtylyov@cogentembedded.com, mpe@ellerman.id.au,
jani.nikula@linux.intel.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v2 6/6] selftests: move watchdog tests from Documentation/watchdog
Date: Tue, 13 Sep 2016 14:48:55 -0600 [thread overview]
Message-ID: <3eb32f56-eac7-e0ca-0bcf-90488cbff458@osg.samsung.com> (raw)
In-Reply-To: <57D8628D.3070507@codeaurora.org>
On 09/13/2016 02:33 PM, Timur Tabi wrote:
> Shuah Khan wrote:
>> Remove watchdog-test from Makefile to move the test to selftests.
>>
>> Add Makefile and .gitignore to for watchdog-test. watchdog-test will
>
> to for?
Thanks - will fix that.
>
>> not be run as part of selftests suite and will not be included in
>> install targets. It can be built separately for now.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> Documentation/watchdog/src/.gitignore | 1 -
>> Documentation/watchdog/src/Makefile | 2 +-
>> Documentation/watchdog/src/watchdog-test.c | 105 -----------------------
>> tools/testing/selftests/watchdog/.gitignore | 1 +
>> tools/testing/selftests/watchdog/Makefile | 8 ++
>> tools/testing/selftests/watchdog/watchdog-test.c | 105 +++++++++++++++++++++++
>
> Please use -M when calling git-format-patch
okay.
>
>> 6 files changed, 115 insertions(+), 107 deletions(-)
>> delete mode 100644 Documentation/watchdog/src/watchdog-test.c
>> create mode 100644 tools/testing/selftests/watchdog/.gitignore
>> create mode 100644 tools/testing/selftests/watchdog/Makefile
>> create mode 100644 tools/testing/selftests/watchdog/watchdog-test.c
>>
>> diff --git a/Documentation/watchdog/src/.gitignore b/Documentation/watchdog/src/.gitignore
>> index ac90997..ff0ebb5 100644
>> --- a/Documentation/watchdog/src/.gitignore
>> +++ b/Documentation/watchdog/src/.gitignore
>> @@ -1,2 +1 @@
>> watchdog-simple
>> -watchdog-test
>
> Why not also watchdog-simple?
>
Is watchdog-simple a test or a sample/example? I thought this
is an example, and planning to move that under examples?
If this is a test, I will re-do the patch to include it.
thanks,
-- Shuah
next prev parent reply other threads:[~2016-09-13 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 20:18 [PATCH v2 0/6] Move runnable code (tests) from Documentation to selftests Shuah Khan
2016-09-13 20:18 ` [PATCH v2 1/6] selftests: move dnotify_test from Documentation/filesystems Shuah Khan
2016-09-13 20:18 ` [PATCH v2 2/6] selftests: move prctl tests from Documentation/prctl Shuah Khan
2016-09-13 20:18 ` [PATCH v2 3/6] selftests: move ptp tests from Documentation/ptp Shuah Khan
2016-09-13 20:18 ` [PATCH v2 4/6] selftests: move vDSO tests from Documentation/vDSO Shuah Khan
2016-09-13 20:18 ` [PATCH v2 5/6] selftests: move ia64 tests from Documentation/ia64 Shuah Khan
2016-09-13 20:18 ` [PATCH v2 6/6] selftests: move watchdog tests from Documentation/watchdog Shuah Khan
2016-09-13 20:33 ` Timur Tabi
2016-09-13 20:48 ` Shuah Khan [this message]
2016-09-13 20:52 ` Timur Tabi
2016-09-14 13:35 ` [PATCH v2 0/6] Move runnable code (tests) from Documentation to selftests Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eb32f56-eac7-e0ca-0bcf-90488cbff458@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=arnd@arndb.de \
--cc=ben@decadent.org.uk \
--cc=christopher.s.hall@intel.com \
--cc=corbet@lwn.net \
--cc=ghackmann@google.com \
--cc=jani.nikula@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maheshkhanwalkar@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thuth@redhat.com \
--cc=timur@codeaurora.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome