From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C25C3E6385 for ; Wed, 20 May 2026 15:22:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779290526; cv=none; b=V3kTpUH1utLzfq4paHpKWp9s9prUtI027Pp4Y6FUeMRq1U99HvIfDP/YzIrCRNMO1EkGmyPw3aWawGYOYdBHDWMh5X2awf43/FDGiQsAtTsbMfm0LBbb1IBimbHCbtCPkI8IClkS27v3KHf4apVMqYIvkKLUS9relPIlzwHEkAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779290526; c=relaxed/simple; bh=fGRWdGmID+QmR98D8vTN6LF5tP6p152gy2CBONfGav8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=akX3lxt4rYrKSaFKvWu4fzm17nhMemTCzOydb8Q1j8qCBaFgmNVtL6SE80hG3/Rb02yGfyLPW6uGgFPx91lUrcsUcS2CRXGJ2RT59nZ1FNZtr0kRLXiJFWUZkDWWTiDQcFYfHozsu7+/B4Cs/3XbW2zmr+qd1YaX8gx+JPZ9ybk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wQERnggN; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wQERnggN" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488a14c31eeso30874705e9.0 for ; Wed, 20 May 2026 08:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779290523; x=1779895323; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=8KET2vHo2aq0PvK8hVhMpVs4LUosq+8LLlurimYcSoc=; b=wQERnggNmgwnTsMAXeWRBt6uXBvbpSs3rMGD2CJ6FavTR5wcPl/Rl0ii6JExKU869H HKQa5oY0lHuzhGYLZS/0HVHgAyJLrKqljC3XNLhO8HSK3s9FmS9A8QMkcsRna4wSN0DC zgIGnjMKzEsYyXEIcw0njLrTzB5pTzVFfpik6Q7uvBwcyNBqh6Kbx6ng/Q1V9d49xs/8 It5AQUGWbl0MZnSSh8JjPvzPHDh8vrSA+iNrpHbh7ZkrTEd7o7f46sdm1m8pwKnRyTYa +L1rANh7Y4ZV8jU0DQUjdgXdOBxR0LGmXUqSqFqFMC1nwzCIxNmuZZzOy9C7vhvJQErK qiAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779290523; x=1779895323; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8KET2vHo2aq0PvK8hVhMpVs4LUosq+8LLlurimYcSoc=; b=TZ8bwgCxTzMTjW4HRBEC459C2KjC4HaHlU0LuSd7u+Ye6lFuV08AEGxxynDGszc2Wi GxphEHBMUuWRjauYwOg3SQ/3mwkKOh97yBlnG2yUBaBzyHQrFn2CHsf0/m6wv7n2VQC5 WhltY+m5uXQ/4StVN94yHgM6IKTxk49sI955OrHPoYAP1X+dwg5SnPpMniXQtVJG+UNu f930aQv8J7rqVxy+d4kMAprv1VL1joAeohXA1PZa6iT0vdKwbkgB1z5xrXtqoT/OmdJO dCIutn96p/Zqgih+i7aOPxLkcmE3dxM2ll6a77cu4/bpJKHWbmzNszF2cFIeiYoGXTXN tAbA== X-Forwarded-Encrypted: i=1; AFNElJ90GA/xJPN3rlLq5wbE8tvCGkqzekJknH2sDBOr+eAVZhNhmetk/5QrDcqfsk3H+WyZA3aPLxan+F0PLG0=@vger.kernel.org X-Gm-Message-State: AOJu0YydlYE51Kkego2mmGKX4jNMr0Lv0oZ9Fbi0moisDSHxgwmGeRib NQWpvRprNdc5B+3jWjvotslg/erPV50n7K3U3G/qTfXhj80GwwwQg3joymeFxPQ8zeM= X-Gm-Gg: Acq92OFS5qtvwmv7H97pdNX1Dyh5/khV6wzxdjsAvA4UfB7UW7ShOBRoqPvFKZrWjTw fCfMuZp1bO+SuG5dtQGdS4PSrwbsfQMZLdLm1TgfJzNQRdTjcmSLGE6+hKFM945oAq73AWhG9Dn xWtaVfY0kL8PR2RVzl2rkYHiSVgSe+CjS4Iy7OND+9Lp64nOXNJDLc5MutAa3QtgzstPsBtaLmw 9ifrHsgWfZitSqVp8TMV8N+y4AB2lcWs8rMlGqkM++spBm1HkfjOHe4/ubQpJqfUO+WiQiGRuPM fcyCpqY5O8YYgBCsLNo/yRctMrbgMRMOsj9V8OiISohng4JnummnxPbbUtD3fWEV6NSgyDuf//r 6uqqgDlxZ5/S23W7owum5Dag7JGci22M6ETQMdD7vF5qbtIAFqREtZBelclmykfdva3VnjEVvXn bxyhmYPpW+iYrAjGqdB9ugHssY/0yUR5rgqfFOxw997c38mi+MElqEhVh80eAlkJ7c+L2bTJ90l w== X-Received: by 2002:a05:600c:8b67:b0:489:1d74:56d with SMTP id 5b1f17b1804b1-48fe6325a52mr440005525e9.29.1779290522739; Wed, 20 May 2026 08:22:02 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:dec9:6d:b572:fe67? ([2a01:e0a:106d:1080:dec9:6d:b572:fe67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4c88e5asm439854935e9.6.2026.05.20.08.22.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 08:22:02 -0700 (PDT) Message-ID: <3eb84b5e-303f-457a-ba39-917c9becd81c@linaro.org> Date: Wed, 20 May 2026 17:22:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/8] video/hdmi: Add common TMDS character rate constants To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Maxime Ripard , Heiko Stuebner References: <20260520144424.1633354-1-javierm@redhat.com> <20260520144424.1633354-2-javierm@redhat.com> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260520144424.1633354-2-javierm@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/20/26 16:43, Javier Martinez Canillas wrote: > Several DRM drivers already define their own constants for minimum and > maximum TMDS character rates. > > By defining common rate constants in a shared header, drivers can just use > them instead of having driver local define macros or use magic numbers. > > The values defined in the header correspond to maximum TMDS > character rates defined by each HDMI specification version: > > - HDMI_TMDS_CHAR_RATE_MIN_HZ: 25 MHz (minimum for all versions) > - HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ: 165 MHz (HDMI 1.0 maximum) > - HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ: 340 MHz (HDMI 1.3 maximum) > - HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ: 600 MHz (HDMI 2.0 maximum) > > Suggested-by: Maxime Ripard > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Heiko Stuebner > --- > > Changes in v2: > - Change naming convention to HDMI_$SPEC_TMDS_CHAR_RATE_MAX_HZ (Maxime). > - Define the constants in (Dmitry). > > include/linux/hdmi.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h > index 96bda41d9148..8dab78e1f61b 100644 > --- a/include/linux/hdmi.h > +++ b/include/linux/hdmi.h > @@ -50,6 +50,12 @@ enum hdmi_infoframe_type { > HDMI_INFOFRAME_TYPE_DRM = 0x87, > }; > > +/* HDMI spec maximum TMDS character rates, in Hz */ > +#define HDMI_TMDS_CHAR_RATE_MIN_HZ 25000000 > +#define HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ 165000000 > +#define HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ 340000000 > +#define HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ 600000000 > + > #define HDMI_IEEE_OUI 0x000c03 > #define HDMI_FORUM_IEEE_OUI 0xc45dd8 > #define HDMI_INFOFRAME_HEADER_SIZE 4 Reviewed-by: Neil Armstrong Thanks, Neil