From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B62D2361C3 for ; Thu, 16 Jan 2025 19:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737054908; cv=none; b=QlT0jVPc09ucnVuWVSoGw9JgDgCOqv2eBbMP6UqAv0Jngds5dV5ERIBKUWY4GoC5zI580zRyT5QpDhzYLARZceqVNP1p7WjLuwb8Zp8E9fd4NtREfT6mezSPG8UACEHwUNZbFvFzoXLIaA0trD7CXeVeXfEWW+4zmojlj6Ix0ZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737054908; c=relaxed/simple; bh=+sEVtUCOEnvpxNGKeO34yA6I94hgCr0WaHKfF6gOIFk=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=JAcTihRC51aowHzH3onwrl73zuvgGoxkV5CoEcoyAVOjtQH8CRGzntQe+Z+BYrGkV5P9RMYVOYaFTRuOlsiTQi3Xzm7sfYAH06K+0XT8hCtjUAdC/GXzkWD4Ghb9q4bfxbgcetQeAz30CyrwwEfnp20aHb3MDl4iV6xv9cBz6KY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gsoU8HYL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gsoU8HYL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737054905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5wFn+zra1tRQHFTOaGuF8DRo9/yvU7g+Hng9H6HWePg=; b=gsoU8HYLVEVl12wx8W+ftr8QXIBSKniSh1dNPJdiw1i61sBWWTxU1gLG3dAArV+ydpjzg0 IOBRXpHrOQZUh8EN4tzDieNE7y2LQKEG17YTF2DQulNGfC2nUs9DI/agH4kfEdp+0ujdxh d3jIiAWpYUdMTAwWawCifcs5XsNcll4= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-r4Wks5q7PfawcB7Yd_VqYw-1; Thu, 16 Jan 2025 14:15:04 -0500 X-MC-Unique: r4Wks5q7PfawcB7Yd_VqYw-1 X-Mimecast-MFC-AGG-ID: r4Wks5q7PfawcB7Yd_VqYw Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-21632eacb31so16902855ad.0 for ; Thu, 16 Jan 2025 11:15:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737054903; x=1737659703; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5wFn+zra1tRQHFTOaGuF8DRo9/yvU7g+Hng9H6HWePg=; b=VwTOi3GRiMtXh5Y2RbRB7BrItTVJp9sfUo5EAiwQp2T/tHzfxRTrcGiaM+R4SDEZVc xTlRZWf4h4cncBG1JEfltVeKl6a+j7+VVl4BQftmUeKopaHy/FfOiR05voQrhqQ0sPeD lFxO424jMfDQXCkIFjVS6yRQfapIL8ll7Xx0eB/sr547PM2Rj5Lj7UcoE1DM6wDesq5W 5MqumYrYknFOEzhg41xmSAf+N/I00BLgdNfycuGFX4vLuEnk+JF0R7cbXRvBL7GwaMaQ 8lSvWp5hkS8NnkEpJRJ5qSQK3iSMdyWgI3lhskpcr7w9fmYv8yJzNovUZ2Qvn+rTx/tO uhJQ== X-Forwarded-Encrypted: i=1; AJvYcCV6fJKvMQMEeLIryVTu2rR2VSmutsKlnyStLSrofWggAPNO9Eyn2f+g5MURqPr/oSLF9folOJ1vZLA14VY=@vger.kernel.org X-Gm-Message-State: AOJu0YwmghdTOirsg2wS5mgrx/ZeaBknAPFus/CHZYmSde2fq1e17haW vyfiJkUBCQijYjiMgEWO1Jr95AR7vJt2mz0l9d9lFv50f3j6kAJAGwp5Twyec152QYfPu0A8mkc vPxiN4is4snvAJdV8GchqMoXmymg442ye4vMaebZK1Rx5Ig7yK47DXhKvTFbEIQ== X-Gm-Gg: ASbGncsN7PvQYmXsyjKx6zATldBcN62BFDG6iGtJDWymrZIHv5lafrctvgUc7mHF7j8 jum4ioXhQUdnb7EnLEpjMMgnutXvlhC/1DLw/QSuItFwyIFmx2MGDl5wy/PEclf9g+sFhKgVtaN eZ747RfYRNNwrFUMqcWRxJbuYL55Lm+39/s52nY4BaVMsOg2+lXaBYJo4+zgVz040lPc9fd1NR0 z57KlXZLOS2ZLKf5pwL20R8YPRGCSOtyY0ITeUbw5ZL+3EY3tq5gyaVwACNeJ0y4OdYvNyX4QAp 1JD4U6ZYQW7MdTTGfFu2qCNohG4= X-Received: by 2002:a17:902:cecd:b0:215:a2e2:53fe with SMTP id d9443c01a7336-21a83fde4e7mr603562175ad.40.1737054903074; Thu, 16 Jan 2025 11:15:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHuuJ4XE4YBqRpZVxDmAlIxqD3WtoUv4F8kqPqHW0nAAwQNqzy72sftRNmbnl4oMvOj2Y4Tug== X-Received: by 2002:a17:902:cecd:b0:215:a2e2:53fe with SMTP id d9443c01a7336-21a83fde4e7mr603561705ad.40.1737054902641; Thu, 16 Jan 2025 11:15:02 -0800 (PST) Received: from ?IPV6:2601:188:c100:5710:315f:57b3:b997:5fca? ([2601:188:c100:5710:315f:57b3:b997:5fca]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21c2cfbadb4sm3597405ad.102.2025.01.16.11.15.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2025 11:15:02 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <3ebd4519-4699-47ff-901e-a3ce30e45bcd@redhat.com> Date: Thu, 16 Jan 2025 14:15:00 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cgroup/cpuset: Move procfs cpuset attribute under cgroup-v1.c To: Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Waiman Long , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Chen Ridong References: <20250116095656.643976-1-mkoutny@suse.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/16/25 12:25 PM, Tejun Heo wrote: > Hello, > > On Thu, Jan 16, 2025 at 03:05:32PM +0100, Michal Koutný wrote: >> On Thu, Jan 16, 2025 at 08:40:56AM -0500, Waiman Long wrote: >>> I do have some reservation in taking out /proc//cpuset by default as >>> CPUSETS_V1 is off by default. This may break some existing user scripts. >> Cannot be /proc/$pid/cpuset declared a v1 feature? >> Similar to cpuset fs (that is under CPUSETS_V1). If there's a breakage, >> the user is not non-v1 ready and CPUSETS_V1 must be enabled. > I think we can try given that the config is providing an exit path. After > all, users who were depending on cpusets on v1 are in the same boat. I am not totally against this, but I think we need to make the relationship between the CPUSETS_V1 config and /proc//cpuset file more visible if we want to go this route. We should update the help text of CPUSETS_V1 config entry to emphasize this. Cheers, Longman