From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751666AbcELV64 (ORCPT ); Thu, 12 May 2016 17:58:56 -0400 Received: from smtp1.tech.numericable.fr ([82.216.111.37]:37303 "EHLO smtp1.tech.numericable.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbcELV6z (ORCPT ); Thu, 12 May 2016 17:58:55 -0400 To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org From: Barto Subject: [PATCH 1/1] revert commit 2c1f6951a8 videobuf2-v4l2 Message-ID: <3ec013bd-fb58-042b-4cef-f229e5c8c2e7@laposte.net> Date: Thu, 12 May 2016 23:58:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeekledrvddtgddtkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfpfgfogfftkfevteeunffgnecuuegrihhlohhuthemuceftddtnecunecujfgurhepvffhuffkffgfgggtgfesthejredttdefjeenucfhrhhomhepuegrrhhtohcuoehmihhsthgvrhdrfhhrvggvmhgrnheslhgrphhoshhtvgdrnhgvtheqnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfrrghrrghmpehmohguvgepshhmthhpohhuth Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org since kernel 4.5.3 a severe bug has been introduced with commit 2c1f6951a8a82e6de0d82b1158b5e493fc6c54ab ( [media] videobuf2-v4l2: Verify planes array in buffer dequeueing ), a system freeze will occur with TV cards ( DVB-T ), for example with "leadtek winfast DTV1000T", "leadtek winfast DTV1800H", "Avermedia" and many others, https://bugzilla.kernel.org/show_bug.cgi?id=118061 one quick fix is to revert this commit --- a/drivers/media/v4l2-core/videobuf2-v4l2.c +++ b/drivers/media/v4l2-core/videobuf2-v4l2.c @@ -74,10 +74,6 @@ return 0; } -static int __verify_planes_array_core(struct vb2_buffer *vb, const void *pb) -{ - return __verify_planes_array(vb, pb); -} /** * __verify_length() - Verify that the bytesused value for each plane fits in @@ -442,7 +438,6 @@ } static const struct vb2_buf_ops v4l2_buf_ops = { - .verify_planes_array = __verify_planes_array_core, .fill_user_buffer = __fill_v4l2_buffer, .fill_vb2_buffer = __fill_vb2_buffer, .copy_timestamp = __copy_timestamp,