From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A7A62367A2 for ; Wed, 4 Feb 2026 17:02:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770224543; cv=none; b=piCOQJUoKEhvx+M3RHeuztlAAkoCqsXVWGAM4beUUi/j5TjBUiitl3xSaLJtzmqk94GgQC6y3/iD5AJ3OhyWS4Eaxytwkd990sHdg0qCJTdOi45/t+Mz9IXcKuJhK5rII1/fwgPlS3aFSMkTJYeV+l1PWEUZjVFo4dYkf3lg1Hs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770224543; c=relaxed/simple; bh=nnHZV7AAqXqUQe1d4STMvjxcVhLgLzrieyguTS3hyRs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qjB6nrcGFRGTUDFmuxytYH5FWgh8WvKT/rTOkBbdYlSlIVEgNHcYyJhcQ5GALwezgEQD3XXDw6QHuiVwzQUdez+7W6TV4Lz6fweX9amiQS1cX9qnssXAGVxETg2/JkL3r+LXHXgzeOPxOticNxQYrX9Hs58zq0GUa+bOpRngNow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nVIWh3Td; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fZJVoKcR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nVIWh3Td"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fZJVoKcR" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614EGc97926598 for ; Wed, 4 Feb 2026 17:02:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l7TtHj/lcyNRtk/zB9O7SKyf9AfO0zCvDPAlhMJjLD4=; b=nVIWh3TdH4xB2dME o7yG7ali2uxi1kbp8C7BSvguGE0KNKwxGm6+vHAbmNGvRyXFQ6hHW5LLd/xjaeiw fO+xiMThzB6PIe7TPRB4PClittPLJauPhkii4n6RUtMztWh0yHZN4yLhcdmMJX6k Zvw5+lIbsZaxiJxsxnLFfbL/K6e4/dj2b2i4Cqj7efbg/Tmj9xsjvpxjGAPxRzwr lJMnnWKuyln/Wj54dzdEAndlyMKbS1cKOQH/MwtxQFU5esDv7vOEnqHmPdGDiwTR X9Oj7Af8DhnsF85UQYcPyUMdto0JV6hByLcy+z0JArZDChEzmCbJvjfPEUXLq62g g3G+Wg== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c47qv8jkb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 17:02:22 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7cfda67eeb7so2804a34.2 for ; Wed, 04 Feb 2026 09:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770224542; x=1770829342; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l7TtHj/lcyNRtk/zB9O7SKyf9AfO0zCvDPAlhMJjLD4=; b=fZJVoKcRu/jafiozGRFp4uEQNyrBZCUkmBFAIluqFK/kmO1mMd181+SkLD5X3L/o3X kIWwb5+htMSLh2MQ+CzkeNMTSVSH/E4f+gN/Eq7Z8GfIjCgoAhpujukVk2mTo4udmBFg xsIa0H4g7jBeYhXhti1DK/sN46XFbqWVDT7ajRnhNZ3lCKzU5eWopBHU9zIcF6O4r110 NuzzNz/8OwziRK7zQdTN8H9yYoYKk/8HdmZJJE1kI4EsyEsUAcaY/7fTu16TJR2wdVFa YWrFxuTx3lJPwl2J3jBjTUddiGhaqnDlqFYdtO9+BewpRa54ZnE+eNY4lSXk76cSZc+M AasA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770224542; x=1770829342; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l7TtHj/lcyNRtk/zB9O7SKyf9AfO0zCvDPAlhMJjLD4=; b=JItjUvJicz48DdVbHstCRZIJcxDsoJI7xT3xbVTeOkpPR6muKAk1aiS90G6NU4iiLL cr7mRpjvMVe8xbv8eFGzKjR8lI1PrSDJGnclvmTGnyjJ0+r/MArK7dUCnsEaeYMkuLoW 8lPgUtTc1RVVUxgTs9IldxRndl2uDU4euRrYHZhupzgbgz3wtqWD9rlTokZAWTYnunVB S8BousMeJ4P3A7d+8QRHv/ASxhDsZPBWRTqtkgF+JikJqBM2DbTbT6UFVf1MH17maAcm e41Dx8SNalTo7JJ7BJs6nrNMIbQeNWyl6GXeoFmL7P7e9VvOHTShwPaL642og0S6xjb9 /Hjw== X-Forwarded-Encrypted: i=1; AJvYcCWmhc+H3a3eBbhLVhLBauxMjfdPEmDVW0p30DQqZZD0Vd17IMGJC0XypKIlMUBLTZy8uVTvgZz1EFt8uXU=@vger.kernel.org X-Gm-Message-State: AOJu0YwYpH0ATUAkjLycP/WXbWrjCU+onnUpH2QMMs6YiGF4dInGBxkf qCHO98syJK7VJhj+psL0AiD4BC9acXhq50K2ScEqFejoLhwKWuKkD3BYLyXsxfsccp6mMcERE81 UpdeBKi+DxWo0Z4gVgDN3ebH/sSICGO1TXuTPhlSNyMQTf5uh9Yqx0UvH1YJuGgERQEI= X-Gm-Gg: AZuq6aLJgIjN5RT9WXFzcnF8V0ppeo95a/7pMcxpWax32XoDRKCQDVCdkuKJKFsfxWs S2L1AuoRGIjG1/qV75kmzXsOFFWQMAjL0Nl4XyhQw/u/Nplaevv6qK0AcI/lpg9Ro9EHOZQvvSj 0waCUlxpVDsfVmaufd9F22u17edAXGiUam+QiHBa6yI2ZD6s3jbqDEstENTYqK0dHsotOt7ibaN 5CThav7ZTZX1vXEeiPzGH7nriDnfH7n79M97uCAYz4vNQSOB7fZy+McLuO/fGfr1F3tvu7qfUeK dwmghorBRAKzi7Vbj0Q89lt7eNvgDvUOBp6G/8l0/FELc74tMnMRmW/r2ruFYDDzSTyiUVXYcXG I1lJ8UZ+W/YVKOcUwFh2/2Ew+CGfg7ibVor7HWDrgZzSitMClqWYq7BVom4ELbRrFFyg= X-Received: by 2002:a05:6830:3153:b0:7cf:d9a3:12c9 with SMTP id 46e09a7af769-7d44906702dmr1774024a34.7.1770224541744; Wed, 04 Feb 2026 09:02:21 -0800 (PST) X-Received: by 2002:a05:6830:3153:b0:7cf:d9a3:12c9 with SMTP id 46e09a7af769-7d44906702dmr1773924a34.7.1770224539871; Wed, 04 Feb 2026 09:02:19 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6594a228ed0sm1492639a12.29.2026.02.04.09.02.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 09:02:17 -0800 (PST) Message-ID: <3ec4b87c-f967-41c0-805d-27c62093e990@oss.qualcomm.com> Date: Wed, 4 Feb 2026 18:02:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] spi: geni-qcom: Fix abort sequence execution for serial engine errors To: Praveen Talari , Mark Brown , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260204162854.1206323-1-praveen.talari@oss.qualcomm.com> <20260204162854.1206323-3-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260204162854.1206323-3-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GaEaXAXL c=1 sm=1 tr=0 ts=69837b9e cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=2ADkXApKhB2aXO0F1dwA:9 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-GUID: X-rQTk0nq63e9UFJAZ6A4Rvmz2HI64Lx X-Proofpoint-ORIG-GUID: X-rQTk0nq63e9UFJAZ6A4Rvmz2HI64Lx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDEyOSBTYWx0ZWRfXxLvXZoypg6t9 RutBqdJnxny7PGqgRzmBROPENQvEWCelO8+7cYxhD8gYgGm/TH2XNgCFq+qZSuS2Ds8wxwwXIXn 1xeOm8cTJAi3SJoPzHuqPTtZlxjA/wQaUQu6lvMeuJVflLGGJVDvL7InxJOs3tAPt7RyyYSj3h3 XSsZiRG1jFKEx/kngTEU33hU4ir1YMdYZGAsEbrZYoRsNBUwVWlLnTphhtkmvYwOdoT8g65hzOH ZPc5nxk374lkcNBKaKJoVLi4IRlh5ok4AscXteaGMfSp84QsOYUp2b2LOoGOPLbF//yqXOQkIHt /FkPRged9JAxaDz8QB7QlhlWDtvZaRD8csBiWHfTKdIYeePYwLrgOoAeOGpWj/9QWSyBJZXEQiX ABzckyl7VQxzsnC6aFMpK5JHQ/0MoxH1gv9RpHtuRV7/tmjOy8A44J553QuluTnrJB7uckOaEK+ huCXGuON6ohcX+LYQ/g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_06,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040129 On 2/4/26 5:28 PM, Praveen Talari wrote: > The driver currently skips the abort sequence for target mode when serial > engine errors occur. This leads to improper error recovery as the serial > engine may remain in an undefined state without proper cleanup, potentially > causing subsequent operations to fail or behave unpredictably. > > Fix this by ensuring the abort sequence and DMA reset always execute during > error recovery, as both are required for proper serial engine error > handling. > > Co-developed-by: Konrad Dybcio > Signed-off-by: Konrad Dybcio Well I never left such a tag, but let's say I won't object too much.. (it potentially carries legal meaning) it's fine not to leave any sort of attribution for small changes or suggestions you receive during review, perhaps suggested-by if someone says "oh btw could you please look into fixing x in xyz.c too" for the code: Reviewed-by: Konrad Dybcio Konrad