From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753220AbdIEUhm (ORCPT ); Tue, 5 Sep 2017 16:37:42 -0400 Received: from mout.web.de ([212.227.17.12]:56893 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbdIEUhi (ORCPT ); Tue, 5 Sep 2017 16:37:38 -0400 Subject: [PATCH 1/2] ALSA: rme9652: Use common code in hdsp_get_iobox_version() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Arnd Bergmann , Bhumika Goyal , Jaroslav Kysela , Takashi Iwai , Takashi Sakamoto Cc: LKML , kernel-janitors@vger.kernel.org References: <9832906e-3b04-b708-2c26-4755e0beb811@users.sourceforge.net> Message-ID: <3ec86adc-18bf-b3f9-341b-9d0ae70256a8@users.sourceforge.net> Date: Tue, 5 Sep 2017 22:36:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <9832906e-3b04-b708-2c26-4755e0beb811@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:VtUj7gOnyW6UYw2eNpF56XBE/s02ISgvXv0HA2CcVyhxiQOztet zNC3szTNEyw16nwgHZLGllrrG+XT6YeB5VYLI8NVWNERCYwJtI3vglT4hdPFRrFSvd4XlR4 ze0VsDa8OMw2k7EHriwcBD3pYTXgg8+JQUlEToB62ihvfozAZi691jt3yVySCVhvHHWs4L2 cH+dKfMkkMTM3GjY+9lEA== X-UI-Out-Filterresults: notjunk:1;V01:K0:vvm36hLtybk=:PBH+hiKEwqzuIfxpFXMLKH bHKKdFFNI0ReYwtYY6aTWuTZtRx7Vg+EECZdLqIVnOVPtbnBXGRKFQJ5b1PqEWA/fo+rtsQ4E COGHCeVg1PpBjlCEeZm0QrbVXvjBw85KSqav/p0BMjSf5XTYHSME1NNOtUYcdYxglGtDLxUfl oO7dcQuJZ8ST12AaiVkpRcnwryKCfFV5lQzzE4u0B+zZMdI/VErZEg8vicO0YzQAEh/LktqfW nY9YscOFoL69pwphsHEMB89sBJzAReAZDQyKATb8rDSIgESY0Xc3PMaXZ/NZ7vIprKZQxPp9S pReX8MvHb8Ebfnf/jS30fQZo3UE+cQgYS4xq3WrEzrHvp2W+r+tE0eKya4k5b2aeCpDGvAZkV Xz04P0U0mgnnkuSJ/b7JgdfQGITW6B3edTY/vkgstT+uvxy+Bj5YHiZBBwjkAhyVfb4iMuMzW 7re/JPLLUhKh6fVUInmyf/0hcBKtrMUzA8S47dh0e+F5G0W23JfHmFaXO81MMUqZRtTJbl3Pd 2iIYJRGDNckubxpqoM7sI74IiYX77Ouo8q397GS/Qmq4oI8mTWNrNzYlr7WVFDkOKH6TMPgSu gBdVfbbGPfIgoqOeOikcRZAKlNGyQvU0tPMC1Bz+qo80VQJqW2ilguCAP9nAGXWM7kre4k9Jw EPNoI5XuhEwM8ZNJT/5h4jw81P4yUYY1mNYWJX1o57yRl4ggP8sXAfCV8we3/Itlofw8QP6Z7 Zubg5+/2Vm4XsA0BZuFribKdlwWqiPfhSomPzZiIvRgT+eCJl5x0DiZ/qKCMa0yMeh579e2KA YLCkJ6yF2BjfMyh4I49egxJxPndfNq5+pzUOgO4249tRayS0NA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 5 Sep 2017 22:08:30 +0200 Add a jump target so that a bit of common code can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/pci/rme9652/hdsp.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 0ff41f9ab434..9f0f73875f01 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -793,11 +793,8 @@ static int hdsp_get_iobox_version (struct hdsp *hdsp) hdsp_write(hdsp, HDSP_control2Reg, HDSP_S200 | HDSP_PROGRAM); hdsp_write (hdsp, HDSP_fifoData, 0); - if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) < 0) { - hdsp->io_type = Multiface; - dev_info(hdsp->card->dev, "Multiface found\n"); - return 0; - } + if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) < 0) + goto set_multi; hdsp_write(hdsp, HDSP_control2Reg, HDSP_S_LOAD); hdsp_write(hdsp, HDSP_fifoData, 0); @@ -810,20 +807,14 @@ static int hdsp_get_iobox_version (struct hdsp *hdsp) hdsp_write(hdsp, HDSP_control2Reg, HDSP_S300); hdsp_write(hdsp, HDSP_control2Reg, HDSP_S_LOAD); hdsp_write(hdsp, HDSP_fifoData, 0); - if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) == 0) { - hdsp->io_type = Multiface; - dev_info(hdsp->card->dev, "Multiface found\n"); - return 0; - } + if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) == 0) + goto set_multi; hdsp_write(hdsp, HDSP_control2Reg, HDSP_S300); hdsp_write(hdsp, HDSP_control2Reg, HDSP_S_LOAD); hdsp_write(hdsp, HDSP_fifoData, 0); - if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) < 0) { - hdsp->io_type = Multiface; - dev_info(hdsp->card->dev, "Multiface found\n"); - return 0; - } + if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) < 0) + goto set_multi; hdsp->io_type = RPM; dev_info(hdsp->card->dev, "RPM found\n"); @@ -838,6 +829,11 @@ static int hdsp_get_iobox_version (struct hdsp *hdsp) hdsp->io_type = Digiface; } return 0; + +set_multi: + hdsp->io_type = Multiface; + dev_info(hdsp->card->dev, "Multiface found\n"); + return 0; } -- 2.14.1