From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 853E5179BF for ; Mon, 27 Jan 2025 10:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737973412; cv=none; b=HbaAZQOpzQot3keM/VhGvKnh+GDhAHVzPgVmZgQZsdOjJIYkBQFy83w9C3B3Vr6YkJacdw6J19/aUD85VNus9MqS3wa6Q3qcIr/WCGe7iOGbLp1oP76x555/C/BeQOFyalp883Ff7y+hRvhma1tMFwtrfcIivoX7zsRLZTBfnI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737973412; c=relaxed/simple; bh=/ziQCxNO8jspCZEWeweEbldQZWZOoyzeslfitT30Ucs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E0i8AnnwsRhazJotdlfZy+4y9GfFY6YgSCmSId9l8MJWn4JFEiKTf0IZzIBRvmW+nUKNhmu2EQ0O9ABNDc5FhEv737iAUqLUOXGIiYW+hlToq4mo05OkETldRTXXE0vsVCaVcan/R3jlixgAjDwagp+0ZNrZGgQVlafox5ssIF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DJFwnw47; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DJFwnw47" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50R0ppYn012193 for ; Mon, 27 Jan 2025 10:23:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hGB5OVb68LNt8gE8AS+bpnEVv8dQ+ZWfbCKV+Fgql1s=; b=DJFwnw47aPPLlcK9 HWN/KcRu8+0A34vgbRvLmEldSMPh61ljyB/ekcDy+FL3+geO6HqAyWgMRDuI0fYb yLY+szCFQQD60ymx13gFrE2Wgd+fapD/uLeu0jBCL4+cZCmcnujYIis3+SMoVj/v d0RHHqAZ8+IgKFt2juXwKcQrrCiZ2mp+Hbejtc5HTir3FdL7S5YIFKPNVYKiaQmC VZVoefqy5JaV8/K1eGqSln3oDHCSBMrsi3gz8/+JxdR/HvIxhfDGIDhnQp8NgtTB qIYLtgHRfUasMIxWRJO8KZvcwRTGmutW3QUbeAJNnP2aRo5QvnLRHTBdkHqBBSQH lJo43A== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44dsav1a12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 27 Jan 2025 10:23:30 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-467a437e5feso12436631cf.0 for ; Mon, 27 Jan 2025 02:23:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737973409; x=1738578209; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hGB5OVb68LNt8gE8AS+bpnEVv8dQ+ZWfbCKV+Fgql1s=; b=KIpPO+YQ1+01BTsWwYh2E/K7u3xe2tfP2FfFNy3ZQo7LCEySs1UK3y9IyAq+lG5kcS 8SbVVUPYn246hxCL0v0eUeMgmKsK3TrhtF4tV0PFYK3bnV/iFozeOncLnYjVtiLGBFvr koGgKHOv3PLZjC8dqr68viQ3LMcDnrpxyz/qoZC7IM8Z2NNwpKCcxIsPnF+Mu2rKuoHK +o6Sq8SKU5BqAYg9BZ9ZkZituFHSZ2HpxKiEkDNvE/7vS7Q5jBDd9dR9oeS42ndGIk4N 7PV6gQlAfXFfA+elFM0Cn0Y/4tkUtncQtKxDPGodPub3KhulJuCrvXGPXgC8Asrbf8h3 koFA== X-Forwarded-Encrypted: i=1; AJvYcCUVShM6amAYkXWFDVKLGiKGoEQiyA7xYZZotwkAgk1EZWq4vARH0mw5T2QHG+16u2aUlt7M6hyyjy7INsE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywhb2iAUW+35OBn6uBM7Z19/FJ9CtDn8YUMqC3ZbqOu4nBjgF/r gNMDA91J64Y4R08SELtdfWdRwEHLyPy8AcWrTpuBjPg6rqU9OTkZ2H50x73N3m4hfHnRvco9yO1 uPMI6Wo99h+x0WsuV8HcAkYrtoae043jbpV6zUxlTqY7fmITYroNtaeUypQBOPfE= X-Gm-Gg: ASbGnctVtLwxRo1peitQLOe1oWj5oxWwOY7AnOOwgM6YVQy+FVbTRgY9llMWY/99eek im0NBHCa4foDbEHlNAQqkjSaM8nQ39IPi5GVfryudjhxfV7X71YvucetP2Fu49vtGox2B6d8AfR 6WGANoHSuD7NWy+V6WG0tGuph5aVJ6yFsKyQynU17mCwyjXVqgSYiUWViHubF+L67adG/1wub4z j7Am00F9VRT6Lom4wKYww48BhbijxhtAZkCh3wxh1XALtpzt3L+eeIaV2/h3rRLOE5TGNvRBfeK 7EiVzr5Ut//TTKFjpNzBlxbUk1DBcR0FI9iy2R5Dm6s/ufzPmvSPPYm8vVo= X-Received: by 2002:a05:622a:1aa0:b0:467:825e:133b with SMTP id d75a77b69052e-46e12ba1478mr227274501cf.13.1737973409368; Mon, 27 Jan 2025 02:23:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhhZmUefm+tAZLgJqV2ZW+k6GYLfZ7Ycaf8L6tOGjzPWuZ8gyIBxlMk/OY2hdBHc96AIiM+Q== X-Received: by 2002:a05:622a:1aa0:b0:467:825e:133b with SMTP id d75a77b69052e-46e12ba1478mr227274371cf.13.1737973408993; Mon, 27 Jan 2025 02:23:28 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab675e11a1esm562672266b.33.2025.01.27.02.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 02:23:28 -0800 (PST) Message-ID: <3ed5858c-3030-4edc-847d-28ff54ea5aea@oss.qualcomm.com> Date: Mon, 27 Jan 2025 11:23:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC To: Melody Olvera , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , Bjorn Andersson , Andy Gross , Konrad Dybcio , Satya Durga Srinivasu Prabhala , Trilok Soni Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nitin Rawat , Manish Pandey References: <20250113-sm8750_ufs_master-v1-0-b3774120eb8c@quicinc.com> <20250113-sm8750_ufs_master-v1-4-b3774120eb8c@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250113-sm8750_ufs_master-v1-4-b3774120eb8c@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: dMtb2Cii3io3wYIqjWaCyaQ1QnIML21u X-Proofpoint-ORIG-GUID: dMtb2Cii3io3wYIqjWaCyaQ1QnIML21u X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_04,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501270083 On 13.01.2025 10:46 PM, Melody Olvera wrote: > From: Nitin Rawat > > Add UFS host controller and PHY nodes for SM8750 SoC. > > Co-developed-by: Manish Pandey > Signed-off-by: Manish Pandey > Signed-off-by: Nitin Rawat > Signed-off-by: Melody Olvera > --- I don't see anything wrong per se here, just some style nits atop the other replies: [...] > + ufs_mem_hc: ufs@1d84000 { > + compatible = "qcom,sm8750-ufshc", "qcom,ufshc", "jedec,ufs-2.0"; 1 compatible per lines, please > + reg = <0x0 0x01d84000 0x0 0x3000>; > + > + interrupts = ; > + > + clocks = <&gcc GCC_UFS_PHY_AXI_CLK>, > + <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>, > + <&gcc GCC_UFS_PHY_AHB_CLK>, > + <&gcc GCC_UFS_PHY_UNIPRO_CORE_CLK>, > + <&rpmhcc RPMH_LN_BB_CLK3>, > + <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>, > + <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>, > + <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>; > + clock-names = "core_clk", > + "bus_aggr_clk", > + "iface_clk", > + "core_clk_unipro", > + "ref_clk", > + "tx_lane0_sync_clk", > + "rx_lane0_sync_clk", > + "rx_lane1_sync_clk"; > + freq-table-hz = <100000000 403000000>, > + <0 0>, > + <0 0>, > + <100000000 403000000>, > + <100000000 403000000>, > + <0 0>, > + <0 0>, > + <0 0>; > + > + resets = <&gcc GCC_UFS_PHY_BCR>; > + reset-names = "rst"; > + > + > + stray double \n Konrad