From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: dianders@chromium.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings
Date: Mon, 7 Aug 2023 08:32:09 +0200 [thread overview]
Message-ID: <3ed8a34b-5f7d-6547-7e34-35e4d0994bba@linaro.org> (raw)
In-Reply-To: <20230804175734.v2.1.I7a950de49ec24b957e90d7fe7abd5f2f5f2e24c3@changeid>
On 04/08/2023 11:58, Sheng-Liang Pan wrote:
> Introduce more sc7180-lazor sku and board version configuration,
> add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> add new board version 10 for audio codec ALC5682i-VS.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
>
> Changes in v2:
> - add new entry rev9 with Parade bridge chip
>
> .../devicetree/bindings/arm/qcom.yaml | 55 +++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..dce7b771a280 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -470,6 +470,11 @@ properties:
> - const: google,lazor-rev8
> - const: qcom,sc7180
>
> + - description: Acer Chromebook Spin 513 Parade bridge chip (rev9)
> + items:
> + - const: google,lazor-rev9
> + - const: qcom,sc7180
> +
> - description: Acer Chromebook Spin 513 (newest rev)
> items:
> - const: google,lazor
> @@ -491,6 +496,11 @@ properties:
> - const: google,lazor-rev8-sku2
> - const: qcom,sc7180
>
> + - description: Acer Chromebook Spin 513 Parade bridge chip with KB Backlight (rev9)
> + items:
> + - const: google,lazor-rev9-sku2
> + - const: qcom,sc7180
> +
> - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
> items:
> - const: google,lazor-sku2
> @@ -512,11 +522,26 @@ properties:
> - const: google,lazor-rev8-sku0
> - const: qcom,sc7180
>
> + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE (rev9)
> + items:
> + - const: google,lazor-rev9-sku0
> + - const: qcom,sc7180
> +
> - description: Acer Chromebook Spin 513 with LTE (newest rev)
> items:
> - const: google,lazor-sku0
> - const: qcom,sc7180
>
> + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE no-esim (rev9)
> + items:
> + - const: google,lazor-rev9-sku10
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with LTE no-esim (newest rev)
> + items:
> + - const: google,lazor-sku10
> + - const: qcom,sc7180
> +
> - description: Acer Chromebook 511 (rev4 - rev8)
> items:
> - const: google,lazor-rev4-sku4
> @@ -526,6 +551,11 @@ properties:
> - const: google,lazor-rev8-sku4
> - const: qcom,sc7180
>
> + - description: Acer Chromebook 511 Parade bridge chip (rev9)
> + items:
> + - const: google,lazor-rev9-sku4
> + - const: qcom,sc7180
> +
> - description: Acer Chromebook 511 (newest rev)
> items:
> - const: google,lazor-sku4
> @@ -545,11 +575,36 @@ properties:
> - const: google,lazor-rev8-sku6
> - const: qcom,sc7180
>
> + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen (rev9)
> + items:
> + - const: google,lazor-rev9-sku6
> + - const: qcom,sc7180
> +
> - description: Acer Chromebook 511 without Touchscreen (newest rev)
> items:
> - const: google,lazor-sku6
> - const: qcom,sc7180
>
> + - description: Acer Chromebook 511 Parade bridge chip no-esim (rev9)
> + items:
> + - const: google,lazor-rev9-sku15
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 no-esim (newest rev)
> + items:
> + - const: google,lazor-sku15
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen no-esim (rev9)
> + items:
> + - const: google,lazor-rev9-sku18
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 without Touchscreen no-esim (newest rev)
> + items:
> + - const: google,lazor-sku18
All of these entries (existing and new) should be just one entry with:
- enum:
- ....
- ....
- const: qcom,sc7180
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-07 6:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 9:58 [PATCH v2 0/3] Add no-esim sku for sc7180-lazor family and new board version Sheng-Liang Pan
2023-08-04 9:58 ` [PATCH v2 1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings Sheng-Liang Pan
2023-08-04 16:30 ` Doug Anderson
2023-08-07 13:37 ` Konrad Dybcio
2023-08-07 6:32 ` Krzysztof Kozlowski [this message]
2023-08-15 20:41 ` Doug Anderson
2023-08-15 20:46 ` Krzysztof Kozlowski
2023-08-04 9:58 ` [PATCH v2 2/3] arm64: dts: qcom: sc7180: Add sku_id for lazor/limozeen Sheng-Liang Pan
2023-08-07 6:35 ` Krzysztof Kozlowski
2023-08-04 9:58 ` [PATCH v2 3/3] arm64: dts: qcom: sc7180: Add board id " Sheng-Liang Pan
2023-08-04 16:30 ` Doug Anderson
2023-08-07 6:34 ` Krzysztof Kozlowski
2023-08-15 21:10 ` Doug Anderson
2023-08-15 21:22 ` Krzysztof Kozlowski
[not found] ` <eb082e10-efc2-0f5f-95e1-4d2707c87c59@linaro.org/>
[not found] ` <20230816095910.41305-1-sheng-liang.pan@quanta.corp-partner.google.com>
2023-08-16 18:31 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ed8a34b-5f7d-6547-7e34-35e4d0994bba@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sheng-liang.pan@quanta.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®