From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBF5E30D407 for ; Mon, 3 Aug 2026 02:08:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785722921; cv=none; b=iqOSwCsLHmtpw8DVZIz+Sejnum7Wpvz63mUIUEsU6/Cg7Dt0F4GscS2HgoporiqbwVW2UC/UI3fYY2DEEt5e0mdpZRV+NhUigzVhWqRsA4zJDMXTQ778QNlsx61mVNAd48bn2Dd+29njeWMKttL+He9zR+S3u7euhIgHnOv4COM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785722921; c=relaxed/simple; bh=EFW8b0SPtFoKq7V97+Exp9hgQfZXUFlg6uxyJG168wQ=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=DsnO9RHSD92oMuLBy6Dy+4PFiMuBDc4ePOb4JhuSWSObTt4STiDg/xMNpfV6Y6G8kgn+bcTdIJgyjSJkb97ZnQNH2CJTN7w5YLURILnMQk41WabOB+TuRH2naUgo3+FycbAsSnAGjTA7tOCKSpu5FBPw33k0Oa1S8rvjsnAU8H4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G6FeoOZf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G6FeoOZf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2804D1F000E9; Mon, 3 Aug 2026 02:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785722920; bh=akXWdnMvBxguKVgRZUt8MGf93stsSK4rwcrXnjHtvIU=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=G6FeoOZf9L3vR0tKh67td8aotR1b5qA7rGBF3KGuhCy4A7YQgUuaPtO9pA9a5UKny JmyG1dEC38HNLMMhcbQv7kEIz01ww/WSc4/yAiQcaEXNxAPE2n8RfXb+UoL9KduE69 HHc5R0DUuFMm8Jipi4zrG1p1AYOEJ2aBipc3Y6Ldh8cLAef61JzMHHP/yNoQfiWg+V FABS6/C8lYfIPtwRRqxzDXDFr9rsZiCkVPPuZLLd0VzYgqX20ka+MfMx476cG8dgwy VDL3UV663Yyt3T0Ix7rM65czUq6OwmSjoUJZXWRIsYZKHpG36X3r6dEaVJzUXN9cfd 8CxR4+3w7G5Jw== Message-ID: <3edacd16-9112-4470-9b59-b5a8edf25eb9@kernel.org> Date: Mon, 3 Aug 2026 10:08:37 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fsck.f2fs: drop unused SB_ENCODE_FLAG To: Chunhai Guo , jaegeuk@kernel.org References: <20260605100559.94843-1-guochunhai@vivo.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260605100559.94843-1-guochunhai@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/5/26 18:05, Chunhai Guo wrote: > Since commit 29c1e18a0bc5 ("fsck.f2fs: tune linear_lookup in > f2fs_do_mount()"), fsck_update_sb_flags() writes the superblock directly > and nothing sets c.invalid_sb with SB_ENCODE_FLAG anymore. Drop the dead > flag and simplify the SB_NEED_FIX check. > > BTW, SB_ENCODE_FLAG should originally have been 0x10, not 0x16, since > invalid_sb is a bitmask. > > Signed-off-by: Chunhai Guo Reviewed-by: Chao Yu Thanks,