From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
wuqiang.matt <wuqiang.matt@bytedance.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH] lib: test_objpool: add missing MODULE_DESCRIPTION() macro
Date: Thu, 11 Jul 2024 11:14:20 -0700 [thread overview]
Message-ID: <3edb1529-744c-4b7a-acc9-12e166ada738@quicinc.com> (raw)
In-Reply-To: <20240603154549.4a338c065e42f07c8c3d1b82@kernel.org>
On 6/2/24 23:45, Masami Hiramatsu (Google) wrote:
> On Mon, 3 Jun 2024 11:25:59 +0800
> "wuqiang.matt" <wuqiang.matt@bytedance.com> wrote:
>
>> On 2024/6/1 08:31, Jeff Johnson wrote:
>>> make allmodconfig && make W=1 C=1 reports:
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_objpool.o
>>>
>>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>>
>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>> ---
>>> lib/test_objpool.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/lib/test_objpool.c b/lib/test_objpool.c
>>> index bfdb81599832..5a3f6961a70f 100644
>>> --- a/lib/test_objpool.c
>>> +++ b/lib/test_objpool.c
>>> @@ -687,4 +687,5 @@ static void __exit ot_mod_exit(void)
>>> module_init(ot_mod_init);
>>> module_exit(ot_mod_exit);
>>>
>>> -MODULE_LICENSE("GPL");
>>> \ No newline at end of file
>>> +MODULE_DESCRIPTION("Test module for lockless object pool");
>>> +MODULE_LICENSE("GPL");
>>>
>>> ---
>>> base-commit: b050496579632f86ee1ef7e7501906db579f3457
>>> change-id: 20240531-md-lib-test_objpool-338d937f8666
>>>
>>
>> Looks good to me. Thanks for the update.
>>
>> I added Masami Hiramatsu and linux-trace in the loop.
>>
>> Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com>
>
> Thanks, let me pick this to probes/for-next branch.
Following up since I don't see this in linux-next.
I'm hoping to have these warnings fixed tree-wide in 6.11.
/jeff
next prev parent reply other threads:[~2024-07-11 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-01 0:31 Jeff Johnson
2024-06-03 3:25 ` wuqiang.matt
2024-06-03 6:45 ` Masami Hiramatsu
2024-07-11 18:14 ` Jeff Johnson [this message]
2024-07-15 8:30 ` Masami Hiramatsu
2024-07-15 9:12 ` Masami Hiramatsu
2024-07-15 14:25 ` Jeff Johnson
2024-07-15 16:11 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3edb1529-744c-4b7a-acc9-12e166ada738@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=wuqiang.matt@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®