From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92CFF377EA5 for ; Wed, 18 Mar 2026 09:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773824738; cv=none; b=qw85ySj9AGs/m39hO6NMgOeIo0HhvdOuuTWV1X3XlaosgGZxFsJQ7i7u6JNsmTG/noYI5yq7KPCaHzDaGdnd1RmtAnkHF/Yz4mGPM3bVXUsqMd9nzWqqM/0xiLL0jnryByfyO3airHFc56dMmCGggQX7sla7+ZJNrODgas9wjrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773824738; c=relaxed/simple; bh=9sLPdfZdOTRGWkdHWAt4deRhUQbSXz3/+uenBwBgRH8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ta96CBnQAvGMq/4yu7QCnwDWeP+pljT0VdnYJZmaukJ4OoMAeaJL2Cxfooy50vcvOKbc9PvBgVPS7ePl6EBZgxJ6L2+DcP2WlDk5YehYAcghq3HAhkyAHe/nrOzTPbGcZui2BgmLILpEcs6iypifsT6yzXT6+x4FK8ABsfcrsuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZuhnP2iC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PTXSOPIO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZuhnP2iC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PTXSOPIO" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62I3Ud6g1370831 for ; Wed, 18 Mar 2026 09:05:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BMDtEQ0NH96TVBLji2qMk3/V2u0vd9jPzqt2rV4TdqM=; b=ZuhnP2iCJCvDVGmL DADwgaXrWKJVf0KgZV8BSCT6O4zDnbWbpdMPsZxHO8zJ+ceYk8ALdw7Jaf4x7C6d BhDJnY3I4UYHFOdkAvplecE3KrAaGvIgCfc0o9G7OKR1VaZcE/bB+n+YizTfvVhZ Ln/JdjckJ8Z2a9rO4qmXvdb9JbvLiC3+TTc9NJ2b0qCwBfh1zcaryo2l2Beyc2Kv 7mcYjaRp97Gy5X34Tro3hnQ1VJu7j2mXAsm6LrXl/fi44smzzPakHX8t5zczITKX lC+TKpoSuDAHDuZiQcpxM6EaKo3kkyDWMVgauuqEyiujZoaY+yuygO9mXN9iDba5 BK8VOw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy7he47hq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 09:05:36 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c6e24ee93a6so512633a12.0 for ; Wed, 18 Mar 2026 02:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773824735; x=1774429535; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BMDtEQ0NH96TVBLji2qMk3/V2u0vd9jPzqt2rV4TdqM=; b=PTXSOPIOz+9KLnubmnBmVyy99Kyne4cTV8SX8RvcFw4VP78XPwA2BjebhdbwoPPD6N vogiLf2bdbk7Wcj8xBhOHCAxCsCDCvkPEq6jw3WpvRZv/5kDa0r0/8p5C+HuVD3R19Cp SCe0+Q+cUDH6TjC0jihQVZG5n4Q0q4FVxmrMeZ+AoOEdVfldnSj8XSD5Z3eGA6ewtCEK 4tVP3tetb04N4nCkd/VUTm7z8ECYdeResBt0dRDxsvdQfAkzHMoEcHTNHSBdKczNGU9O H4wNvfpxHnyCcs1ehT/v+NYv55JkaSNOu+qBfw8FZVkG994lv5OntiwD/CducPiHJZqp VlHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773824735; x=1774429535; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BMDtEQ0NH96TVBLji2qMk3/V2u0vd9jPzqt2rV4TdqM=; b=YCU1/sijL++Ync6aZjDUJooNqLv9fMHJYSvawf+XUd+9/4sW3I2Dld0FTqxWiXsu/R C81k3Ga7rlNhehCaEnogUKA45y5Vc85/LEdj4pmpIlPU2osed4YuQVjAdoK8DDp22bmb ggEQfYJrNBJKzbjxOLGQRUAwikzmiDgzZ0YW0QXWNklRuBVD7cfWUqMg2UMHLoPpPvWW WZIkTIO6ZMJALVmC8Bb6BnUusJn0Mb/jPXfFAhRC1n2mefFlE2x5nNwagpB92NRG0OjG SiAKmlwUpRYYeN6sS/mTm1+tZvtGCBlq2pWmlaj0MGhlCdPUZcY2zE43B3EA17WEdYW6 KbpA== X-Forwarded-Encrypted: i=1; AJvYcCXUNRuxF8r/G80b7wkKs2RoWDEvcOUHC4IQ74Q1XMDSULxvRpT1EdTEm0LHOVrT/8wul0Khpm8ggtEXzFU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGBKVqcaopLzhcchxTWol9jDDY+AMoF4oQn615j1HOA+XvM1BL NZ4ZEANQNpYMAFCOnqj8vPtPyvhFrZ+XHldd9Kf0+0jfgDadtTT/UrOcb4ZZP4H5mQFkk9CGRqS 41Kjs4y5ZWQn+J0sC7W9RuO89UtKY/PefZVTaBy9SiBnC0w4mgZs77ka5Gkd340gW3x0= X-Gm-Gg: ATEYQzz70zl+uApBcJ0Q2AwQkkTeAfj7OlWYXGmTnxNpM3Ap174pbBYCMl/olGyyqdB tqZXYg+zerXw2XC7wY9xdV6os+6sFajuQRCrI3AbN6d4RFiaWGM7aQRLYo8TlQ3aVhZW9cMluQO NZ0XN+tcDL+mpU52QV0p0igpKyI8U3FG4iX34ztXBaQdMd+I6wxZLGzQMyUD3BL4CzhF1q5PRPW fZXIK2YNcWPBWAIbMR1DZvvvldsboozPamgtzHTI7lyoItMyLHi2Axk0XF1kbFHegcwlTfrgqFx 8R5IwMVyG/OP9DO3G90P3Z+/4qoWebOQdWG20KdHrqHZELLUOkX3BiDKCFRlVBDyotQI97HEm87 5Uw5DncjFe14sG1dj35dde8P5RmU4FOnH8cpzR6lAIeA+ad2SJ6TjNw== X-Received: by 2002:a17:902:7443:b0:2b0:6ba2:3d78 with SMTP id d9443c01a7336-2b06ba240a8mr22925195ad.3.1773824735447; Wed, 18 Mar 2026 02:05:35 -0700 (PDT) X-Received: by 2002:a17:902:7443:b0:2b0:6ba2:3d78 with SMTP id d9443c01a7336-2b06ba240a8mr22924965ad.3.1773824734948; Wed, 18 Mar 2026 02:05:34 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.118]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e603937sm19944875ad.57.2026.03.18.02.05.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 02:05:34 -0700 (PDT) Message-ID: <3ee87252-6b90-a389-0621-5b0b8d2f87ff@oss.qualcomm.com> Date: Wed, 18 Mar 2026 14:35:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v7 7/8] media: qcom: iris: split firmware_data from raw platform data To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260316-iris-platform-data-v7-0-fc79f003f51c@oss.qualcomm.com> <20260316-iris-platform-data-v7-7-fc79f003f51c@oss.qualcomm.com> Content-Language: en-US From: Dikshita Agarwal In-Reply-To: <20260316-iris-platform-data-v7-7-fc79f003f51c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: wRpyxyHmqa5whZov_yBDjwEp-eoceciD X-Proofpoint-ORIG-GUID: wRpyxyHmqa5whZov_yBDjwEp-eoceciD X-Authority-Analysis: v=2.4 cv=QsVTHFyd c=1 sm=1 tr=0 ts=69ba6ae0 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=RgczR8+8wRjDfzPIf2UjDw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=lkyXAShNmXRLqkyLKQ8A:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDA3NiBTYWx0ZWRfXz9sjcag79B28 RUCzzv5kDKIlhKHjOoiS/Ah7WWpNYl0x9gS4hbroBjFiBMOy0J2fp9/zg+6ZtdorHbfkhLwaoWz 9ftivUwbt06FLcaRYGZAnU0QzzPD18JTz1fglbMpdHFyawkLdMdjvFbN7QoPfRhOMbGPaeLj8Mn LjVy7C0/2jzsTcQl4x/yDNNnxY8I6xcxyqUVjvWqwrFAF0v1si8YyVfN/KjgjYQPyRXjCZ9GuSt Q94bhurtuA4Aqg8C4czY/xuOQAyXiEVlUXJpL7XZ7xrSt7RO5hW2xisqBD7UWBdOEE4MHstP9SY p7MHvkbDDkBknLJI5dDxmp9WkUFLKeOUmzjYVJkDWE3M1HKVK5yrp7aDLuF8N6W6UtWErvTwSAM mpivaBugBjlZ5w/PMjcU7y1/bAUGBWhgTukQqECoKhD//sKW0r9/sInUAre1SpdQZUtjX27G6BC +65a7p5NayzOS4jEjiw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_05,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 spamscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180076 On 3/17/2026 12:24 AM, Dmitry Baryshkov wrote: > Having firmware-related fields in platform data results in the tying > platform data to the HFI firmware data rather than the actual hardware. > For example, SM8450 uses Gen2 firmware, so currently its platform data > should be placed next to the other gen2 platforms, although it has the > VPU2.0 core, similar to the one found on SM8250 and SC7280 and so the > hardware-specific platform data is also close to those devices. > > Split firmware data to a separate struct, separating hardware-related > data from the firmware interfaces. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 82 +++---- > drivers/media/platform/qcom/iris/iris_core.h | 2 + > drivers/media/platform/qcom/iris/iris_ctrls.c | 8 +- > .../platform/qcom/iris/iris_hfi_gen1_command.c | 8 +- > .../platform/qcom/iris/iris_hfi_gen2_command.c | 66 +++--- > .../platform/qcom/iris/iris_platform_common.h | 82 ++++--- > .../media/platform/qcom/iris/iris_platform_gen1.c | 67 +++--- > .../media/platform/qcom/iris/iris_platform_gen2.c | 246 ++++----------------- > drivers/media/platform/qcom/iris/iris_probe.c | 3 +- > drivers/media/platform/qcom/iris/iris_vidc.c | 10 +- > 10 files changed, 205 insertions(+), 369 deletions(-) > > -struct iris_platform_data { > +struct iris_firmware_data { > void (*init_hfi_ops)(struct iris_core *core); > - u32 (*get_vpu_buffer_size)(struct iris_inst *inst, enum iris_buffer_type buffer_type); > - const struct vpu_ops *vpu_ops; > - const struct icc_info *icc_tbl; > - unsigned int icc_tbl_size; > - const struct bw_info *bw_tbl_dec; > - unsigned int bw_tbl_dec_size; > - const char * const *pmdomain_tbl; > - unsigned int pmdomain_tbl_size; > - const char * const *opp_pd_tbl; > - unsigned int opp_pd_tbl_size; > - const struct platform_clk_data *clk_tbl; > - const char * const *opp_clk_tbl; > - unsigned int clk_tbl_size; > - const char * const *clk_rst_tbl; > - unsigned int clk_rst_tbl_size; > - const char * const *controller_rst_tbl; > - unsigned int controller_rst_tbl_size; > - u64 dma_mask; > - const char *fwname; > - struct iris_fmt *inst_iris_fmts; > - u32 inst_iris_fmts_size; > - struct platform_inst_caps *inst_caps; > + > const struct platform_inst_fw_cap *inst_fw_caps_dec; > u32 inst_fw_caps_dec_size; > const struct platform_inst_fw_cap *inst_fw_caps_enc; > u32 inst_fw_caps_enc_size; > - const struct tz_cp_config *tz_cp_config_data; > - u32 tz_cp_config_data_size; > - u32 core_arch; This can also be tied to firmware data as this is required to be set for Gen2 only and is 0 for Gen1. Thanks, Dikshita