mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Remy Bohmer" <linux@bohmer.net>
To: "Haavard Skinnemoen" <hskinnemoen@atmel.com>
Cc: "Andrew Victor" <linux@maxim.org.za>,
	"ARM Linux Mailing List"
	<linux-arm-kernel@lists.arm.linux.org.uk>,
	"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atmel_serial: Split the interrupt handler
Date: Wed, 19 Dec 2007 14:18:18 +0100	[thread overview]
Message-ID: <3efb10970712190518x384f06e7q39f8fd2a53e50d60@mail.gmail.com> (raw)
In-Reply-To: <20071219141100.7384aff9@dhcp-252-066.norway.atmel.com>

Hello Haavard,

> Hrm. We probably need to lock while updating icount. That's a problem
> since we do that from the tx interrupt handler...and I don't suppose we
> want to move most of the atmel_tx_chars() code into the tasklet too...?

I do not see a reason why not moving transmit to a tasklet. It is only
time critical to read in time. If the transmit is postponed for a
while, it will only slow down transmission, while not reading in time
results in lost data.

Kind Regards,

Remy

  reply	other threads:[~2007-12-19 13:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-18 14:14 Haavard Skinnemoen
2007-12-18 15:23 ` Remy Bohmer
2007-12-18 17:19   ` Haavard Skinnemoen
2007-12-18 19:18     ` Remy Bohmer
2007-12-19 12:34   ` Haavard Skinnemoen
2007-12-19 12:50     ` Remy Bohmer
2007-12-19 13:11       ` Haavard Skinnemoen
2007-12-19 13:18         ` Remy Bohmer [this message]
2007-12-19 13:24           ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3efb10970712190518x384f06e7q39f8fd2a53e50d60@mail.gmail.com \
    --to=linux@bohmer.net \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@maxim.org.za \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®