mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Remy Bohmer" <linux@bohmer.net>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, RT <linux-rt-users@vger.kernel.org>
Subject: Compile bug in 2.6.24.8-rt7 on ARM
Date: Tue, 20 May 2008 22:37:34 +0200	[thread overview]
Message-ID: <3efb10970805201337g2212835bl9ca26a3031141ce2@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

Hello Steven,

Now I started looking at compiling 2.6.24.7-rt8 for ARM, and I found
another compile problem... ;-))

This one:
 CC      arch/arm/kernel/process.o
arch/arm/kernel/process.c: In function 'cpu_idle':
arch/arm/kernel/process.c:175: error: implicit declaration of function
'trace_preempt_exit_idle'
arch/arm/kernel/process.c:180: error: implicit declaration of function
'trace_preempt_enter_idle'

These function do not appear to exist _anywhere_ in the kernel.
So these calls can safely be removed, I guess.

The offending patch can be found in the broken-out set under the name
arm-trace-preempt-idle.patch.
Attached you can find a fix for it (I expect that you will not need it)


Kind Regards,

Remy

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-compile-error-trace-preempt.patch --]
[-- Type: text/x-patch; name=fix-compile-error-trace-preempt.patch, Size: 1038 bytes --]

This patch fixes this compile error in 2.6.24.7-rt8:
 CC      arch/arm/kernel/process.o
arch/arm/kernel/process.c: In function 'cpu_idle':
arch/arm/kernel/process.c:175: error: implicit declaration of function 'trace_preempt_exit_idle'
arch/arm/kernel/process.c:180: error: implicit declaration of function 'trace_preempt_enter_idle'

Signed-off-by: Remy Bohmer <linux@bohmer.net>
---
 arch/arm/kernel/process.c |    2 --
 1 file changed, 2 deletions(-)

Index: linux-2.6.24/arch/arm/kernel/process.c
===================================================================
--- linux-2.6.24.orig/arch/arm/kernel/process.c	2008-05-20 22:06:33.000000000 +0200
+++ linux-2.6.24/arch/arm/kernel/process.c	2008-05-20 22:30:37.000000000 +0200
@@ -172,12 +172,10 @@ void cpu_idle(void)
 			idle();
 		leds_event(led_idle_end);
 		local_irq_disable();
-		trace_preempt_exit_idle();
 		tick_nohz_restart_sched_tick();
 		__preempt_enable_no_resched();
 		__schedule();
 		preempt_disable();
-		trace_preempt_enter_idle();
 		local_irq_enable();
 	}
 }

             reply	other threads:[~2008-05-20 20:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20 20:37 Remy Bohmer [this message]
2008-05-20 20:55 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3efb10970805201337g2212835bl9ca26a3031141ce2@mail.gmail.com \
    --to=linux@bohmer.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®