From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Douglas Anderson <dianders@chromium.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Shuijing Li <shuijing.li@mediatek.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Xinlei Lee <xinlei.lee@mediatek.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare()
Date: Mon, 20 May 2024 11:48:36 +0200 [thread overview]
Message-ID: <3efcc6c1-054c-444e-abd1-230124964307@collabora.com> (raw)
In-Reply-To: <20240517143643.3.Ibffbaa5b4999ac0e55f43bf353144433b099d727@changeid>
Il 17/05/24 23:36, Douglas Anderson ha scritto:
> The mipi_dsi_dcs_nop() function returns an error but we weren't
> checking it in boe_panel_prepare(). Add a check. This is highly
> unlikely to matter in practice. If the NOP failed then likely later
> MIPI commands would fail too.
>
> Found by code inspection.
>
> Fixes: 812562b8d881 ("drm/panel: boe-tv101wum-nl6: Fine tune the panel power sequence")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2024-05-20 9:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 21:36 [PATCH 0/8] drm/panel: Some very minor err handling fixes + more _multi Douglas Anderson
2024-05-17 21:36 ` [PATCH 1/8] drm/panel: himax-hx8394: Handle errors from mipi_dsi_dcs_set_display_on() better Douglas Anderson
2024-05-19 22:25 ` Dmitry Baryshkov
2024-05-17 21:36 ` [PATCH 2/8] drm/panel: boe-tv101wum-nl6: If prepare fails, disable GPIO before regulators Douglas Anderson
2024-05-19 22:26 ` Dmitry Baryshkov
2024-05-17 21:36 ` [PATCH 3/8] drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare() Douglas Anderson
2024-05-19 22:26 ` Dmitry Baryshkov
2024-05-20 9:48 ` AngeloGioacchino Del Regno [this message]
2024-05-17 21:36 ` [PATCH 4/8] drm/panel: ilitek-ili9882t: If prepare fails, disable GPIO before regulators Douglas Anderson
2024-05-19 22:26 ` Dmitry Baryshkov
2024-05-17 21:36 ` [PATCH 5/8] drm/panel: ilitek-ili9882t: Check for errors on the NOP in prepare() Douglas Anderson
2024-05-19 22:27 ` Dmitry Baryshkov
2024-05-17 21:36 ` [PATCH 6/8] drm/panel: himax-hx83102: If prepare fails, disable GPIO before regulators Douglas Anderson
2024-05-19 22:27 ` Dmitry Baryshkov
2024-05-17 21:36 ` [PATCH 7/8] drm/panel: himax-hx83102: Check for errors on the NOP in prepare() Douglas Anderson
2024-05-19 22:27 ` Dmitry Baryshkov
2024-05-17 21:36 ` [PATCH 8/8] drm/panel: himax-hx83102: use wrapped MIPI DCS functions Douglas Anderson
2024-05-19 22:28 ` Dmitry Baryshkov
2024-05-19 6:17 ` [PATCH 0/8] drm/panel: Some very minor err handling fixes + more _multi Linus Walleij
2024-05-23 7:37 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3efcc6c1-054c-444e-abd1-230124964307@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=sam@ravnborg.org \
--cc=shuijing.li@mediatek.com \
--cc=tzimmermann@suse.de \
--cc=xinlei.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®