From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751535AbcGNQUu (ORCPT ); Thu, 14 Jul 2016 12:20:50 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:46632 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbcGNQUq (ORCPT ); Thu, 14 Jul 2016 12:20:46 -0400 Subject: Re: [PATCH] security: Use IS_ENABLED() instead of checking for built-in or module To: Casey Schaufler , linux-kernel@vger.kernel.org References: <1468512050-26272-1-git-send-email-javier@osg.samsung.com> Cc: "Serge E. Hallyn" , Paul Moore , linux-security-module@vger.kernel.org, Stephen Smalley , Eric Paris , selinux@tycho.nsa.gov, James Morris From: Javier Martinez Canillas Message-ID: <3f0053fa-8824-f86f-e04f-16ad1204abc7@osg.samsung.com> Date: Thu, 14 Jul 2016 12:20:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Casey, On 07/14/2016 12:17 PM, Casey Schaufler wrote: > On 7/14/2016 9:00 AM, Javier Martinez Canillas wrote: >> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either >> built-in or as a module, use that macro instead of open coding the same. > > Why? > Why not? We have a macro for this so why is better to open coding it? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America