From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE40CDB465 for ; Thu, 19 Oct 2023 16:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233023AbjJSQgP (ORCPT ); Thu, 19 Oct 2023 12:36:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231837AbjJSQgM (ORCPT ); Thu, 19 Oct 2023 12:36:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D131E11B for ; Thu, 19 Oct 2023 09:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697733328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A0TxOuArDcomwzRpdOzuputQGYUhRrujAZgHVzm3P74=; b=howsi1Zq2FaXu+TtnqboG1TkDAYl38Lr91etbww9VC/QJoS3uaWNudElj1HidHp1+QIPs1 NZUierBBBoeBjm27C+Ui7woNwEe0H04b9fpIYD//69nucIcHVhyC5yn87xYi+ufGe5fKTP bqYBk7ZHZuTJXcJZAb7aC72o9IJgY4M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-QnnxGI2yNW6TXlgwbkvJMQ-1; Thu, 19 Oct 2023 12:35:22 -0400 X-MC-Unique: QnnxGI2yNW6TXlgwbkvJMQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C62E88CC4B; Thu, 19 Oct 2023 16:35:22 +0000 (UTC) Received: from [10.45.226.105] (unknown [10.45.226.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CEF22026D4C; Thu, 19 Oct 2023 16:35:19 +0000 (UTC) Message-ID: <3f12a532-a0f9-4a7e-bfda-c85b539b81d0@redhat.com> Date: Thu, 19 Oct 2023 18:35:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value Content-Language: en-US To: Simon Horman Cc: netdev@vger.kernel.org, Mateusz Palczewski , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "moderated list:INTEL ETHERNET DRIVERS" , open list References: <20231018112621.463893-1-ivecera@redhat.com> <20231019091408.GA2100445@kernel.org> From: Ivan Vecera In-Reply-To: <20231019091408.GA2100445@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19. 10. 23 11:15, Simon Horman wrote: > On Wed, Oct 18, 2023 at 01:26:20PM +0200, Ivan Vecera wrote: >> Commit c87c938f62d8f1 ("i40e: Add VF VLAN pruning") added new >> PF flag I40E_FLAG_VF_VLAN_PRUNING but its value collides with >> existing I40E_FLAG_TOTAL_PORT_SHUTDOWN_ENABLED flag. >> >> Move the affected flag at the end of the flags and fix its value. >> >> Cc: Mateusz Palczewski >> Signed-off-by: Ivan Vecera > > Hi Ivan, > > I agree with the correctness of this patch and that it was > introduced by the cited commit. > > However, I do wonder if, as a fix for 'net': > > 1) The patch description could include some discussion of > what problem is resolved, and, ideally, how I user might > get into such a situation. > > 2) The following fixes tag is appropriate. > > Fixes: c87c938f62d8 ("i40e: Add VF VLAN pruning") > Ahh, thanks Simon! I forgot to add Fixes: tag. Will fix it by v2 and add the reproducer. Thanks, Ivan