From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6AFAC433E0 for ; Sat, 13 Feb 2021 08:48:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B28764DE0 for ; Sat, 13 Feb 2021 08:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbhBMInb (ORCPT ); Sat, 13 Feb 2021 03:43:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:60436 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbhBMIn2 (ORCPT ); Sat, 13 Feb 2021 03:43:28 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5F7D1AC32; Sat, 13 Feb 2021 08:42:47 +0000 (UTC) Subject: Re: [PATCH] nvme-tcp: Check if request has started before processing it To: Daniel Wagner , linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Sagi Grimberg , Christoph Hellwig , Jens Axboe , Keith Busch References: <20210212181738.79274-1-dwagner@suse.de> From: Hannes Reinecke Message-ID: <3f183393-cc1e-3d03-3074-40c18f3cb9cc@suse.de> Date: Sat, 13 Feb 2021 09:42:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210212181738.79274-1-dwagner@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/12/21 7:17 PM, Daniel Wagner wrote: > blk_mq_tag_to_rq() will always return a request if the command_id is > in the valid range. Check if the request has been started. If we > blindly process the request we might double complete a request which > can be fatal. > > Signed-off-by: Daniel Wagner > --- > > This patch is against nvme-5.12. > > There is one blk_mq_tag_to_rq() in nvme_tcp_recv_ddgst() which I > didn't update as I am not sure if it's also needed. > I guess it is; this patch is essentially a protection against invalid frames, and as such affects all places. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer