From: Daniel Schultz <D.Schultz@phytec.de>
To: Krzysztof Kozlowski <krzk@kernel.org>, "nm@ti.com" <nm@ti.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"kristo@kernel.org" <kristo@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Wadim Egorov <W.Egorov@phytec.de>,
"upstream@lists.phytec.de" <upstream@lists.phytec.de>
Subject: Re: [PATCH] arm64: dts: ti: am64-phyboard-electra: Add DT overlay for X27 connector
Date: Tue, 28 Jan 2025 08:43:41 +0000 [thread overview]
Message-ID: <3f1d962f-ecfa-40e1-b699-95c38a853d15@phytec.de> (raw)
In-Reply-To: <2dd9bffa-17d5-4635-b2da-15f59cf07590@kernel.org>
Hi,
On 27.01.25 18:24, Krzysztof Kozlowski wrote:
> On 27/01/2025 07:57, Daniel Schultz wrote:
>> +&main_spi1 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&main_spi1_pins_default>;
>> + ti,pindir-d0-out-d1-in = <1>;
>> + status = "okay";
>> +
>> + spidev@0 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>
>> + compatible = "rohm,dh2228fv";
>
> That's not the device you have there. You cannot use other compatibles.
I will remove that device for now and see if I can find a supported
device on Sparkfun or similar, which I can add later.
- Daniel
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-01-28 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 6:57 Daniel Schultz
2025-01-27 17:24 ` Krzysztof Kozlowski
2025-01-28 8:43 ` Daniel Schultz [this message]
2025-01-28 9:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f1d962f-ecfa-40e1-b699-95c38a853d15@phytec.de \
--to=d.schultz@phytec.de \
--cc=W.Egorov@phytec.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=upstream@lists.phytec.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®