From: Julia Lawall <julia.lawall@inria.fr>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Markus Elfring <Markus.Elfring@web.de>,
Michael Ellerman <mpe@ellerman.id.au>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"cocci@inria.fr" <cocci@inria.fr>
Subject: Re: [0/2] powerpc/powernv/vas: Adjustments for two function implementations
Date: Tue, 16 Apr 2024 14:56:50 +0200 (CEST) [thread overview]
Message-ID: <3f22920-9543-efd1-a32a-477ae18a2b2a@inria.fr> (raw)
In-Reply-To: <3711cad3-a627-4a6e-8769-ce916c1919ee@csgroup.eu>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On Tue, 16 Apr 2024, Christophe Leroy wrote:
>
>
> Le 16/04/2024 à 14:14, Markus Elfring a écrit :
> >> This is explicit in Kernel documentation:
> >>
> >> /**
> >> * kfree - free previously allocated memory
> >> * @object: pointer returned by kmalloc() or kmem_cache_alloc()
> >> *
> >> * If @object is NULL, no operation is performed.
> >> */
> >>
> >> That's exactly the same behaviour as free() in libc.
> >>
> >> So Coccinelle should be fixed if it reports an error for that.
> >
> > Redundant function calls can occasionally be avoided accordingly,
> > can't they?
>
> Sure they can, but is that worth it here ?
Coccinelle does what the developer of the semantic patch tells it to do.
It doesn't spontaneously report errors for anything.
julia
next prev parent reply other threads:[~2024-04-16 12:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 19:15 [PATCH 0/2] " Markus Elfring
2023-12-23 19:20 ` [PATCH 1/2] powerpc/powernv/vas: One function call less in vas_window_alloc() after error detection Markus Elfring
2023-12-23 19:22 ` [PATCH 2/2] powerpc/powernv/vas: Return directly after a failed kasprintf() in map_paste_region() Markus Elfring
2024-04-15 7:42 ` [0/2] powerpc/powernv/vas: Adjustments for two function implementations Markus Elfring
2024-04-16 11:11 ` Michael Ellerman
2024-04-16 11:32 ` Christophe Leroy
2024-04-16 12:14 ` Markus Elfring
2024-04-16 12:18 ` Christophe Leroy
2024-04-16 12:56 ` Julia Lawall [this message]
2024-04-16 13:05 ` Markus Elfring
2024-04-16 14:05 ` [0/2] powerpc/powernv/vas: Adjustments for map_paste_region()? Markus Elfring
2024-04-16 12:04 ` [0/2] powerpc/powernv/vas: Adjustments for two function implementations Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f22920-9543-efd1-a32a-477ae18a2b2a@inria.fr \
--to=julia.lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=aneesh.kumar@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=cocci@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®