From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 59834285C8F
	for <linux-kernel@vger.kernel.org>; Fri, 15 Aug 2025 11:25:05 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1755257107; cv=none; b=MRGZbRiCDdfM+ebdnaqeLpBw4M7kJ/CMH2inJataVbJj3ThUvQEFHDdaOPmwcw0+MWMImGxJPzVav3dG7qITTFPyd+57bysyQhfxknqKaCp3BhZ94KRc0TDmPXqS6HUqB+kzwmYnjbHaMFAmV7J+o+tR2BAkrDuwWIztL8jHByU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1755257107; c=relaxed/simple;
	bh=ToCpNGVj+UtbHOl+jyIQotO2F3I5yBoCuqsvSidQerw=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=m/cJn2lAH4Amsa3e4P3WhT1F0HXNY6LHawzLOxCSYcB0i4OBGnERZPx65hbzql7HAU1B733TuXqVj85m17TXweEVeAKdPVhw9I01BQHZCxjw+BBHKYO19J/ooKGr5KRoG4TUUMwz/gb3AbhgVh+UE+r2aHflQnX+Gg9eoLdlK5g=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A32F1691;
	Fri, 15 Aug 2025 04:24:56 -0700 (PDT)
Received: from [10.1.29.14] (e122027.cambridge.arm.com [10.1.29.14])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D253D3F63F;
	Fri, 15 Aug 2025 04:25:02 -0700 (PDT)
Message-ID: <3f266ba8-d7a5-4f2d-aef8-a3c5b9b3a601@arm.com>
Date: Fri, 15 Aug 2025 12:25:00 +0100
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/panthor: Remove dead code in
 mmu_hw_do_operation_locked
To: Daniel Stone <daniel@fooishbar.org>
Cc: Boris Brezillon <boris.brezillon@collabora.com>,
 Liviu Dudau <liviu.dudau@arm.com>, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org, Karunika Choo <karunika.choo@arm.com>,
 Chia-I Wu <olvaffe@gmail.com>
References: <20250815102539.39711-1-steven.price@arm.com>
 <CAPj87rPSoYe10JqpwYO=-tTX2EqnwB29wrYfhyWwpAyAczRVig@mail.gmail.com>
From: Steven Price <steven.price@arm.com>
Content-Language: en-GB
In-Reply-To: <CAPj87rPSoYe10JqpwYO=-tTX2EqnwB29wrYfhyWwpAyAczRVig@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 15/08/2025 12:17, Daniel Stone wrote:
> Hi Steven,
> 
> On Fri, 15 Aug 2025 at 11:25, Steven Price <steven.price@arm.com> wrote:
>> The only callers to mmu_hw_do_operation_locked() pass an 'op' of either
>> AS_COMAND_FLUSH_MEM or AS_COMMAND_FLUSH_PT. So remove the code paths
>> that test for other operations and add a drm_WARN_ON() to catch the
>> posibility of others appearing the future.
> 
> Thanks! I think it would make sense to also inline
> mmu_hw_do_flush_on_gpu_ctrl() here though.

True, I'll have a go at a proper rewrite of that function to make it
more coherent.

Thanks,
Steve