mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Chengming Zhou <zhouchengming@bytedance.com>,
	syzbot <syzbot+fcc47ba2476570cbbeb0@syzkaller.appspotmail.com>,
	axboe@kernel.dk, chaitanyak@nvidia.com, eadavis@qq.com,
	hch@infradead.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, ming.lei@redhat.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [External] Re: [syzbot] [block?] WARNING in blk_mq_start_request
Date: Mon, 13 Nov 2023 15:57:38 -0800	[thread overview]
Message-ID: <3f2c2d33-2e5d-4c7b-80ea-e76885981dfb@acm.org> (raw)
In-Reply-To: <d9f1ee3b-c303-44af-ba30-b52137fc29cb@bytedance.com>

On 11/13/23 07:05, Chengming Zhou wrote:
> Ok, I reviewed the code of virtio_queue_rqs(), found the main difference
> is that request won't fail after blk_mq_start_request().
> 
> But in null_blk case, the request will fail after blk_mq_start_request(),
> return BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE. If we return these rqs
> back to the block layer core, they will be queued individually once again.
> So caused the warning.

I think it is safe to move the blk_mq_start_request() call under the if-block
that decides whether or not to requeue a request in null_queue_rq()

Thanks,

Bart.

  reply	other threads:[~2023-11-13 23:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_C325838DE11216DD9C5DAA192E4FCA0DD207@qq.com>
2023-11-08  0:52 ` syzbot
2023-11-08  1:35   ` [syzbot] [PATCH] Test for 4652b8e4f3ff syzbot
2023-11-08  6:25   ` syzbot
2023-11-08 21:18   ` [syzbot] [block?] WARNING in blk_mq_start_request syzbot
2023-11-09  1:27     ` Chengming Zhou
2023-11-09 18:13       ` Bart Van Assche
2023-11-13 15:05         ` [External] " Chengming Zhou
2023-11-13 23:57           ` Bart Van Assche [this message]
2023-11-14 15:05             ` Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f2c2d33-2e5d-4c7b-80ea-e76885981dfb@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=chaitanyak@nvidia.com \
    --cc=eadavis@qq.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=syzbot+fcc47ba2476570cbbeb0@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome